- 19 9月, 2019 12 次提交
-
-
由 Joey Robichaud 提交于
Change the Using organizer to not use ElasticTrivia for the NewLine
-
由 AlekseyTs 提交于
Fixes #38711.
-
由 Joey Robichaud 提交于
-
由 Joey Robichaud 提交于
-
由 Joey Robichaud 提交于
-
由 Joey Robichaud 提交于
-
由 Joey Robichaud 提交于
-
由 AlekseyTs 提交于
Add handling for unconventional implementation of events and properties when Default Interface Implementations are involved. (#38683) Closes #34452. Closes #34453.
-
由 Gen Lu 提交于
Remove unnecessary nullable suppression
-
由 David 提交于
Export limited semantic model in liveshare scenario to avoid null ptrs
-
由 Joey Robichaud 提交于
Workaround to unblock builds
-
由 juanam 提交于
-
- 18 9月, 2019 9 次提交
-
-
由 Jared Parsons 提交于
Additional logging in the compiler server
-
由 Gen Lu 提交于
-
由 Julien Couvreur 提交于
-
由 Gen Lu 提交于
Codefix and Code Refactoring for making local functions static
-
由 David Barbet 提交于
-
由 Gen Lu 提交于
-
由 AlekseyTs 提交于
Fixes #38469.
-
由 Gen Lu 提交于
-
由 Rikki Gibson 提交于
-
- 17 9月, 2019 11 次提交
-
-
由 Tomáš Matoušek 提交于
* Misc cleanup * Reuse previously resolved missing assembly metadata objects when identity doesn't match Background When the compiler is resolving compilation references and encounters a reference whose assembly identity does not match any of the explicitly given references it falls back to a Reference Resolver. In regular compilation an error is reported since there is no Reference Resolver. Interactive compiler supplies a resolver that attempts to find the missing reference. Once the missing reference is found the compiler adds it to the list of implicitly resolved assemblies and if the same missing assembly identity is referenced later (by a subsequent submission) it reuses the assembly symbol from this list, so that we don't end up loading multiple instances of the same missing assembly. [1] The resolver may find an assembly that matches the name of the missing reference but doesn't match the version exactly. This is expected as a newer version of the assembly may be available than was referenced and the compiler correctly binds to the newer version. Issues The first submission added a reference to a netstandard20 library on .NET Core and the subsequent submission referenced a type from that library. The reference resolution in the compilation corresponding to the second submission ended up adding a new, distinct reference to the library, instead of reusing the one that was already resolved for the first submission compilation. This was caused by mismatch in versions of some of the facades transitively referenced by the library thru netstandard.dll reference and resolved thru the missing reference resolution mechanism. The facades ware referenced with different versions than the actual versions available in the set of references the Reference Resolver resolved missing references from. The compiler ended up using two distinct instances of the same facade assembly metadata. An assembly symbol is only reused if all its transitively referenced assemblies match. In this case the library assembly symbol wasn't reused because some of the facade assembly symbols did not match. The problem was that the mechanism [1] didn't reuse missing assembly metadata with a different version than what was requested. The fix is to check whether we have seen an assembly with the resolved identity in addition to the requested identity. Another issue found during testing is handing resolution failures. We did not remember that a resolution of a given assembly identity failed and attempted to resolve the assembly again in the next submission. This may lead to inconsistencies and the same "can't convert T to T" errors since first submission might have a missing assembly symbol and next might create a real assembly symbol for the same assembly identity. The fix is to capture both successful and failed resolution results. * Do not add resolved identity entry to implicit reference resolutions
-
由 Gen Lu 提交于
-
由 Gen Lu 提交于
-
由 Gen Lu 提交于
-
由 Gen Lu 提交于
-
由 Manish Vasani 提交于
Bump up flow analysis utilities version
-
由 Gen Lu 提交于
-
https://github.com/dotnet/arcade由 dotnet-maestro[bot] 提交于
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19463.3
-
由 Jared Parsons 提交于
-
由 Jared Parsons 提交于
Issue #31417: Add SARIF v2.1.0 support
-
由 Manish Vasani 提交于
Use the latest flow analysis utilities package
-
- 15 9月, 2019 2 次提交
-
-
由 Sam Harwell 提交于
🐛 Fix Type/Constructor deduplication in Find All References -
由 Sam Harwell 提交于
Fix inconsistencies with nullability annotations in the BCL
-
- 14 9月, 2019 6 次提交
-
-
由 juanam 提交于
-
由 Gen Lu 提交于
-
由 Rikki Gibson 提交于
-
由 Larry Golding 提交于
-
由 Jared Parsons 提交于
Adding additional logging data to help track down the exception we are seeing while calling `Mutex.ReleaseMutex`. https://github.com/dotnet/coreclr/issues/26659 https://github.com/dotnet/roslyn/issues/37974
-
由 Jared Parsons 提交于
-