* Test compositions

* Eliminate TestExportProvider

* Fixes and caching

* Debugger proxies

* Scopes

* Feedback and more fixes

* RemoteHostOptions

* Throw without timeout on invalid thread switches

* EventCollectorTests requires a main thread

Closes #43728

* Add Solution.AnalyzerReferences

* HostDiagnosticAnalyzers

* Move types down to Workspaces

* Refactoring

* Refactoring

* Refactoring

* Feedback

* Misc feedback

* Use ValueTask instead of custom task caching

through IDynamicFileInfoProvider and etc, external component such as razor should be able to provide us dynamic file (such as generated c# content for cshtml file) on the fly and let us know update on the content.

renamed Column to Character since Column should be only used when it accounts "tab". and count "tab" as tab size rather than just 1 char.

moved FAR to work on top of new set of APIs. it should now show things on html correctly

added support for code lens. but found 1 issue. without changing VS side, I can't fix filename. and without fixing filename, navigation won't work properly

* Remove duplicate lock DocumentState.s_syntaxTreeToIdMapLock

This lock is only being used to protect access to an instance which contains
internal synchronization.

* Better handle surrounding directives when inlining a local variable.

* Add tests.

* Share code between VB and C#.

* Reduce allocations in UnboundLambda

Fixes #23463

* Restore ReturnInferenceCacheKey as the key for _returnInferenceCache

* Update code to more closely follow patterns of the original code

* Cleanup from code review

* basic fix for intellisense in Immediate window

* better comments and cleanup

* Add basic integration tests

* cleanup inproc Immediate window integration test helper

* fix incorrect comment

* address PR feedback

* create Immediate window on ImmediateWindow_InProc.GetText()

* Verify MSBuild version in Developer CMD prompt

Roslyn is designed to have the simplest possible contribution story:
clone then build. Every pre-req needed is either located on the machine
or bootstrapped via NuGet. All the way down to using an xcopy MSBuild if
needed.

The one case which causes a problem is the VS command prompt. In this
case MSBuild is pre-installed on the machine and may or may not be
suitable for building Roslyn.

Previously when building from a VS command prompt we just used whatever
MSBuild was provided. The assumption being a developer command prompt
was an explicit statement of whath MSBuild you wanted to use. Based on
all of our customer reports though this does not seem to be the
assumption that consumers of our repo have. The build gave them no
explicit errors about the provided toolset and hence when the build
failed they assigned flakiness to our repo.

Going forward we are applying the same version validation to MSBuild
when provided via a developer command prompt. If it doesn't match we
will refuse to build asking the user to upgrade VS or build from a
normal command prompt.

* Remove unneeded debugging line

* Comment about pre-release

* Added minimum version

* Add Omit If Default style option

* Add space to be like test without the omit

* Add/Remove without needing a property

* Reformat

* PR feedback

* Fix VB diagnostic based on feedback

* Handle case of NotApplicable modifier and field declaration list

* Fix tests

* PR feedback

* PR feedback

* PreviewCodeAction was overriding ComputeOperations but returning a post-processed operation from original action. This results in another PostProcess being called on the codeaction. If postprocess was overriden in originalaction that'll be ignored the second time (#23920)

* Support negative null-check when we are suggesting to inline type checks

Fixes #21097
Fixes #24286

* fix a case where persistent storage registration fails and some clean… (#24458)

* fix a case where persistent storage registration fails and some clean up code around it.

* added readonly

* address PR feedback

* removed comments no longer relevant

* renamed lock name

* moved waiter from diagnostics.dll to features.dll where all interfaces are defined. (#24512)

* put listener change back in (https://github.com/dotnet/roslyn/pull/24120)

* leave old types in legacy folder until partner teams move to new interface

* added legacy waiter to support partner teams

* Remove methods indirecting access to _metadataFileNameToConvertedProjectReference

This field is documented as being written and read from any thread,
but in practice all uses are guarded by an AssertIsForeground(). Thus
we can get rid of the helper methods that are trying to "help" by
locking before accessing the fields, making it really hard to track all
the real uses of it.

* Make method static that doesn't need state

* add a comment to address PR feedback

* Fix up tests of P2P to metadata reference conversion

It turns out we had some tests, but the tests were disabled. This was
because the tests weren't working properly anyways: they were calling
into UpdateProjectBinPath which only updated some (but not all) of
the project state. That was an internal helper method that shouldn't
be used by tests. Updating the tests to use
SetBinOutputPathAndRelatedData works better.

* Delete debug-only reference validation

This was some legacy code that tried to verify that the references
we have from the project system match up to what DTE and other sources
say. This was debug-only, and the actual asserts were commented out.
This is deadweight at this point, so delete it.

* added and cleaned up logs around build and live diagnostics. (#24551)

also added RoslynActivityLogger that can be enabled through project-system-tool

* Avoid closure allocations on the BindSyntaxTreeToId fast path

* CS1628 error text mentions in parameters; fixes #24584

* Small cleanup of completion logic.

* Move to xunit.console for CoreClr tests

Previously we were using xunit.console for desktop tests and dotnet-xunit for our
CoreClr tests. This change unifies us on top of xunit.console (now that it has a
netcoreapp2.0 version available).

* Move unix builds to xunit.runner.console as well

* Get actual directory name, not file

* Fix dir name issue

* fixed build break

* put listener change back in (https://github.com/dotnet/roslyn/pull/24120)

* leave old types in legacy folder until partner teams move to new interface

* added legacy waiter to support partner teams

* Add UseCultureAttribute to help with culture-dependent unit tests

* Disable NuGet package restore in Visual Studio for Roslyn.sln

* Add named argument for literal

* Fix behavior for NET46 and NETCOREAPP2_0

* Revert "moved waiter from diagnostics.dll to features.dll where all interface… (#24120)"

This reverts commit 823d9730.

* Add references to System.IO.Pipes.AccessControl (#24457)

When adding the reference to System.IO.Pipes.AccessControl for the
compiler server to use on CoreCLR, I unified the pathway for the desktop
and CoreCLR server access control code. This means that
System.IO.Pipes.AccessControl needed to be added as a dependent DLL for
desktop too, but I forgot to do that. This change adds
System.IO.Pipes.AccessControl as a dependent DLL in all the places where
the build task is deployed.

This reverts commit 823d9730.

* moved waiter from diagnostics.dll to features.dll where all interfaces are defined.

* simplified listener and waiter and moved those in product.

* cleaned up a bit

* fixed some comments

* forgot to add new AsyncListenerProvider in test export composition

* fixed dead lock found on unit tests

* remove all waiters left

* added dispatcher event processing in one more place

* added a way to enable waiter through env variable in test such as DDRIT

* added env var support so that It can be used without internalvisibleTo us.

* dont wait for all waiters but only onces each test used to wait.

* removed dependency to Roslyn.Services.Test.Utilities in integration test. that dll is not in probing path.

* fixed test failures

* fixed bug in integration tests

* move call to enable waiter before creating workspace so that workspace event queue get proper async listener

* expose concret type as well so that it can be directly used in test for waiter

* addressed PR feedbacks.

* rename mess up

* extra ) left out

* fixed build failure

When breaking up our unit test assemblies I accidentally moved some test code to a non-unit test project.  Split the file up and moved the code back to the correct test project.

Reanabling the tests skipped with xunit tag

Revert "Revert "Disable diagnostic service for projects that we know we don't have all information to provide good results.""

Revert "Disable diagnostic service for projects that we know we don't have all information to provide good results."

this should make roslyn to turn off full project diagnostics when intellisense build is failed for the project.

when we detect intellisense build failure, VS should put actionable data in error list detail pane.
also bing search for the issue should work as well if one prefer blogs.

this change also fix some issue on cross language p2p references. before there was case where we fail to connect cross language p2p reference causing a lot of errors.

this change also include bulk diagnostic update events improvement. this should let us to deal better (especially when we clean those up) when there are a lot of diagnostics.