Don't offer to use pattern matching if a user defined operator was involved.

Fix no completion in partially written code before 'await'.

* parameter refness update in local funcitons/lambda should be caught as an edit

* handling empty accessors and bodies

* removing unused internal parameter

Add test documentation to the PR template

Fix crash in VisualBasic.Binder.MemberLookup.AddLookupSymbolsInfoInTypeParameter when it is called with Cref TypeParameter. (#21586)

Fixes https://devdiv.visualstudio.com/DefaultCollection/DevDiv/_workitems?id=410932.

The fix mimics the way C# compiler handles Cref TypeParameters in the similar API.

3 product changes and 1 test change on sqlite persisted storage

removed usage of ImmutableArray in json.net

Update to Microsoft.DiaSymReader.PortablePdb, Microsoft.DiaSymReader.Converter.Xml to 1.4.0-beta1-62016-01 (#21557)

Perform synthesis of closure methods in an early pass before visitation,
meaning we no longer need to do a second visitation of the tree to lower
local functions.

The baselines have been changed because we now do closure id and
synthessis in order of closure visitation, rather than bound node
visitation. Closure visitation visits all the closures in a given scope,
then recurs into nested scopes, while BoundNode visitation treats
closures as scopes themselves, so nested closures are visited before
closures declared in the same scope.

Fixes https://github.com/dotnet/roslyn/projects/26#card-3753331

Merge dev15.4.x to master

Use default tuple fields in conversion since fields from inferred names are marked not usable in C#7

Do a better job with leading trivia on types when moving types to a new file.

Adds feature that helps convert keywords and symbols in doc comments to the appropriate tags.

#1. made persisted storage exclusive to 1 process. like before, second VS with same solution will not use persisted storage.
#2, tweaked sqlite to share cache between connections like esent.
#3, made VS and OOP to use different db files (we can make them to share if we want to, but for now, nobody requires it so we create 2 different db)

..

made OOP mock to enable persisted service.

Improve find-refs behavior when the user invokes it with a symbol selected

Fix regression in VB attribute classification.

In the introduction of the new 'this' optimization routine,
one of the things which was changed was to treat 'this' more
like a formal parameter of the method, as opposed to a variable
living in an implicit, higher scope. This has some advantages
in simplicity for analysis, but created a problem when it came
to proxies. The current analysis builds the proxy list by walking
the tree and finding all captured variables and adding them
to the proxy dictionary keyed by the original variable symbol.
For instance, if a local variable is captured to a field, during
rewriting it will be added to the proxy list as (original symbol,
hoisted field). Since most symbols are only ever captured to a
single replacement field, this usually works fine -- all proxies
can exist side-by-side in the proxy list since there is no intersection.

However, this is not true for captured environment pointers. When
a new environment is introduced, a local will be created to point
to that environment. That local may itself be captured by nested
variables, creating a linked list from nested scopes to parent scope.
Most notably, *multiple* nested environments may capture the *same*
environment pointer in *different* hoisted fields. This means that
the proxies dictionary cannot hold all mappings at once, since the
mapping for a given captured environment pointer will depend on the
current scope.

The current code actually accounts for this already by adding a
captured environment pointer to the proxy list on a nested scope's
introduction, and removing it upon leaving that scope.

By changing 'this' to be treated like a formal parameter, I
circumvented this logic, introducing a bug. When two scopes tried
to capture the 'this' pointer, the compiler crashed due to trying
to add two mappings to the same key.

This change fixes this problem by treating the 'this' parameter
like an environment pointer for the purposes of capturing and
hoisting. It's possible that we want to treat it like a formal
parameter, but if so it's probably better to treat all captured
environment pointers the same way and introduce a scope-aware
notion of proxies, rather than having a global dictionary.

Fixes #21506

Refactor comments in local function binder

Move to GitLink 3.0.0