- 09 10月, 2018 1 次提交
-
-
由 Manish Vasani 提交于
-
- 29 9月, 2018 1 次提交
-
-
由 Manish Vasani 提交于
Also fix the IDE helper to get value usage info, which fixes the MakeFieldReadOnlyAnalyzer Fixes #29373 Fixes #30175
-
- 29 8月, 2018 1 次提交
-
-
由 Manish Vasani 提交于
-
- 28 8月, 2018 1 次提交
-
-
由 Manish Vasani 提交于
1. Break the analyzer into two separate diagnostics for flagging unused and unread members. Latter rule has no code fix. 2. Remove all UI option elements for the added diagnostics and turn the rules off by default for now. 3. Bail out for invalid operations and syntax errors. 4. Handle doc comments and nameof - report unread member diagostics instead of unused member diagnostics if referenced in non-read/write context.
-
- 25 8月, 2018 2 次提交
-
-
由 Manish Vasani 提交于
-
由 Manish Vasani 提交于
Analyzer flags two cases: members with no read/writes and members with only writes. 1. Members with no read or writes: `Type '{0}' has an unused private member '{1}' which can be removed.` 2. Only writes: `Type '{0}' has a private member '{1}' which can be removed as the value assigned to it is never used.` Code fix removes the unused member declaration. Fixes #24225 Open questions: 1. Current analyzer design uses a single code style option for all members and both the above kinds of unused members. We can potentially have multiple options, but this should probably be done based on feedback. 2. Should the analyzer use different diagnostic IDs for the above two kinds of unused members? This will mean that the FixAll experience will need multiple iterations for removing unused members. 3. Should we update the code fix (or have an additional code fix) that also updates the write references for the case (2) above? Or is it better to leave the references to break the code so the user can analyze if the value being assigned can also be removed. The PR current chooses the latter approach as it is more conservative and unlikely to cause silent breaks.
-