1. 31 5月, 2019 1 次提交
    • M
      Add new analyzer API (DiagnosticSuppressor) to allow programmatic suppression... · f2f7a069
      Manish Vasani 提交于
      Add new analyzer API (DiagnosticSuppressor) to allow programmatic suppression of analyzer and/or compiler non-error diagnostics
      
      Fixes #20242 and #30172
      
      Detailed design proposal [here](https://gist.github.com/mavasani/fcac17a9581b5c54cef8a689eeec954a).
      
      Added public APIs with documentation comments:
      ```cs
      namespace Microsoft.CodeAnalysis.Diagnostics
      {
          /// <summary>
          /// The base type for diagnostic suppressors that can programmatically suppress analyzer and/or compiler non-error diagnostics.
          /// </summary>
          public abstract class DiagnosticSuppressor : DiagnosticAnalyzer
          {
              // Disallow suppressors from reporting diagnostics or registering analysis actions.
              public sealed override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics => ImmutableArray<DiagnosticDescriptor>.Empty;
      
              public sealed override void Initialize(AnalysisContext context) { }
      
              /// <summary>
              /// Returns a set of descriptors for the suppressions that this suppressor is capable of producing.
              /// </summary>
              public abstract ImmutableArray<SuppressionDescriptor> SupportedSuppressions { get; }
      
              /// <summary>
              /// Suppress analyzer and/or compiler non-error diagnostics reported for the compilation.
              /// This may be a subset of the full set of reported diagnostics, as an optimization for
              /// supporting incremental and partial analysis scenarios.
              /// A diagnostic is considered suppressible by a DiagnosticSuppressor if *all* of the following conditions are met:
              ///     1. Diagnostic is not already suppressed in source via pragma/suppress message attribute.
              ///     2. Diagnostic's <see cref="Diagnostic.DefaultSeverity"/> is not <see cref="DiagnosticSeverity.Error"/>.
              ///     3. Diagnostic is not tagged with <see cref="WellKnownDiagnosticTags.NotConfigurable"/> custom tag.
              /// </summary>
              public abstract void ReportSuppressions(SuppressionAnalysisContext context);
          }
      
          /// <summary>
          /// Provides a description about a programmatic suppression of a <see cref="Diagnostic"/> by a <see cref="DiagnosticSuppressor"/>.
          /// </summary>
          public sealed class SuppressionDescriptor : IEquatable<SuppressionDescriptor>
          {
              /// <summary>
              /// An unique identifier for the suppression.
              /// </summary>
              public string Id { get; }
      
              /// <summary>
              /// Identifier of the suppressed diagnostic, i.e. <see cref="Diagnostic.Id"/>.
              /// </summary>
              public string SuppressedDiagnosticId { get; }
      
              /// <summary>
              /// A localizable description about the suppression.
              /// </summary>
              public LocalizableString Description { get; }
          }
      
          /// <summary>
          /// Context for suppressing analyzer and/or compiler non-error diagnostics reported for the compilation.
          /// </summary>
          public struct SuppressionAnalysisContext
          {
              /// <summary>
              /// Suppressible analyzer and/or compiler non-error diagnostics reported for the compilation.
              /// This may be a subset of the full set of reported diagnostics, as an optimization for
              /// supporting incremental and partial analysis scenarios.
              /// A diagnostic is considered suppressible by a DiagnosticSuppressor if *all* of the following conditions are met:
              ///     1. Diagnostic is not already suppressed in source via pragma/suppress message attribute.
              ///     2. Diagnostic's <see cref="Diagnostic.DefaultSeverity"/> is not <see cref="DiagnosticSeverity.Error"/>.
              ///     3. Diagnostic is not tagged with <see cref="WellKnownDiagnosticTags.NotConfigurable"/> custom tag.
              /// </summary>
              public ImmutableArray<Diagnostic> ReportedDiagnostics { get; }
      
              /// <summary>
              /// Report a <see cref="Suppression"/> for a reported diagnostic.
              /// </summary>
              public void ReportSuppression(Suppression suppression);
      
              /// <summary>
              /// Gets a <see cref="SemanticModel"/> for the given <see cref="SyntaxTree"/>, which is shared across all analyzers.
              /// </summary>
              public SemanticModel GetSemanticModel(SyntaxTree syntaxTree);
      
              /// <summary>
              /// <see cref="CodeAnalysis.Compilation"/> for the context.
              /// </summary>
              public Compilation Compilation { get; }
      
              /// <summary>
              /// Options specified for the analysis.
              /// </summary>
              public AnalyzerOptions Options { get; }
      
              /// <summary>
              /// Token to check for requested cancellation of the analysis.
              /// </summary>
              public CancellationToken CancellationToken { get; }
          }
      
          /// <summary>
          /// Programmatic suppression of a <see cref="Diagnostic"/> by a <see cref="DiagnosticSuppressor"/>.
          /// </summary>
          public struct Suppression
          {
              /// <summary>
              /// Creates a suppression of a <see cref="Diagnostic"/> with the given <see cref="SuppressionDescriptor"/>.
              /// </summary>
              /// <param name="descriptor">
              /// Descriptor for the suppression, which must be from <see cref="DiagnosticSuppressor.SupportedSuppressions"/>
              /// for the <see cref="DiagnosticSuppressor"/> creating this suppression.
              /// </param>
              /// <param name="suppressedDiagnostic">
              /// <see cref="Diagnostic"/> to be suppressed, which must be from <see cref="SuppressionAnalysisContext.ReportedDiagnostics"/>
              /// for the suppression context in which this suppression is being created.</param>
              public static Suppression Create(SuppressionDescriptor descriptor, Diagnostic suppressedDiagnostic);
      
              /// <summary>
              /// Descriptor for this suppression.
              /// </summary>
              public SuppressionDescriptor Descriptor { get; }
      
              /// <summary>
              /// Diagnostic suppressed by this suppression.
              /// </summary>
              public Diagnostic SuppressedDiagnostic { get; }
          }
      }
      ```
      
      For batch compilation, suppressors always run after all the analyzer diagnostics have been computed.
      For IDE partial/incremental analysis scenario, we may run the suppressors with partial diagnostics.
      Suppressed diagnostics from diagnostic suppressors are equivalent to source suppressed diagnostics: they show up in the error list with "Suppression State" column as "Suppressed" and are also output to errorlog as suppressed diagnostics.
      f2f7a069
  2. 17 4月, 2019 1 次提交
  3. 20 3月, 2019 1 次提交
    • A
      Do not skip emit if errors are suppressed (#34174) · fb51650c
      Andy Gocke 提交于
      In the command line compilation we try to discover when to stop the
      compilation stages based on if an error is produced. If the error was
      produced by /warnaserror, then suppressed, this should not be considered
      a compilation-halting error.
      
      Fixes #34101
      fb51650c
  4. 05 1月, 2019 5 次提交
  5. 10 12月, 2018 3 次提交
  6. 25 7月, 2018 1 次提交
    • A
      Add cache for GetTypeByMetadataName (#28778) · d84e0a04
      Andy Gocke 提交于
      This seems to be a popular call among analyzers, especially XUnit. It's a
      reasonable way to acquire a well-known analyzer type, but analyzers often
      don't save the resulting symbol. This causes significant CPU work to be done
      repeatedly as XUnit looks for the same symbol over and over, passing in the
      same type name each time.
      
      A very small, simple cache seems to solve the problem without requiring any
      changes on the XUnit side.
      d84e0a04
  7. 18 7月, 2018 1 次提交
  8. 12 6月, 2018 1 次提交
  9. 05 6月, 2018 1 次提交
  10. 01 6月, 2018 1 次提交
    • C
      Use new compiler symbol search helpers that are optimized for string names searches. (#26331) · 3a6f5821
      CyrusNajmabadi 提交于
      Followup to #26325 and #26330. This PR updates the IDE to forward certain helpers to these more efficient implementations.
      
      This helps things out by more quickly being able to determine if a type even contains a member with name, and thus whether or not it should even be hydrated into a symbol and have its members created. Previous we would have to do a linear scan on all the members in a type to determine this. Now this data is in a set which can be queried much more efficiently.
      3a6f5821
  11. 26 5月, 2018 1 次提交
  12. 11 5月, 2018 2 次提交
  13. 23 4月, 2018 3 次提交
  14. 06 4月, 2018 2 次提交
  15. 21 3月, 2018 1 次提交
  16. 08 3月, 2018 1 次提交
  17. 06 3月, 2018 1 次提交
  18. 02 3月, 2018 1 次提交
    • D
      Enable Arm64 targetting through workaround · e65a6c58
      David Wrighton 提交于
      - Update pe writer to not rely on updated System.Reflection.Metadata for arm64 support
        - Instead of using System.Reflection.Metadata support, write the PE as x64, and then
          modify it to have the correct machine.
      - Add support for determistic PE generation with Arm64 platform
        - ensure that the hash used for timedatestamp is based on the contents with the Arm64 pe flag set
      - Update resources to describe arm64 as a viable platform switch
      e65a6c58
  19. 21 2月, 2018 1 次提交
  20. 24 1月, 2018 1 次提交
  21. 05 12月, 2017 1 次提交
  22. 15 11月, 2017 1 次提交
  23. 14 11月, 2017 1 次提交
    • A
      Refactor CommonCompiler.RunCore (#23059) · 7dea5aae
      Andy Gocke 提交于
      RunCore previously had a mix of diagnostic reporting methods including
      lists of Diagnostics, lists of DiagnosticInfos, ConcurrentQueues of
      Diagnostics, and just printing things directly to the console. This
      commit tries to simplify things by moving to using Diagnostics and
      DiagnosticBags wherever possible in the compile+emit phase of RunCore.
      7dea5aae
  24. 08 11月, 2017 1 次提交
  25. 18 10月, 2017 1 次提交
  26. 14 10月, 2017 1 次提交
  27. 28 9月, 2017 1 次提交
  28. 12 9月, 2017 1 次提交
  29. 06 9月, 2017 1 次提交
  30. 01 9月, 2017 1 次提交