- 01 6月, 2019 6 次提交
-
-
由 Manish Vasani 提交于
Additionally, we do not mark the package reference to in Features.csproj as PrivateAsset as this leads to the assembly not getting included in the Features NuGet package and causes Omnisharp's analyzer execution to throw missing dependency assembly load errors. Also update ExpectedDependency in DevDivInsertionFiles.csproj
-
由 Manish Vasani 提交于
-
由 Manish Vasani 提交于
-
由 Manish Vasani 提交于
Fix false positive inside catch clause (port of https://github.com/dotnet/roslyn-analyzers/pull/2501)
-
由 Manish Vasani 提交于
Address PR feedback: remove static cache, make FlowAnalysis utilities assembly load lazy and revert reference add to the FlowAnalysis assembly in Workspaces (only referenced in Features now).
-
由 Manish Vasani 提交于
(DisposableFieldsShouldBeDisposed) We will now flag disposable creations in methods that do not escape the method body (return value, out/ref params, assign to field/property, add to collection, etc.). Additionally, we also flag disposable fields of disposable types that are not disposed in the type's Dispose method. Ported analyzers share the core dataflow analysis computation with the analyzers in the roslyn-analyzers repo (Microsoft.CodeAnalysis.FlowAnalysis.Utilities). This PR does not add any code fixes. We already have a code refactoring that offers wrapping a disposable creation within a using statement. I am hoping to extend that to handle more cases and also possibly convert it to a code fix in follow-up PR(s).
-
- 28 5月, 2019 2 次提交
-
-
由 dotnet-automerge-bot 提交于
Merge release/dev16.2-preview1 to release/dev16.2-preview2
-
由 dotnet-automerge-bot 提交于
Merge release/dev16.1 to release/dev16.2-preview1
-
- 26 5月, 2019 1 次提交
-
-
由 Fred Silberberg 提交于
Ensure unimplemented interface members are reported even in presence …
-
- 25 5月, 2019 11 次提交
-
-
由 dotnet-automerge-bot 提交于
Merge release/dev16.2-preview1 to release/dev16.2-preview2
-
由 Chris Sienkiewicz 提交于
* Infer nested nullability for implicitly typed deconstruction variable: - When the left hand side is 'var', re-infer the type from the visited right hand side - Update and add tests
-
由 Joey Robichaud 提交于
Fix some bugs in the project system shims that impact ASP.NET Projects
-
由 Andrew Hall 提交于
-
由 dotnet-automerge-bot 提交于
Merge release/dev16.1 to release/dev16.2-preview1
-
由 Sam Harwell 提交于
Use 'x is object' instead of '!(x is null)' or 'x != null'
-
由 Rikki Gibson 提交于
-
由 Rikki Gibson 提交于
* Allow nullable variance for in/out params when converting method group to delegate * Fix diagnostic messages for mismatched out parameter nullable variance * Improve delegate in parameter variance tests * Add IdentityConversion_DelegateInParameter test
-
由 Jason Malinowski 提交于
When some web projects are created, ICSInputSet.SetOutputFileName is called with a non-absolute path. We should throw these away rather than set VisualStudioProject.IntermediateOutputFilePath since they're just placeholders and don't really mean anything.
-
由 Jason Malinowski 提交于
I totally forgot to do this, but in practice it was hard to observe because of https://github.com/dotnet/roslyn/issues/35372. That bug meant that a later project creation would end up re-running the subscription to the IVsSolution, which also checked the UIContext and that implicitly set _solutionLoaded. Once that bug was fixed this problem was now observable.
-
由 CyrusNajmabadi 提交于
* Property thread through cancellation through a bunch of our RPC services. * Tokens * Fix * Revert
-
- 24 5月, 2019 16 次提交
-
-
https://github.com/dotnet/arcade由 dotnet-maestro[bot] 提交于
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19272.13
-
由 David Poeschl 提交于
Add Generate Parameter Code Fix
-
由 Filip W 提交于
* include exception type in CommonObjectFormatter for scripting/interactive * fixed tests
-
由 Tomáš Matoušek 提交于
Two issues: 1) Replace AfterTargets="Build" with BeforeTargets="AfterBuild" Workaround for https://github.com/microsoft/msbuild/issues/3345 2) System.ValueTuple Seems like the System.ValueTuple package is missing lib/net472/_._, so lib/net47/System.ValueTuple.dll is identified as a runtime dependency although it is not.
-
由 Joey Robichaud 提交于
Get FullPath and deduplicate potential editorconfig files
-
由 AlekseyTs 提交于
Support re-abstraction of interface members in derived interfaces
-
由 Manish Vasani 提交于
Do not suggest converting from using-statement to using-local form if it would cause a variable collision.
-
由 Sam Harwell 提交于
Make importing constructors public to fix RS0034 (Exported parts should have ImportingConstructor)
-
由 Sam Harwell 提交于
Update SuggestedAction to track successful application
-
由 Cyrus Najmabadi 提交于
-
由 Joey Robichaud 提交于
Bump the 16.1 version for future servicing releases
-
由 Cyrus Najmabadi 提交于
-
由 Cyrus Najmabadi 提交于
-
由 Joey Robichaud 提交于
-
由 Manish Vasani 提交于
Add feature to convert switch statement to switch expression
-
由 Sam Harwell 提交于
Fixes #34165
-
- 23 5月, 2019 4 次提交
-
-
由 Sam Harwell 提交于
-
由 Ivan Basov 提交于
* Set non-blocking mode per textView * Update CompletionSource.cs * unit test for switching between blocking and non-blocking * can use the global option if switching it back and force
-
由 Yair Halberstadt 提交于
* Make methods overrides when pulling to base class with the make abstract option. Remove abstract methods when pulling to base class with the make abstract option. * Fix broken Unit tests * Simplify code to add override modifier based on Code Review * don't use generic ReplaceNode where not necessary in MembersPuller.PullMembersIntoClassAsync
-
由 Heejae Chang 提交于
* Revert "Revert "move StreamJsonRpc to 2.x from 1.3.x (#33960)" (#34654)" This reverts commit 297aaf20. * fix streamJsonRpc version conflict errors * move stream json rpc to more recent version and remove unnecessary explicit dependency * fix nuget version conflict issue * json rpc array bug workaround * move ToArray fix to lower layer * underlying issue is fixed in stream json rpc already and inserted to VS before we going in. removed workaround.
-