Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
lwm1986
roslyn
提交
fdb1a772
R
roslyn
项目概览
lwm1986
/
roslyn
与 Fork 源项目一致
从无法访问的项目Fork
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
DevOps
流水线
流水线任务
计划
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
roslyn
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
DevOps
DevOps
流水线
流水线任务
计划
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
流水线任务
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
fdb1a772
编写于
10月 11, 2016
作者:
O
Omar Tawfik
提交者:
GitHub
10月 11, 2016
浏览文件
操作
浏览文件
下载
差异文件
Merge pull request #14373 from OmarTawfik/fix-14287-const-tuple-deconstruction
Forbid modifiers on a deconstuction declaration
上级
af16b69e
e96f1258
变更
2
隐藏空白更改
内联
并排
Showing
2 changed file
with
54 addition
and
1 deletion
+54
-1
src/Compilers/CSharp/Portable/Binder/Binder_Deconstruct.cs
src/Compilers/CSharp/Portable/Binder/Binder_Deconstruct.cs
+13
-1
src/Compilers/CSharp/Test/Semantic/Semantics/DeconstructionTests.cs
...ers/CSharp/Test/Semantic/Semantics/DeconstructionTests.cs
+41
-0
未找到文件。
src/Compilers/CSharp/Portable/Binder/Binder_Deconstruct.cs
浏览文件 @
fdb1a772
...
...
@@ -608,7 +608,19 @@ private static void FlattenDeconstructVariables(ArrayBuilder<DeconstructionVaria
internal
BoundLocalDeconstructionDeclaration
BindDeconstructionDeclarationStatement
(
DeconstructionDeclarationStatementSyntax
node
,
DiagnosticBag
diagnostics
)
{
return
new
BoundLocalDeconstructionDeclaration
(
node
,
BindDeconstructionDeclaration
(
node
,
node
.
Assignment
.
VariableComponent
,
node
.
Assignment
.
Value
,
diagnostics
));
bool
modifierErrors
;
// No modifiers are allowed in deconstruction declarations
ModifierUtils
.
MakeAndCheckNontypeMemberModifiers
(
modifiers
:
node
.
Modifiers
,
defaultAccess
:
DeclarationModifiers
.
None
,
allowedModifiers
:
DeclarationModifiers
.
None
,
errorLocation
:
node
.
Assignment
.
VariableComponent
.
Location
,
diagnostics
:
diagnostics
,
modifierErrors
:
out
modifierErrors
);
var
assignment
=
BindDeconstructionDeclaration
(
node
,
node
.
Assignment
.
VariableComponent
,
node
.
Assignment
.
Value
,
diagnostics
);
return
new
BoundLocalDeconstructionDeclaration
(
node
,
assignment
,
hasErrors
:
modifierErrors
);
}
internal
BoundDeconstructionAssignmentOperator
BindDeconstructionDeclaration
(
CSharpSyntaxNode
node
,
VariableComponentSyntax
declaration
,
ExpressionSyntax
right
,
...
...
src/Compilers/CSharp/Test/Semantic/Semantics/DeconstructionTests.cs
浏览文件 @
fdb1a772
...
...
@@ -2546,5 +2546,46 @@ static void M((int, int) t)
}
}
[
Fact
,
WorkItem
(
14287
,
"https://github.com/dotnet/roslyn/issues/14287"
)]
public
void
TupleDeconstructionStatementWithTypesCannotBeConst
()
{
string
source
=
@"
class C
{
static void Main()
{
const (int x, int y) = (1, 2);
}
}
"
;
var
comp
=
CreateCompilationWithMscorlib
(
source
,
references
:
new
[]
{
ValueTupleRef
,
SystemRuntimeFacadeRef
});
comp
.
VerifyDiagnostics
(
// (6,15): error CS0106: The modifier 'const' is not valid for this item
// const (int x, int y) = (1, 2);
Diagnostic
(
ErrorCode
.
ERR_BadMemberFlag
,
"(int x, int y)"
).
WithArguments
(
"const"
).
WithLocation
(
6
,
15
)
);
}
[
Fact
,
WorkItem
(
14287
,
"https://github.com/dotnet/roslyn/issues/14287"
)]
public
void
TupleDeconstructionStatementWithoutTypesCannotBeConst
()
{
string
source
=
@"
class C
{
static void Main()
{
const var (x, y) = (1, 2);
}
}
"
;
var
comp
=
CreateCompilationWithMscorlib
(
source
,
references
:
new
[]
{
ValueTupleRef
,
SystemRuntimeFacadeRef
});
comp
.
VerifyDiagnostics
(
// (6,15): error CS0106: The modifier 'const' is not valid for this item
// const var (x, y) = (1, 2);
Diagnostic
(
ErrorCode
.
ERR_BadMemberFlag
,
"var (x, y)"
).
WithArguments
(
"const"
).
WithLocation
(
6
,
15
)
);
}
}
}
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录