Address PR feedback.

上级 d66596a2
......@@ -14,8 +14,8 @@ public DiscardSymbol(TypeSymbol type)
}
ITypeSymbol IDiscardSymbol.Type => Type;
Nullability IDiscardSymbol.Nullability => Nullability.NotComputed;
public TypeSymbol Type { get; }
public Nullability Nullability => Nullability.NotComputed;
/// <summary>
/// Produce a fresh discard symbol for testing.
......
......@@ -49,8 +49,6 @@ protected override sealed Symbol OriginalSymbolDefinition
/// </summary>
public abstract TypeSymbolWithAnnotations Type { get; }
public Nullability Nullability => Nullability.NotComputed;
/// <summary>
/// The 'add' accessor of the event. Null only in error scenarios.
/// </summary>
......@@ -343,6 +341,8 @@ ITypeSymbol IEventSymbol.Type
}
}
Nullability IEventSymbol.Nullability => Nullability.NotComputed;
IMethodSymbol IEventSymbol.AddMethod
{
get
......
......@@ -58,8 +58,6 @@ public TypeSymbolWithAnnotations Type
internal abstract TypeSymbolWithAnnotations GetFieldType(ConsList<FieldSymbol> fieldsBeingBound);
public Nullability Nullability => Nullability.NotComputed;
/// <summary>
/// If this field serves as a backing variable for an automatically generated
/// property or a field-like event, returns that
......@@ -457,6 +455,8 @@ ITypeSymbol IFieldSymbol.Type
}
}
Nullability IFieldSymbol.Nullability => Nullability.NotComputed;
ImmutableArray<CustomModifier> IFieldSymbol.CustomModifiers
{
get { return this.Type.CustomModifiers; }
......
......@@ -54,8 +54,6 @@ protected LocalSymbol()
get;
}
public Nullability Nullability => Nullability.NotComputed;
/// <summary>
/// WARN WARN WARN: If you access this via the semantic model, things will break (since the initializer may not have been bound).
///
......@@ -369,6 +367,8 @@ ITypeSymbol ILocalSymbol.Type
}
}
Nullability ILocalSymbol.Nullability => Nullability.NotComputed;
bool ILocalSymbol.IsFunctionValue
{
get
......
......@@ -204,8 +204,6 @@ public bool ReturnsByRefReadonly
/// </summary>
public abstract TypeSymbolWithAnnotations ReturnType { get; }
public Nullability ReturnNullability => Nullability.NotComputed;
/// <summary>
/// Returns the type arguments that have been substituted for the type parameters.
/// If nothing has been substituted for a given type parameter,
......@@ -213,8 +211,6 @@ public bool ReturnsByRefReadonly
/// </summary>
public abstract ImmutableArray<TypeSymbolWithAnnotations> TypeArguments { get; }
public ImmutableArray<Nullability> TypeArgumentsNullabilities => TypeArguments.SelectAsArray(_ => Nullability.NotComputed);
/// <summary>
/// Get the type parameters on this method. If the method has not generic,
/// returns an empty list.
......@@ -723,8 +719,6 @@ public virtual TypeSymbol ReceiverType
}
}
public Nullability ReceiverNullability => Nullability.NotComputed;
/// <summary>
/// If this method is a reduced extension method, returns a type inferred during reduction process for the type parameter.
/// </summary>
......@@ -1014,6 +1008,8 @@ ITypeSymbol IMethodSymbol.ReturnType
}
}
Nullability IMethodSymbol.ReturnNullability => Nullability.NotComputed;
ImmutableArray<ITypeSymbol> IMethodSymbol.TypeArguments
{
get
......@@ -1022,6 +1018,8 @@ ImmutableArray<ITypeSymbol> IMethodSymbol.TypeArguments
}
}
ImmutableArray<Nullability> IMethodSymbol.TypeArgumentsNullabilities => TypeArguments.SelectAsArray(_ => Nullability.NotComputed);
ImmutableArray<ITypeParameterSymbol> IMethodSymbol.TypeParameters
{
get
......@@ -1070,6 +1068,8 @@ ITypeSymbol IMethodSymbol.ReceiverType
}
}
Nullability IMethodSymbol.ReceiverNullability => Nullability.NotComputed;
IMethodSymbol IMethodSymbol.ReducedFrom
{
get
......
......@@ -49,8 +49,6 @@ protected override sealed Symbol OriginalSymbolDefinition
/// </summary>
public abstract TypeSymbolWithAnnotations Type { get; }
public Nullability Nullability => Nullability.NotComputed;
/// <summary>
/// Determines if the parameter ref, out or neither.
/// </summary>
......@@ -426,6 +424,8 @@ ITypeSymbol IParameterSymbol.Type
get { return this.Type.TypeSymbol; }
}
Nullability IParameterSymbol.Nullability => Nullability.NotComputed;
ImmutableArray<CustomModifier> IParameterSymbol.CustomModifiers
{
get { return this.Type.CustomModifiers; }
......
......@@ -722,7 +722,7 @@ ImmutableArray<ITypeSymbol> ITypeParameterSymbol.ConstraintTypes
}
}
ImmutableArray<Nullability> ITypeParameterSymbol.ConstraintsNullabilities
ImmutableArray<Nullability> ITypeParameterSymbol.ConstraintNullabilities
{
get => this.ConstraintTypesNoUseSiteDiagnostics.SelectAsArray(c => Nullability.NotComputed);
}
......
......@@ -10,7 +10,7 @@ Microsoft.CodeAnalysis.IMethodSymbol.ReturnNullability.get -> Microsoft.CodeAnal
Microsoft.CodeAnalysis.IMethodSymbol.TypeArgumentsNullabilities.get -> System.Collections.Immutable.ImmutableArray<Microsoft.CodeAnalysis.Nullability>
Microsoft.CodeAnalysis.INamedTypeSymbol.TypeArgumentsNullabilities.get -> System.Collections.Immutable.ImmutableArray<Microsoft.CodeAnalysis.Nullability>
Microsoft.CodeAnalysis.IParameterSymbol.Nullability.get -> Microsoft.CodeAnalysis.Nullability
Microsoft.CodeAnalysis.ITypeParameterSymbol.ConstraintsNullabilities.get -> System.Collections.Immutable.ImmutableArray<Microsoft.CodeAnalysis.Nullability>
Microsoft.CodeAnalysis.ITypeParameterSymbol.ConstraintNullabilities.get -> System.Collections.Immutable.ImmutableArray<Microsoft.CodeAnalysis.Nullability>
Microsoft.CodeAnalysis.ITypeParameterSymbol.ReferenceTypeConstraintNullability.get -> Microsoft.CodeAnalysis.Nullability
Microsoft.CodeAnalysis.ITypeSymbol.IsRefLikeType.get -> bool
Microsoft.CodeAnalysis.ITypeSymbol.ToDisplayParts(Microsoft.CodeAnalysis.Nullability topLevelNullability, Microsoft.CodeAnalysis.SymbolDisplayFormat format = null) -> System.Collections.Immutable.ImmutableArray<Microsoft.CodeAnalysis.SymbolDisplayPart>
......
......@@ -68,7 +68,7 @@ public interface ITypeParameterSymbol : ITypeSymbol
ImmutableArray<ITypeSymbol> ConstraintTypes { get; }
// PROTOTYPE(nullable-api): Document
ImmutableArray<Nullability> ConstraintsNullabilities { get; }
ImmutableArray<Nullability> ConstraintNullabilities { get; }
/// <summary>
/// Get the original definition of this type symbol. If this symbol is derived from another
......
......@@ -385,7 +385,7 @@ Namespace Microsoft.CodeAnalysis.VisualBasic.Symbols
End Get
End Property
Private ReadOnly Property ITypeParameterSymbol_ConstraintsNullabilities As ImmutableArray(Of Nullability) Implements ITypeParameterSymbol.ConstraintsNullabilities
Private ReadOnly Property ITypeParameterSymbol_ConstraintsNullabilities As ImmutableArray(Of Nullability) Implements ITypeParameterSymbol.ConstraintNullabilities
Get
Return Me.ConstraintTypesNoUseSiteDiagnostics.SelectAsArray(Function(t) Nullability.NotComputed)
End Get
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册