Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
lwm1986
roslyn
提交
f9f6143d
R
roslyn
项目概览
lwm1986
/
roslyn
与 Fork 源项目一致
从无法访问的项目Fork
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
DevOps
流水线
流水线任务
计划
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
roslyn
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
DevOps
DevOps
流水线
流水线任务
计划
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
流水线任务
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
f9f6143d
编写于
11月 06, 2018
作者:
M
Manish Vasani
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Unused members analyzer: Do not flag write-only properties that are not read
Fixes #30894
上级
443784e3
变更
2
隐藏空白更改
内联
并排
Showing
2 changed file
with
34 addition
and
0 deletion
+34
-0
src/EditorFeatures/CSharpTest/RemoveUnusedMembers/RemoveUnusedMembersTests.cs
...SharpTest/RemoveUnusedMembers/RemoveUnusedMembersTests.cs
+26
-0
src/Features/Core/Portable/RemoveUnusedMembers/AbstractRemoveUnusedMembersDiagnosticAnalyzer.cs
...dMembers/AbstractRemoveUnusedMembersDiagnosticAnalyzer.cs
+8
-0
未找到文件。
src/EditorFeatures/CSharpTest/RemoveUnusedMembers/RemoveUnusedMembersTests.cs
浏览文件 @
f9f6143d
...
...
@@ -477,6 +477,32 @@ class C : I
}"
);
}
[
Fact
,
Trait
(
Traits
.
Feature
,
Traits
.
Features
.
CodeActionsRemoveUnusedMembers
)]
[
WorkItem
(
30894
,
"https://github.com/dotnet/roslyn/issues/30894"
)]
public
async
Task
WriteOnlyProperty_NotWritten
()
{
await
TestInRegularAndScriptAsync
(
@"class C
{
int [|P|] { set { } }
}"
,
@"class C
{
}"
);
}
[
Fact
,
Trait
(
Traits
.
Feature
,
Traits
.
Features
.
CodeActionsRemoveUnusedMembers
)]
[
WorkItem
(
30894
,
"https://github.com/dotnet/roslyn/issues/30894"
)]
public
async
Task
WriteOnlyProperty_Written
()
{
await
TestDiagnosticMissingAsync
(
@"class C
{
int [|P|] { set { } }
void M(int i) => P = i;
}"
);
}
[
Fact
,
Trait
(
Traits
.
Feature
,
Traits
.
Features
.
CodeActionsRemoveUnusedMembers
)]
public
async
Task
FieldIsUnused_Const
()
{
...
...
src/Features/Core/Portable/RemoveUnusedMembers/AbstractRemoveUnusedMembersDiagnosticAnalyzer.cs
浏览文件 @
f9f6143d
...
...
@@ -303,6 +303,14 @@ private void OnSymbolEnd(SymbolAnalysisContext symbolEndContext, bool hasInvalid
?
s_removeUnusedMembersRule
:
s_removeUnreadMembersRule
;
// Do not flag write-only properties that are not read.
if
(
rule
==
s_removeUnreadMembersRule
&&
member
is
IPropertySymbol
property
&&
property
.
IsWriteOnly
)
{
continue
;
}
// Most of the members should have a single location, except for partial methods.
// We report the diagnostic on the first location of the member.
var
diagnostic
=
Diagnostic
.
Create
(
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录