Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
lwm1986
roslyn
提交
f9756dd4
R
roslyn
项目概览
lwm1986
/
roslyn
与 Fork 源项目一致
从无法访问的项目Fork
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
DevOps
流水线
流水线任务
计划
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
roslyn
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
DevOps
DevOps
流水线
流水线任务
计划
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
流水线任务
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
f9756dd4
编写于
6月 04, 2020
作者:
J
Jason Malinowski
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Clarify comment around behavior in Dispose() and why it's not taking locks
上级
0bb2853d
变更
1
隐藏空白更改
内联
并排
Showing
1 changed file
with
9 addition
and
3 deletion
+9
-3
src/VisualStudio/Core/Def/Implementation/ProjectSystem/FileChangeWatcher.cs
...ore/Def/Implementation/ProjectSystem/FileChangeWatcher.cs
+9
-3
未找到文件。
src/VisualStudio/Core/Def/Implementation/ProjectSystem/FileChangeWatcher.cs
浏览文件 @
f9756dd4
...
...
@@ -217,14 +217,20 @@ public void Dispose()
_fileChangeWatcher
.
EnqueueWork
(
async
service
=>
{
// Since we put all of our work in a queue, we know that if we had tried to advise file or directory changes,
// it must have happened before now
// This cleanup code all runs in the single queue that we push usages of the file change service into.
// Therefore, we know that any advise operations we had done have ran in that queue by now. Since this is also
// running after dispose, we don't need to take any locks at this point, since we're taking the general policy
// that any use of the type after it's been disposed is simply undefined behavior.
// We don't use IAsyncDisposable here simply because we don't ever want to block on the queue if we're
// able to avoid it, since that would potentially cause a stall or UI delay on shutting down.
foreach
(
var
cookie
in
_directoryWatchCookies
)
{
await
service
.
UnadviseDirChangeAsync
(
cookie
).
ConfigureAwait
(
false
);
}
// Since this runs after dispos
ed. so
no lock is needed for _activeFileWatchingTokens
// Since this runs after dispos
al,
no lock is needed for _activeFileWatchingTokens
foreach
(
var
token
in
_activeFileWatchingTokens
)
{
await
UnsubscribeFileChangeEventsAsync
(
service
,
token
).
ConfigureAwait
(
false
);
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录