Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
lwm1986
roslyn
提交
f33fb4bf
R
roslyn
项目概览
lwm1986
/
roslyn
与 Fork 源项目一致
从无法访问的项目Fork
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
DevOps
流水线
流水线任务
计划
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
roslyn
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
DevOps
DevOps
流水线
流水线任务
计划
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
流水线任务
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
未验证
提交
f33fb4bf
编写于
1月 29, 2019
作者:
M
Manish Vasani
提交者:
GitHub
1月 29, 2019
浏览文件
操作
浏览文件
下载
差异文件
Merge pull request #32895 from mavasani/Issue32855
Bail out for ref locals for unused value assignment analyzer
上级
7a333f52
f6f22435
变更
3
隐藏空白更改
内联
并排
Showing
3 changed file
with
48 addition
and
0 deletion
+48
-0
src/EditorFeatures/CSharpTest/RemoveUnusedParametersAndValues/RemoveUnusedValueAssignmentTests.cs
...edParametersAndValues/RemoveUnusedValueAssignmentTests.cs
+39
-0
src/Features/Core/Portable/RemoveUnusedParametersAndValues/AbstractRemoveUnusedParametersAndValuesDiagnosticAnalyzer.SymbolStartAnalyzer.BlockAnalyzer.cs
...esDiagnosticAnalyzer.SymbolStartAnalyzer.BlockAnalyzer.cs
+2
-0
src/Workspaces/Core/Portable/FlowAnalysis/SymbolUsageAnalysis/SymbolUsageAnalysis.Walker.cs
...nalysis/SymbolUsageAnalysis/SymbolUsageAnalysis.Walker.cs
+7
-0
未找到文件。
src/EditorFeatures/CSharpTest/RemoveUnusedParametersAndValues/RemoveUnusedValueAssignmentTests.cs
浏览文件 @
f33fb4bf
...
...
@@ -6040,6 +6040,45 @@ int M()
#endif
return x;
}
}"
,
optionName
);
}
[
WorkItem
(
32855
,
"https://github.com/dotnet/roslyn/issues/32855"
)]
[
Theory
,
Trait
(
Traits
.
Feature
,
Traits
.
Features
.
CodeActionsRemoveUnusedValues
)]
[
InlineData
(
nameof
(
PreferDiscard
))]
[
InlineData
(
nameof
(
PreferUnusedLocal
))]
public
async
Task
RefLocalInitialization
(
string
optionName
)
{
await
TestMissingInRegularAndScriptAsync
(
@"class Test
{
int[] data = { 0 };
void Method()
{
ref int [|target|] = ref data[0];
target = 1;
}
}"
,
optionName
);
}
[
WorkItem
(
32855
,
"https://github.com/dotnet/roslyn/issues/32855"
)]
[
Theory
,
Trait
(
Traits
.
Feature
,
Traits
.
Features
.
CodeActionsRemoveUnusedValues
)]
[
InlineData
(
nameof
(
PreferDiscard
))]
[
InlineData
(
nameof
(
PreferUnusedLocal
))]
public
async
Task
RefLocalAssignment
(
string
optionName
)
{
await
TestMissingInRegularAndScriptAsync
(
@"class Test
{
int[] data = { 0 };
int Method()
{
ref int target = ref data[0];
[|target|] = 1;
return data[0];
}
}"
,
optionName
);
}
}
...
...
src/Features/Core/Portable/RemoveUnusedParametersAndValues/AbstractRemoveUnusedParametersAndValuesDiagnosticAnalyzer.SymbolStartAnalyzer.BlockAnalyzer.cs
浏览文件 @
f33fb4bf
...
...
@@ -412,6 +412,8 @@ private void AnalyzeOperationBlockEnd(OperationBlockAnalysisContext context)
SymbolUsageResult
resultFromFlowAnalysis
,
out
ImmutableDictionary
<
string
,
string
>
properties
)
{
Debug
.
Assert
(!(
symbol
is
ILocalSymbol
local
)
||
!
local
.
IsRef
);
properties
=
null
;
// Bail out in following cases:
...
...
src/Workspaces/Core/Portable/FlowAnalysis/SymbolUsageAnalysis/SymbolUsageAnalysis.Walker.cs
浏览文件 @
f33fb4bf
...
...
@@ -216,6 +216,13 @@ public override void VisitDeconstructionAssignment(IDeconstructionAssignmentOper
public
override
void
VisitLocalReference
(
ILocalReferenceOperation
operation
)
{
if
(
operation
.
Local
.
IsRef
)
{
// Bail out for ref locals.
// We need points to analysis for analyzing writes to ref locals, which is currently not supported.
return
;
}
OnReferenceFound
(
operation
.
Local
,
operation
);
}
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录