Permit tests that fail certain assertions to run in !DEBUG (#31781)

* Permit tests that fail certain assertions to run in Release builds
See #25702 for details.

src/Compilers/CSharp/Test/Emit/CodeGen/GotoTest.cs

@@ -849,7 +849,7 @@ public void IntoScriptBlock()
                 Diagnostic(ErrorCode.WRN_UnreferencedLabel, "L1").WithLocation(6, 5));
         }
 
-        [Fact(Skip = "https://github.com/dotnet/roslyn/issues/25702")]
+        [ConditionalFact(typeof(IsRelease), Reason = "https://github.com/dotnet/roslyn/issues/25702")]
         public void AcrossScriptDeclarations()
         {
             string source =

src/Compilers/CSharp/Test/Semantic/Semantics/OutVarTests.cs

@@ -28400,7 +28400,7 @@ public static bool TakeOutParam<T>(T y, out T x)
             }
         }
 
-        [Fact(Skip = "https://github.com/dotnet/roslyn/issues/25702")]
+        [ConditionalFact(typeof(IsRelease), Reason = "https://github.com/dotnet/roslyn/issues/25702")]
         public void GlobalCode_LabeledStatement_06()
         {
             string source =

src/Compilers/CSharp/Test/Semantic/Semantics/PatternMatchingTests_Global.cs

@@ -3515,7 +3515,7 @@ class H
             }
         }
 
-        [Fact(Skip = "https://github.com/dotnet/roslyn/issues/25702")]
+        [ConditionalFact(typeof(IsRelease), Reason = "https://github.com/dotnet/roslyn/issues/25702")]
         public void GlobalCode_LabeledStatement_06()
         {
             string source =

src/ExpressionEvaluator/CSharp/Test/ExpressionCompiler/DeclarationTests.cs

@@ -15,7 +15,7 @@ namespace Microsoft.CodeAnalysis.CSharp.ExpressionEvaluator.UnitTests
 {
     public class DeclarationTests : ExpressionCompilerTestBase
     {
-        [Fact(Skip = "https://github.com/dotnet/roslyn/issues/25702")]
+        [ConditionalFact(typeof(IsRelease), Reason = "https://github.com/dotnet/roslyn/issues/25702")]
         public void Declarations()
         {
             var source =
@@ -78,7 +78,7 @@ .maxstack  4
             });
         }
 
-        [Fact(Skip = "https://github.com/dotnet/roslyn/issues/25702")]
+        [ConditionalFact(typeof(IsRelease), Reason = "https://github.com/dotnet/roslyn/issues/25702")]
         public void DeconstructionDeclaration()
         {
             var source = @"
@@ -155,7 +155,7 @@ .locals init (System.Guid V_0)
                });
         }
 
-        [Fact(Skip = "https://github.com/dotnet/roslyn/issues/25702")]
+        [ConditionalFact(typeof(IsRelease), Reason = "https://github.com/dotnet/roslyn/issues/25702")]
         public void DeconstructionDeclarationWithDiscard()
         {
             var source = @"
@@ -221,7 +221,7 @@ .locals init (System.Guid V_0)
                });
         }
 
-        [Fact(Skip = "https://github.com/dotnet/roslyn/issues/25702")]
+        [ConditionalFact(typeof(IsRelease), Reason = "https://github.com/dotnet/roslyn/issues/25702")]
         public void ExpressionLocals_ExpressionStatement_01()
         {
             var source =
@@ -344,7 +344,7 @@ .maxstack  4
             });
         }
 
-        [Fact(Skip = "https://github.com/dotnet/roslyn/issues/25702")]
+        [ConditionalFact(typeof(IsRelease), Reason = "https://github.com/dotnet/roslyn/issues/25702")]
         public void ExpressionLocals_Assignment_01()
         {
             var source =
@@ -401,7 +401,7 @@ .maxstack  4
             });
         }
 
-        [Fact(Skip = "https://github.com/dotnet/roslyn/issues/25702")]
+        [ConditionalFact(typeof(IsRelease), Reason = "https://github.com/dotnet/roslyn/issues/25702")]
         public void ExpressionLocals_LocalDeclarationStatement_01()
         {
             var source =
@@ -469,7 +469,7 @@ .maxstack  4
             });
         }
 
-        [Fact(Skip = "https://github.com/dotnet/roslyn/issues/25702")]
+        [ConditionalFact(typeof(IsRelease), Reason = "https://github.com/dotnet/roslyn/issues/25702")]
         public void References()
         {
             var source =
@@ -544,7 +544,7 @@ .maxstack  2
             });
         }
 
-        [Fact(Skip = "https://github.com/dotnet/roslyn/issues/25702")]
+        [ConditionalFact(typeof(IsRelease), Reason = "https://github.com/dotnet/roslyn/issues/25702")]
         public void Address()
         {
             var source =
@@ -649,7 +649,7 @@ static void M(object x)
             });
         }
 
-        [Fact(Skip = "https://github.com/dotnet/roslyn/issues/25702")]
+        [ConditionalFact(typeof(IsRelease), Reason = "https://github.com/dotnet/roslyn/issues/25702")]
         public void BaseType()
         {
             var source =
@@ -697,7 +697,7 @@ .locals init (System.Guid V_0)
             });
         }
 
-        [Fact(Skip = "https://github.com/dotnet/roslyn/issues/25702")]
+        [ConditionalFact(typeof(IsRelease), Reason = "https://github.com/dotnet/roslyn/issues/25702")]
         public void Var()
         {
             var source =
@@ -739,8 +739,8 @@ .locals init (System.Guid V_0)
             });
         }
 
+        [ConditionalFact(typeof(IsRelease), Reason = "https://github.com/dotnet/roslyn/issues/25702")]
         [WorkItem(1087216, "http://vstfdevdiv:8080/DevDiv2/DevDiv/_workitems/edit/1087216")]
-        [Fact(Skip = "https://github.com/dotnet/roslyn/issues/25702")]
         public void Dynamic()
         {
             var source =
@@ -891,7 +891,7 @@ static void M()
             });
         }
 
-        [Fact(Skip = "https://github.com/dotnet/roslyn/issues/25702")]
+        [ConditionalFact(typeof(IsRelease), Reason = "https://github.com/dotnet/roslyn/issues/25702")]
         public void ReferenceInNextDeclaration()
         {
             var source =
@@ -952,8 +952,8 @@ .maxstack  4
             });
         }
 
+        [ConditionalFact(typeof(IsRelease), Reason = "https://github.com/dotnet/roslyn/issues/25702")]
         [WorkItem(1094107, "http://vstfdevdiv:8080/DevDiv2/DevDiv/_workitems/edit/1094107")]
-        [Fact(Skip = "https://github.com/dotnet/roslyn/issues/25702")]
         public void ReferenceInSameDeclaration()
         {
             var source =
@@ -1163,7 +1163,7 @@ static void M()
             });
         }
 
-        [Fact(Skip = "https://github.com/dotnet/roslyn/issues/25702")]
+        [ConditionalFact(typeof(IsRelease), Reason = "https://github.com/dotnet/roslyn/issues/25702")]
         public void Keyword()
         {
             var source =
@@ -1217,7 +1217,7 @@ .locals init (System.Guid V_0)
             });
         }
 
-        [Fact(Skip = "https://github.com/dotnet/roslyn/issues/25702")]
+        [ConditionalFact(typeof(IsRelease), Reason = "https://github.com/dotnet/roslyn/issues/25702")]
         public void Constant()
         {
             var source =
@@ -1263,7 +1263,7 @@ .locals init (System.Guid V_0)
             });
         }
 
-        [Fact(Skip = "https://github.com/dotnet/roslyn/issues/25702")]
+        [ConditionalFact(typeof(IsRelease), Reason = "https://github.com/dotnet/roslyn/issues/25702")]
         public void Generic()
         {
             var source =
@@ -1365,7 +1365,7 @@ static void M()
         /// Local declarations inside a lambda should
         /// not be considered pseudo-variables.
         /// </summary>
-        [Fact(Skip = "https://github.com/dotnet/roslyn/issues/25702")]
+        [ConditionalFact(typeof(IsRelease), Reason = "https://github.com/dotnet/roslyn/issues/25702")]
         public void Lambda()
         {
             var source =
@@ -1442,8 +1442,8 @@ static void M()
             });
         }
 
+        [ConditionalFact(typeof(IsRelease), Reason = "https://github.com/dotnet/roslyn/issues/25702")]
         [WorkItem(3822, "https://github.com/dotnet/roslyn/issues/3822")]
-        [Fact(Skip = "https://github.com/dotnet/roslyn/issues/25702")]
         public void GenericType_Identifier()
         {
             var source = @"
@@ -1488,8 +1488,8 @@ .locals init (System.Guid V_0)
             });
         }
 
+        [ConditionalFact(typeof(IsRelease), Reason = "https://github.com/dotnet/roslyn/issues/25702")]
         [WorkItem(3822, "https://github.com/dotnet/roslyn/issues/3822")]
-        [Fact(Skip = "https://github.com/dotnet/roslyn/issues/25702")]
         public void GenericType_Keyword()
         {
             var source = @"
@@ -1534,8 +1534,8 @@ .locals init (System.Guid V_0)
             });
         }
 
+        [ConditionalFact(typeof(IsRelease), Reason = "https://github.com/dotnet/roslyn/issues/25702")]
         [WorkItem(3822, "https://github.com/dotnet/roslyn/issues/3822")]
-        [Fact(Skip = "https://github.com/dotnet/roslyn/issues/25702")]
         public void PointerType_Identifier()
         {
             var source = @"
@@ -1581,8 +1581,8 @@ .locals init (System.Guid V_0)
             });
         }
 
+        [ConditionalFact(typeof(IsRelease), Reason = "https://github.com/dotnet/roslyn/issues/25702")]
         [WorkItem(3822, "https://github.com/dotnet/roslyn/issues/3822")]
-        [Fact(Skip = "https://github.com/dotnet/roslyn/issues/25702")]
         public void PointerType_Keyword()
         {
             var source = @"
@@ -1624,8 +1624,8 @@ .locals init (System.Guid V_0)
             });
         }
 
+        [ConditionalFact(typeof(IsRelease), Reason = "https://github.com/dotnet/roslyn/issues/25702")]
         [WorkItem(3822, "https://github.com/dotnet/roslyn/issues/3822")]
-        [Fact(Skip = "https://github.com/dotnet/roslyn/issues/25702")]
         public void NullableType_Identifier()
         {
             var source = @"
@@ -1673,8 +1673,8 @@ .maxstack  4
             });
         }
 
+        [ConditionalFact(typeof(IsRelease), Reason = "https://github.com/dotnet/roslyn/issues/25702")]
         [WorkItem(3822, "https://github.com/dotnet/roslyn/issues/3822")]
-        [Fact(Skip = "https://github.com/dotnet/roslyn/issues/25702")]
         public void NullableType_Keyword()
         {
             var source = @"

src/ExpressionEvaluator/CSharp/Test/ExpressionCompiler/DynamicTests.cs

@@ -744,8 +744,8 @@ .maxstack  1
             });
         }
 
+        [ConditionalFact(typeof(IsRelease), Reason = "https://github.com/dotnet/roslyn/issues/25702")]
         [WorkItem(1087216, "http://vstfdevdiv:8080/DevDiv2/DevDiv/_workitems/edit/1087216")]
-        [Fact(Skip = "https://github.com/dotnet/roslyn/issues/25702")]
         public void ComplexDynamicType()
         {
             var source =
@@ -840,7 +840,7 @@ .maxstack  6
             });
         }
 
-        [Fact(Skip = "https://github.com/dotnet/roslyn/issues/25702")]
+        [ConditionalFact(typeof(IsRelease), Reason = "https://github.com/dotnet/roslyn/issues/25702")]
         public void DynamicAliases()
         {
             var source =

src/ExpressionEvaluator/CSharp/Test/ExpressionCompiler/ExpressionCompilerTests.cs

@@ -6353,7 +6353,7 @@ .maxstack  3
             });
         }
 
-        [Fact(Skip = "https://github.com/dotnet/roslyn/issues/25702")]
+        [ConditionalFact(typeof(IsRelease), Reason = "https://github.com/dotnet/roslyn/issues/25702")]
         public void AssignDefaultToLocal()
         {
             var source = @"
@@ -6648,7 +6648,7 @@ static void Main()
             });
         }
 
-        [Fact(Skip = "https://github.com/dotnet/roslyn/issues/25702")]
+        [ConditionalFact(typeof(IsRelease), Reason = "https://github.com/dotnet/roslyn/issues/25702")]
         public void OutVarInExpression()
         {
             var source =

src/ExpressionEvaluator/CSharp/Test/ExpressionCompiler/LocalsTests.cs

@@ -750,7 +750,7 @@ .maxstack  2
             });
         }
 
-        [Fact(Skip = "https://github.com/dotnet/roslyn/issues/25702")]
+        [ConditionalFact(typeof(IsRelease), Reason = "https://github.com/dotnet/roslyn/issues/25702")]
         public void LocalsAndPseudoVariables()
         {
             var source =
@@ -4434,7 +4434,7 @@ public void LocalsInConstructorInitializer_02()
     C() 
     : base(TakeOutParam(1, out var x1))
     {
-#line 1000 
+#line 1000
         ;
     }     
 
@@ -4493,7 +4493,7 @@ public void LocalsInConstructorInitializer_03()
 {
     C() 
     : base(TakeOutParam(1, out var x1))
-#line 1000 
+#line 1000
     => System.Console.WriteLine();
 
     static bool TakeOutParam(int y, out int x) 
@@ -4553,7 +4553,7 @@ public void LocalsInConstructorInitializer_04()
     : base(TakeOutParam(1, out var x1))
     {
         int x2 = 1;
-#line 1000 
+#line 1000
         System.Console.WriteLine(x2);
     }     
 
@@ -4623,7 +4623,7 @@ public void LocalsInConstructorInitializer_05()
 {
     C() 
     : base(TakeOutParam(1, out var x1))
-#line 1000 
+#line 1000
     => System.Console.WriteLine(TakeOutParam(2, out var x2));
 
     static bool TakeOutParam(int y, out int x) 

src/ExpressionEvaluator/CSharp/Test/ExpressionCompiler/PseudoVariableTests.cs

@@ -271,7 +271,7 @@ static void M()
             });
         }
 
-        [Fact(Skip = "https://github.com/dotnet/roslyn/issues/25702")]
+        [ConditionalFact(typeof(IsRelease), Reason = "https://github.com/dotnet/roslyn/issues/25702")]
         public void ObjectId()
         {
             var source =
@@ -318,8 +318,8 @@ .maxstack  2
             });
         }
 
+        [ConditionalFact(typeof(IsRelease), Reason = "https://github.com/dotnet/roslyn/issues/25702")]
         [WorkItem(1101017, "http://vstfdevdiv:8080/DevDiv2/DevDiv/_workitems/edit/1101017")]
-        [Fact(Skip = "https://github.com/dotnet/roslyn/issues/25702")]
         public void NestedGenericValueType()
         {
             var source =
@@ -369,7 +369,7 @@ .maxstack  2
             });
         }
 
-        [Fact(Skip = "https://github.com/dotnet/roslyn/issues/25702")]
+        [ConditionalFact(typeof(IsRelease), Reason = "https://github.com/dotnet/roslyn/issues/25702")]
         public void ArrayType()
         {
             var source =
@@ -486,7 +486,7 @@ static void M()
             });
         }
 
-        [Fact(Skip = "https://github.com/dotnet/roslyn/issues/25702")]
+        [ConditionalFact(typeof(IsRelease), Reason = "https://github.com/dotnet/roslyn/issues/25702")]
         public void Variables()
         {
             var source =
@@ -676,8 +676,8 @@ static void M()
             });
         }
 
+        [ConditionalFact(typeof(IsRelease), Reason = "https://github.com/dotnet/roslyn/issues/25702")]
         [WorkItem(1100849, "http://vstfdevdiv:8080/DevDiv2/DevDiv/_workitems/edit/1100849")]
-        [Fact(Skip = "https://github.com/dotnet/roslyn/issues/25702")]
         public void PassByRef()
         {
             var source =
@@ -801,7 +801,7 @@ .locals init (T V_0)
             });
         }
 
-        [Fact(Skip = "https://github.com/dotnet/roslyn/issues/25702")]
+        [ConditionalFact(typeof(IsRelease), Reason = "https://github.com/dotnet/roslyn/issues/25702")]
         public void ValueType()
         {
             var source =
@@ -849,7 +849,7 @@ .locals init (object V_0)
             });
         }
 
-        [Fact(Skip = "https://github.com/dotnet/roslyn/issues/25702")]
+        [ConditionalFact(typeof(IsRelease), Reason = "https://github.com/dotnet/roslyn/issues/25702")]
         public void CompoundAssignment()
         {
             var source =
@@ -903,7 +903,7 @@ .locals init (int V_0)
         /// which may be different versions than the assembly references in metadata.
         /// </summary>
         [WorkItem(1087458, "http://vstfdevdiv:8080/DevDiv2/DevDiv/_workitems/edit/1087458")]
-        [Fact(Skip = "https://github.com/dotnet/roslyn/issues/25702")]
+        [ConditionalFact(typeof(IsRelease), Reason = "https://github.com/dotnet/roslyn/issues/25702")]
         public void DifferentAssemblyVersion()
         {
             var sourceA =
@@ -990,7 +990,7 @@ .maxstack  2
         /// outside of the current module and its references.
         /// </summary>
         [WorkItem(1092680, "http://vstfdevdiv:8080/DevDiv2/DevDiv/_workitems/edit/1092680")]
-        [Fact(Skip = "https://github.com/dotnet/roslyn/issues/25702")]
+        [ConditionalFact(typeof(IsRelease), Reason = "https://github.com/dotnet/roslyn/issues/25702")]
         public void TypeOutsideModule()
         {
             var sourceA =
@@ -1130,8 +1130,8 @@ .maxstack  1
             });
         }
 
+        [ConditionalFact(typeof(IsRelease), Reason = "https://github.com/dotnet/roslyn/issues/25702")]
         [WorkItem(1140387, "DevDiv")]
-        [Fact(Skip = "https://github.com/dotnet/roslyn/issues/25702")]
         public void UserVariableOfPointerType()
         {
             var source =

src/ExpressionEvaluator/CSharp/Test/ExpressionCompiler/ReferencedModulesTests.cs

@@ -1151,7 +1151,7 @@ .maxstack  1
         /// Intrinsic methods assembly should not be dropped.
         /// </summary>
         [WorkItem(4140, "https://github.com/dotnet/roslyn/issues/4140")]
-        [Fact(Skip = "https://github.com/dotnet/roslyn/issues/25702")]
+        [ConditionalFact(typeof(IsRelease), Reason = "https://github.com/dotnet/roslyn/issues/25702")]
         public void IntrinsicMethods()
         {
             var sourceA =

src/ExpressionEvaluator/CSharp/Test/ExpressionCompiler/ResultPropertiesTests.cs

@@ -321,7 +321,7 @@ void Test()
             });
         }
 
-        [Fact(Skip = "https://github.com/dotnet/roslyn/issues/25702")]
+        [ConditionalFact(typeof(IsRelease), Reason = "https://github.com/dotnet/roslyn/issues/25702")]
         public void LocalDeclaration()
         {
             var source = @"

src/ExpressionEvaluator/CSharp/Test/ExpressionCompiler/TupleTests.cs

@@ -353,7 +353,7 @@ .maxstack  2
             });
         }
 
-        [Fact(Skip = "https://github.com/dotnet/roslyn/issues/25702")]
+        [ConditionalFact(typeof(IsRelease), Reason = "https://github.com/dotnet/roslyn/issues/25702")]
         public void DeclareLocal()
         {
             var source =
@@ -418,8 +418,8 @@ .maxstack  6
             });
         }
 
+        [ConditionalFact(typeof(IsRelease), Reason = "https://github.com/dotnet/roslyn/issues/25702")]
         [WorkItem(13589, "https://github.com/dotnet/roslyn/issues/13589")]
-        [Fact(Skip = "https://github.com/dotnet/roslyn/issues/25702")]
         public void Alias()
         {
             var source =
@@ -483,8 +483,8 @@ .maxstack  1
             });
         }
 
+        [ConditionalFact(typeof(IsRelease), Reason = "https://github.com/dotnet/roslyn/issues/25702")]
         [WorkItem(13803, "https://github.com/dotnet/roslyn/issues/13803")]
-        [Fact(Skip = "https://github.com/dotnet/roslyn/issues/25702")]
         public void AliasElement_NoNames()
         {
             var source =

src/ExpressionEvaluator/CSharp/Test/ExpressionCompiler/WinMdTests.cs

@@ -242,8 +242,7 @@ .maxstack  1
         /// and referencing runtime assembly.
         /// </summary>
         [WorkItem(1116143, "http://vstfdevdiv:8080/DevDiv2/DevDiv/_workitems/edit/1116143")]
-        //[ConditionalFact(typeof(OSVersionWin8))]
-        [Fact(Skip = "https://github.com/dotnet/roslyn/issues/25702")] // should be ConditionalFact, above, when fixed
+        [ConditionalFact(typeof(OSVersionWin8), typeof(IsRelease))] // https://github.com/dotnet/roslyn/issues/25702
         public void AssemblyQualifiedName()
         {
             var source =