Merge pull request #5193 from CyrusNajmabadi/lowerCaseType

Don't offer 'Generate Type' on lowercase names in VB

src/EditorFeatures/VisualBasicTest/Diagnostics/GenerateType/GenerateTypeTests.vb

@@ -49,6 +49,12 @@ NewLines("Class C \n dim f as Foo \n End Class \n Friend Class Foo \n End Class"
 index:=1)
         End Sub
 
+        <Fact, Trait(Traits.Feature, Traits.Features.CodeActionsGenerateType)>
+        Public Sub TestMissingOnLowercaseName()
+            TestMissing(
+NewLines("Class C \n dim f as [|foo|] \n End Class"))
+        End Sub
+
         <WorkItem(539716)>
         <Fact, Trait(Traits.Feature, Traits.Features.CodeActionsGenerateType)>
         Public Sub TestGenerateClassFromFullyQualifiedFieldIntoSameNamespace()

src/Features/Core/Portable/GenerateType/AbstractGenerateTypeService.State.cs

@@ -111,6 +111,16 @@ private State(Compilation compilation)
                     return false;
                 }
 
+                if (char.IsLower(name[0]) && !document.SemanticModel.Compilation.IsCaseSensitive)
+                {
+                    // It's near universal in .Net that types start with a capital letter.  As such,
+                    // if this name starts with a lowercase letter, don't even bother to offer 
+                    // "generate type".  The user most likely wants to run 'Add Import' (which will
+                    // then fix up a case where they typed an existing type name in lowercase, 
+                    // intending the fix to case correct it).
+                    return false;
+                }
+
                 this.NameOrMemberAccessExpression = generateTypeServiceStateOptions.NameOrMemberAccessExpression;
                 this.ObjectCreationExpressionOpt = generateTypeServiceStateOptions.ObjectCreationExpressionOpt;