提交 ebc732e9 编写于 作者: C Cyrus Najmabadi

Don't make blocking calls to GetRoot

上级 e78b30dc
...@@ -290,14 +290,14 @@ Namespace Microsoft.CodeAnalysis.VisualBasic.CodeFixes.AddImport ...@@ -290,14 +290,14 @@ Namespace Microsoft.CodeAnalysis.VisualBasic.CodeFixes.AddImport
Return symbol IsNot Nothing AndAlso symbol.Locations.Length > 0 Return symbol IsNot Nothing AndAlso symbol.Locations.Length > 0
End Function End Function
Protected Overloads Overrides Function AddImportAsync( Protected Overloads Overrides Async Function AddImportAsync(
contextNode As SyntaxNode, contextNode As SyntaxNode,
symbol As INamespaceOrTypeSymbol, symbol As INamespaceOrTypeSymbol,
document As Document, document As Document,
placeSystemNamespaceFirst As Boolean, placeSystemNamespaceFirst As Boolean,
cancellationToken As CancellationToken) As Task(Of Document) cancellationToken As CancellationToken) As Task(Of Document)
Dim root = DirectCast(contextNode.SyntaxTree.GetRoot(cancellationToken), CompilationUnitSyntax) Dim root = DirectCast(Await contextNode.SyntaxTree.GetRootAsync(cancellationToken).ConfigureAwait(False), CompilationUnitSyntax)
Dim memberImportsClause = Dim memberImportsClause =
SyntaxFactory.SimpleImportsClause(name:=DirectCast(symbol.GenerateTypeSyntax(addGlobal:=False), NameSyntax).WithAdditionalAnnotations(Simplifier.Annotation)) SyntaxFactory.SimpleImportsClause(name:=DirectCast(symbol.GenerateTypeSyntax(addGlobal:=False), NameSyntax).WithAdditionalAnnotations(Simplifier.Annotation))
...@@ -305,10 +305,9 @@ Namespace Microsoft.CodeAnalysis.VisualBasic.CodeFixes.AddImport ...@@ -305,10 +305,9 @@ Namespace Microsoft.CodeAnalysis.VisualBasic.CodeFixes.AddImport
importsClauses:=SyntaxFactory.SingletonSeparatedList(Of ImportsClauseSyntax)(memberImportsClause)) importsClauses:=SyntaxFactory.SingletonSeparatedList(Of ImportsClauseSyntax)(memberImportsClause))
Dim syntaxTree = contextNode.SyntaxTree Dim syntaxTree = contextNode.SyntaxTree
Return Task.FromResult( Return document.WithSyntaxRoot(
document.WithSyntaxRoot(
root.AddImportsStatement(newImport, placeSystemNamespaceFirst, root.AddImportsStatement(newImport, placeSystemNamespaceFirst,
CaseCorrector.Annotation, Formatter.Annotation))) CaseCorrector.Annotation, Formatter.Annotation))
End Function End Function
Protected Overrides Function IsViableExtensionMethod(method As IMethodSymbol, Protected Overrides Function IsViableExtensionMethod(method As IMethodSymbol,
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册