Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
lwm1986
roslyn
提交
eb5197d4
R
roslyn
项目概览
lwm1986
/
roslyn
与 Fork 源项目一致
从无法访问的项目Fork
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
DevOps
流水线
流水线任务
计划
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
roslyn
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
DevOps
DevOps
流水线
流水线任务
计划
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
流水线任务
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
eb5197d4
编写于
6月 22, 2020
作者:
A
Allison Chou
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Remove unnecessary code
上级
8c773208
变更
1
隐藏空白更改
内联
并排
Showing
1 changed file
with
0 addition
and
83 deletion
+0
-83
src/Workspaces/SharedUtilitiesAndExtensions/Compiler/CSharp/Utilities/TypeStyle/CSharpUseImplicitTypeHelper.cs
...CSharp/Utilities/TypeStyle/CSharpUseImplicitTypeHelper.cs
+0
-83
未找到文件。
src/Workspaces/SharedUtilitiesAndExtensions/Compiler/CSharp/Utilities/TypeStyle/CSharpUseImplicitTypeHelper.cs
浏览文件 @
eb5197d4
...
@@ -15,7 +15,6 @@
...
@@ -15,7 +15,6 @@
using
Microsoft.CodeAnalysis.Shared.Utilities
;
using
Microsoft.CodeAnalysis.Shared.Utilities
;
using
Microsoft.CodeAnalysis.Simplification
;
using
Microsoft.CodeAnalysis.Simplification
;
using
Microsoft.CodeAnalysis.Operations
;
using
Microsoft.CodeAnalysis.Operations
;
using
Microsoft.CodeAnalysis.PooledObjects
;
#if CODE_STYLE
#if CODE_STYLE
using
OptionSet
=
Microsoft
.
CodeAnalysis
.
Diagnostics
.
AnalyzerConfigOptions
;
using
OptionSet
=
Microsoft
.
CodeAnalysis
.
Diagnostics
.
AnalyzerConfigOptions
;
...
@@ -294,11 +293,6 @@ private static bool IsSafeToSwitchToVarWithoutNeedingSpeculation(DeclarationExpr
...
@@ -294,11 +293,6 @@ private static bool IsSafeToSwitchToVarWithoutNeedingSpeculation(DeclarationExpr
return
false
;
return
false
;
}
}
if
(
IsSwitchExpressionAndCannotUseVar
(
typeName
,
initializer
,
semanticModel
))
{
return
false
;
}
// variables declared using var cannot be used further in the same initialization expression.
// variables declared using var cannot be used further in the same initialization expression.
if
(
initializer
.
DescendantNodesAndSelf
()
if
(
initializer
.
DescendantNodesAndSelf
()
.
Where
(
n
=>
n
is
IdentifierNameSyntax
id
&&
id
.
Identifier
.
ValueText
.
Equals
(
identifier
.
ValueText
))
.
Where
(
n
=>
n
is
IdentifierNameSyntax
id
&&
id
.
Identifier
.
ValueText
.
Equals
(
identifier
.
ValueText
))
...
@@ -357,82 +351,5 @@ protected override bool ShouldAnalyzeDeclarationExpression(DeclarationExpression
...
@@ -357,82 +351,5 @@ protected override bool ShouldAnalyzeDeclarationExpression(DeclarationExpression
// The base analyzer may impose further limitations
// The base analyzer may impose further limitations
return
base
.
ShouldAnalyzeDeclarationExpression
(
declaration
,
semanticModel
,
cancellationToken
);
return
base
.
ShouldAnalyzeDeclarationExpression
(
declaration
,
semanticModel
,
cancellationToken
);
}
}
private
static
bool
IsSwitchExpressionAndCannotUseVar
(
TypeSyntax
typeName
,
ExpressionSyntax
initializer
,
SemanticModel
semanticModel
)
{
if
(
initializer
.
IsKind
(
SyntaxKind
.
SwitchExpression
))
{
// We compare the variable declaration type to each arm's type to see if there is an exact match, or if the
// arm type inherits from the variable declaration type. We also must verify that the arm types are all
// in the same line of inheritance. If not, we must use the explicit type instead of var.
// Even if 'true' is returned from this method, it is not guaranteed that we can use var. Further checks should occur
// after this method is called, such as checking if multiple implicit coversions exist.
var
declarationType
=
semanticModel
.
GetTypeInfo
(
typeName
).
Type
;
var
noValidTypeExpressions
=
true
;
if
(
declarationType
!=
null
)
{
using
var
_
=
ArrayBuilder
<
ITypeSymbol
>.
GetInstance
(
out
var
seenTypes
);
foreach
(
var
arm
in
((
SwitchExpressionSyntax
)
initializer
).
Arms
)
{
var
expression
=
arm
.
Expression
;
if
(
expression
.
IsKind
(
SyntaxKind
.
ParenthesizedExpression
,
out
ParenthesizedExpressionSyntax
?
parenExpression
))
{
expression
=
parenExpression
.
WalkDownParentheses
();
}
if
(!
expression
.
IsKind
(
SyntaxKind
.
ThrowExpression
)
&&
!
expression
.
IsKind
(
SyntaxKind
.
NullLiteralExpression
)
&&
!
expression
.
IsKind
(
SyntaxKind
.
DefaultLiteralExpression
))
{
noValidTypeExpressions
=
false
;
var
expressionType
=
semanticModel
.
GetTypeInfo
(
expression
).
Type
;
if
(
expressionType
==
null
)
{
continue
;
}
if
(!
expressionType
.
InheritsFromOrEquals
(
declarationType
))
{
return
true
;
}
// All arms must be in the same direct line of inheritance.
// e.g. Given the tree:
// C
// / \
// A B
//
// Substituting 'var' for 'x' in the following switch expression will introduce a compiler error
// due to the potential for ambiguity (e.g. if C inherited from another class D).
// C x = i switch
// {
// 0 => new A(),
// 1 => new B(),
// _ => throw new ArgumentException(),
// };
if
(
expressionType
.
Equals
(
declarationType
)
||
seenTypes
.
Contains
(
expressionType
))
{
continue
;
}
var
invalidType
=
seenTypes
.
Any
(
t
=>
!
t
.
InheritsFromOrEquals
(
expressionType
)
&&
!
expressionType
.
InheritsFromOrEquals
(
t
));
if
(
invalidType
)
{
return
true
;
}
seenTypes
.
Add
(
expressionType
);
}
}
}
// If all arms are either throw statements, null literal expressions, or default literal expressions, return true.
if
(
noValidTypeExpressions
)
{
return
true
;
}
}
return
false
;
}
}
}
}
}
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录