Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
lwm1986
roslyn
提交
ea42a2b0
R
roslyn
项目概览
lwm1986
/
roslyn
与 Fork 源项目一致
从无法访问的项目Fork
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
DevOps
流水线
流水线任务
计划
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
roslyn
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
DevOps
DevOps
流水线
流水线任务
计划
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
流水线任务
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
ea42a2b0
编写于
1月 12, 2018
作者:
M
Martin Strecker
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Allow fixing VBs explicit interface implementations.
上级
36bcb451
变更
4
隐藏空白更改
内联
并排
Showing
4 changed file
with
28 addition
and
3 deletion
+28
-3
src/EditorFeatures/CSharp/UseAutoProperty/UseAutoPropertyAnalyzer.cs
...eatures/CSharp/UseAutoProperty/UseAutoPropertyAnalyzer.cs
+4
-1
src/EditorFeatures/VisualBasic/UseAutoProperty/UseAutoPropertyAnalyzer.vb
...es/VisualBasic/UseAutoProperty/UseAutoPropertyAnalyzer.vb
+4
-0
src/EditorFeatures/VisualBasicTest/Diagnostics/UseAutoProperty/UseAutoPropertyTests.vb
...cTest/Diagnostics/UseAutoProperty/UseAutoPropertyTests.vb
+18
-1
src/Features/Core/Portable/UseAutoProperty/AbstractUseAutoPropertyAnalyzer.cs
...rtable/UseAutoProperty/AbstractUseAutoPropertyAnalyzer.cs
+2
-1
未找到文件。
src/EditorFeatures/CSharp/UseAutoProperty/UseAutoPropertyAnalyzer.cs
浏览文件 @
ea42a2b0
...
...
@@ -22,12 +22,15 @@ protected override bool SupportsReadOnlyProperties(Compilation compilation)
protected
override
bool
SupportsPropertyInitializer
(
Compilation
compilation
)
=>
((
CSharpCompilation
)
compilation
).
LanguageVersion
>=
LanguageVersion
.
CSharp6
;
protected
override
bool
CanExplicitInterfaceImplementationsBeFixed
()
=>
false
;
protected
override
void
AnalyzeCompilationUnit
(
SemanticModelAnalysisContext
context
,
SyntaxNode
root
,
List
<
AnalysisResult
>
analysisResults
)
=>
AnalyzeMembers
(
context
,
((
CompilationUnitSyntax
)
root
).
Members
,
analysisResults
);
private
void
AnalyzeMembers
(
SemanticModelAnalysisContext
context
,
SemanticModelAnalysisContext
context
,
SyntaxList
<
MemberDeclarationSyntax
>
members
,
List
<
AnalysisResult
>
analysisResults
)
{
...
...
src/EditorFeatures/VisualBasic/UseAutoProperty/UseAutoPropertyAnalyzer.vb
浏览文件 @
ea42a2b0
...
...
@@ -21,6 +21,10 @@ Namespace Microsoft.CodeAnalysis.Editor.VisualBasic.UseAutoProperty
Return
DirectCast
(
compilation
,
VisualBasicCompilation
).
LanguageVersion
>=
LanguageVersion
.
VisualBasic10
End
Function
Protected
Overrides
Function
CanExplicitInterfaceImplementationsBeFixed
()
As
Boolean
Return
True
End
Function
Protected
Overrides
Sub
AnalyzeCompilationUnit
(
context
As
SemanticModelAnalysisContext
,
root
As
SyntaxNode
,
analysisResults
As
List
(
Of
AnalysisResult
))
AnalyzeMembers
(
context
,
DirectCast
(
root
,
CompilationUnitSyntax
).
Members
,
analysisResults
)
End
Sub
...
...
src/EditorFeatures/VisualBasicTest/Diagnostics/UseAutoProperty/UseAutoPropertyTests.vb
浏览文件 @
ea42a2b0
...
...
@@ -557,7 +557,7 @@ End Class")
<
WorkItem
(
23735
,
"https://github.com/dotnet/roslyn/issues/23735"
)
>
<
Fact
,
Trait
(
Traits
.
Feature
,
Traits
.
Features
.
CodeActionsUseAutoProperty
)
>
Public
Async
Function
ExplicitInterfaceImplementation
()
As
Task
Await
Test
Missing
InRegularAndScriptAsync
(
"
Await
TestInRegularAndScriptAsync
(
"
Namespace RoslynSandbox
Public Interface IFoo
ReadOnly Property Bar() As Object
...
...
@@ -579,6 +579,23 @@ Namespace RoslynSandbox
End Sub
End Class
End Namespace
"
,
"
Namespace RoslynSandbox
Public Interface IFoo
ReadOnly Property Bar() As Object
End Interface
Friend Class Foo
Implements IFoo
Private ReadOnly Property Bar() As Object Implements IFoo.Bar
Public Sub New(bar As Object)
Me.Bar = bar
End Sub
End Class
End Namespace
"
)
End
Function
End
Class
...
...
src/Features/Core/Portable/UseAutoProperty/AbstractUseAutoPropertyAnalyzer.cs
浏览文件 @
ea42a2b0
...
...
@@ -31,6 +31,7 @@ protected AbstractUseAutoPropertyAnalyzer()
protected
abstract
void
AnalyzeCompilationUnit
(
SemanticModelAnalysisContext
context
,
SyntaxNode
root
,
List
<
AnalysisResult
>
analysisResults
);
protected
abstract
bool
SupportsReadOnlyProperties
(
Compilation
compilation
);
protected
abstract
bool
SupportsPropertyInitializer
(
Compilation
compilation
);
protected
abstract
bool
CanExplicitInterfaceImplementationsBeFixed
();
protected
abstract
TExpression
GetFieldInitializer
(
TVariableDeclarator
variable
,
CancellationToken
cancellationToken
);
protected
abstract
TExpression
GetGetterExpression
(
IMethodSymbol
getMethod
,
CancellationToken
cancellationToken
);
protected
abstract
TExpression
GetSetterExpression
(
IMethodSymbol
setMethod
,
SemanticModel
semanticModel
,
CancellationToken
cancellationToken
);
...
...
@@ -113,7 +114,7 @@ protected void AnalyzeProperty(SemanticModelAnalysisContext context, TPropertyDe
return
;
}
if
(
property
.
ExplicitInterfaceImplementations
.
Length
!=
0
)
if
(
!
CanExplicitInterfaceImplementationsBeFixed
()
&&
property
.
ExplicitInterfaceImplementations
.
Length
!=
0
)
{
return
;
}
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录