Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
lwm1986
roslyn
提交
e9942c99
R
roslyn
项目概览
lwm1986
/
roslyn
与 Fork 源项目一致
从无法访问的项目Fork
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
DevOps
流水线
流水线任务
计划
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
roslyn
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
DevOps
DevOps
流水线
流水线任务
计划
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
流水线任务
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
e9942c99
编写于
9月 10, 2020
作者:
C
Charles Stoner
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Fix tests
上级
4e82fb1b
变更
3
隐藏空白更改
内联
并排
Showing
3 changed file
with
15 addition
and
8 deletion
+15
-8
src/Compilers/CSharp/Portable/Symbols/Source/SourceOrdinaryMethodSymbol.cs
...arp/Portable/Symbols/Source/SourceOrdinaryMethodSymbol.cs
+4
-4
src/Compilers/CSharp/Test/Semantic/Semantics/NativeIntegerTests.cs
...lers/CSharp/Test/Semantic/Semantics/NativeIntegerTests.cs
+8
-1
src/Compilers/CSharp/Test/Symbol/Symbols/ExtendedPartialMethodsTests.cs
...CSharp/Test/Symbol/Symbols/ExtendedPartialMethodsTests.cs
+3
-3
未找到文件。
src/Compilers/CSharp/Portable/Symbols/Source/SourceOrdinaryMethodSymbol.cs
浏览文件 @
e9942c99
...
...
@@ -608,6 +608,10 @@ private static void PartialMethodChecks(SourceOrdinaryMethodSymbol definition, S
checkNullableMethodOverride
=
false
;
diagnostics
.
Add
(
ErrorCode
.
ERR_PartialMethodReturnTypeDifference
,
implementation
.
Locations
[
0
]);
}
else
if
(
definition
.
RefKind
!=
implementation
.
RefKind
)
{
diagnostics
.
Add
(
ErrorCode
.
ERR_PartialMethodRefReturnDifference
,
implementation
.
Locations
[
0
]);
}
else
if
(
MemberSignatureComparer
.
ConsideringTupleNamesCreatesDifference
(
definition
,
implementation
))
{
diagnostics
.
Add
(
ErrorCode
.
ERR_PartialMethodInconsistentTupleNames
,
implementation
.
Locations
[
0
],
definition
,
implementation
);
...
...
@@ -619,10 +623,6 @@ private static void PartialMethodChecks(SourceOrdinaryMethodSymbol definition, S
static
FormattedSymbol
getFormattedSymbol
(
Symbol
symbol
)
=>
new
FormattedSymbol
(
symbol
,
SymbolDisplayFormat
.
MinimallyQualifiedFormat
);
}
if
(
definition
.
RefKind
!=
implementation
.
RefKind
)
{
diagnostics
.
Add
(
ErrorCode
.
ERR_PartialMethodRefReturnDifference
,
implementation
.
Locations
[
0
]);
}
if
(
definition
.
IsStatic
!=
implementation
.
IsStatic
)
{
...
...
src/Compilers/CSharp/Test/Semantic/Semantics/NativeIntegerTests.cs
浏览文件 @
e9942c99
...
...
@@ -3305,6 +3305,7 @@ class C2 : IA, IB
}
[Fact]
[WorkItem(45519, "https://github.com/dotnet/roslyn/issues/45519")]
public void Partial_01()
{
var source =
...
...
@@ -3316,7 +3317,13 @@ public void Partial_01()
static partial void F2(nuint x);
}";
var comp = CreateCompilation(source, parseOptions: TestOptions.Regular9);
comp.VerifyDiagnostics();
comp.VerifyDiagnostics(
// (4,25): error CS8824: Partial method declarations 'void Program.F2(nuint x)' and 'void Program.F2(UIntPtr x)' must have identical parameter types and identical return types.
// static partial void F2(System.UIntPtr x) { }
Diagnostic(ErrorCode.ERR_PartialMethodSignatureDifference, "F2").WithArguments("void Program.F2(nuint x)", "void Program.F2(UIntPtr x)").WithLocation(4, 25),
// (5,25): error CS8824: Partial method declarations 'void Program.F1(IntPtr x)' and 'void Program.F1(nint x)' must have identical parameter types and identical return types.
// static partial void F1(nint x) { }
Diagnostic(ErrorCode.ERR_PartialMethodSignatureDifference, "F1").WithArguments("void Program.F1(IntPtr x)", "void Program.F1(nint x)").WithLocation(5, 25));
}
[Fact]
...
...
src/Compilers/CSharp/Test/Symbol/Symbols/ExtendedPartialMethodsTests.cs
浏览文件 @
e9942c99
...
...
@@ -2957,9 +2957,9 @@ partial class C
}"
;
var
comp
=
CreateCompilation
(
source
,
parseOptions
:
TestOptions
.
RegularWithExtendedPartialMethods
);
comp
.
VerifyDiagnostics
(
// (
4,35
): error CS8142: Both partial method declarations, 'C.M1()' and 'C.M1()', must use the same tuple element names.
// public partial (int x
, int y) M1();
Diagnostic
(
ErrorCode
.
ERR_PartialMethodInconsistentTupleNames
,
"M1"
).
WithArguments
(
"C.M1()"
,
"C.M1()"
).
WithLocation
(
4
,
35
));
// (
5,37
): error CS8142: Both partial method declarations, 'C.M1()' and 'C.M1()', must use the same tuple element names.
// public partial (int x
1, int y1) M1() => default; // 1
Diagnostic
(
ErrorCode
.
ERR_PartialMethodInconsistentTupleNames
,
"M1"
).
WithArguments
(
"C.M1()"
,
"C.M1()"
).
WithLocation
(
5
,
37
));
}
[
Fact
,
WorkItem
(
44930
,
"https://github.com/dotnet/roslyn/issues/44930"
)]
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录