Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
lwm1986
roslyn
提交
e318a1a2
R
roslyn
项目概览
lwm1986
/
roslyn
与 Fork 源项目一致
从无法访问的项目Fork
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
DevOps
流水线
流水线任务
计划
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
roslyn
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
DevOps
DevOps
流水线
流水线任务
计划
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
流水线任务
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
未验证
提交
e318a1a2
编写于
10月 27, 2017
作者:
J
Julien Couvreur
提交者:
GitHub
10月 27, 2017
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Fix semantic model on deconstruction-foreach expression (#22878)
上级
ee88efd6
变更
3
隐藏空白更改
内联
并排
Showing
3 changed file
with
57 addition
and
1 deletion
+57
-1
src/Compilers/CSharp/Portable/Binder/ForEachLoopBinder.cs
src/Compilers/CSharp/Portable/Binder/ForEachLoopBinder.cs
+1
-1
src/Compilers/CSharp/Test/Emit/CodeGen/CodeGenDeconstructTests.cs
...ilers/CSharp/Test/Emit/CodeGen/CodeGenDeconstructTests.cs
+29
-0
src/EditorFeatures/Test2/Rename/InlineRenameTests.vb
src/EditorFeatures/Test2/Rename/InlineRenameTests.vb
+27
-0
未找到文件。
src/Compilers/CSharp/Portable/Binder/ForEachLoopBinder.cs
浏览文件 @
e318a1a2
...
...
@@ -249,7 +249,7 @@ private BoundForEachStatement BindForEachPartsWorker(DiagnosticBag diagnostics,
var
variables
=
node
.
Variable
;
if
(
variables
.
IsDeconstructionLeft
())
{
var
valuePlaceholder
=
new
BoundDeconstructValuePlaceholder
(
_syntax
.
Expression
,
collectionEscape
,
iterationVariableType
);
var
valuePlaceholder
=
new
BoundDeconstructValuePlaceholder
(
_syntax
.
Expression
,
collectionEscape
,
iterationVariableType
)
{
WasCompilerGenerated
=
true
}
;
DeclarationExpressionSyntax
declaration
=
null
;
ExpressionSyntax
expression
=
null
;
BoundDeconstructionAssignmentOperator
deconstruction
=
BindDeconstruction
(
...
...
src/Compilers/CSharp/Test/Emit/CodeGen/CodeGenDeconstructTests.cs
浏览文件 @
e318a1a2
...
...
@@ -3869,6 +3869,35 @@ .maxstack 3
}"
);
}
[
Fact
]
[
WorkItem
(
22495
,
"https://github.com/dotnet/roslyn/issues/22495"
)]
public
void
ForEachCollectionSymbol
()
{
string
source
=
@"
using System.Collections.Generic;
class Deconstructable
{
void M(IEnumerable<Deconstructable> x)
{
foreach (var (y1, y2) in x)
{
}
}
void Deconstruct(out int i, out int j) { i = 0; j = 0; }
}
"
;
var
compilation
=
CreateStandardCompilation
(
source
,
references
:
s_valueTupleRefs
);
var
tree
=
compilation
.
SyntaxTrees
.
First
();
var
model
=
compilation
.
GetSemanticModel
(
tree
);
var
collection
=
tree
.
GetRoot
().
DescendantNodes
().
OfType
<
ForEachVariableStatementSyntax
>().
Single
().
Expression
;
Assert
.
Equal
(
"x"
,
collection
.
ToString
());
var
symbol
=
model
.
GetSymbolInfo
(
collection
).
Symbol
;
Assert
.
Equal
(
SymbolKind
.
Parameter
,
symbol
.
Kind
);
Assert
.
Equal
(
"x"
,
symbol
.
Name
);
Assert
.
Equal
(
"System.Collections.Generic.IEnumerable<Deconstructable> x"
,
symbol
.
ToTestDisplayString
());
}
[
Fact
]
public
void
ForEachIEnumerableDeclarationWithNesting
()
{
...
...
src/EditorFeatures/Test2/Rename/InlineRenameTests.vb
浏览文件 @
e318a1a2
...
...
@@ -55,6 +55,33 @@ Namespace Microsoft.CodeAnalysis.Editor.UnitTests.Rename
End
Using
End
Function
<
WpfFact
>
<
Trait
(
Traits
.
Feature
,
Traits
.
Features
.
Rename
)
>
<
WorkItem
(
22495
,
"https://github.com/dotnet/roslyn/issues/22495"
)
>
Public
Async
Function
RenameDeconstructionForeachCollection
()
As
Task
Using
workspace
=
CreateWorkspaceWithWaiter
(
<
Workspace
>
<
Project
Language
=
"C#"
CommonReferences
=
"true"
>
<
Document
><
!
[
CDATA
[
using
System
.
Collections
.
Generic
;
class
Deconstructable
{
void
M
(
IEnumerable
<
Deconstructable
>
[|$$
x
|]
)
{
foreach
(
var
(
y1
,
y2
)
in
[|
x
|]
)
{
}
}
void
Deconstruct
(
out
int
i
,
out
int
j
)
{
i
=
0
;
j
=
0
;
}
}
]]
></
Document
>
</
Project
>
</
Workspace
>
)
Await
VerifyRenameOptionChangedSessionCommit
(
workspace
,
"x"
,
"change"
,
renameOverloads
:
=
True
)
End
Using
End
Function
<
WpfFact
>
<
Trait
(
Traits
.
Feature
,
Traits
.
Features
.
Rename
)
>
<
WorkItem
(
540120
,
"http://vstfdevdiv:8080/DevDiv2/DevDiv/_workitems/edit/540120"
)
>
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录