Fix line/column presentation for external items.

src/VisualStudio/Core/Def/Implementation/FindReferences/VisualStudioDefinitionsAndReferencesFactory.cs

@@ -39,7 +39,10 @@ public VisualStudioDefinitionsAndReferencesFactory(SVsServiceProvider servicePro
                 return null;
             }
 
-            var displayParts = GetDisplayParts(filePath, lineNumber, charOffset);
+            // Add one to the line/column so they are in 1-based coordinates for the UI.
+            // But keep them 0 based in the ExternalDefinitionLocation so that navigation
+            // works properly.
+            var displayParts = GetDisplayParts(filePath, lineNumber + 1, charOffset + 1);
             var definitionLocation = new ExternalDefinitionLocation(
                 _serviceProvider, filePath, lineNumber, charOffset);
 

src/VisualStudio/Core/Def/Implementation/Library/FindResults/LibraryManager_FindReferences.cs

@@ -59,11 +59,11 @@ public void PresentDefinitionsAndReferences(DefinitionsAndReferences definitions
 
                 // Each definition item may end up as several top nodes (because of partials).
                 // Add the references to the last item actually in the list.
-                var definitionTreeItem = i == n - 1
-                    ? new DefinitionTreeItem(definitionItem, location, referenceItems)
-                    : new DefinitionTreeItem(definitionItem, location);
+                var childItems = i == n - 1
+                    ? referenceItems
+                    : ImmutableArray<SourceReferenceTreeItem>.Empty;
 
-                result.Add(definitionTreeItem);
+                result.Add(new DefinitionTreeItem(definitionItem, location, childItems));
             }
 
             return result.ToImmutable();

src/VisualStudio/Core/Def/Implementation/Library/FindResults/TreeItems/DefinitionTreeItem.cs

@@ -17,17 +17,13 @@ internal class DefinitionTreeItem : AbstractTreeItem
         public DefinitionTreeItem(
             DefinitionItem definitionItem,
             DefinitionLocation definitionLocation,
-            ImmutableArray<SourceReferenceTreeItem> referenceItems = default(ImmutableArray<SourceReferenceTreeItem>))
+            ImmutableArray<SourceReferenceTreeItem> referenceItems)
             : base(definitionItem.Tags.GetGlyph().GetGlyphIndex())
         {
             _definitionItem = definitionItem;
             _definitionLocation = definitionLocation;
 
-            if (!referenceItems.IsDefault)
-            {
-                this.Children.AddRange(referenceItems);
-            }
-
+            this.Children.AddRange(referenceItems);
             this.DisplayText = CreateDisplayText();
         }