- Read the **feature specification** and related conversations
- Think about how the new language feature **interacts with each IDE feature**
- Are new keywords visualized appropriately?
- Do refactorings and fixes produce correct code utilizing the new language feature?
- How do IDE error recovery scenarios work?
- Do things work well across languages?
- How is perf on large/medium/small solutions? Are features properly cancellable?
- Etc.
-**Brainstorm ideas** for new features to enhance the language feature
- Should existing code be refactored to some new pattern?
- Should users be able to easily switch between two equivalent forms?
- Do we need to make the flow of this feature easier to visualize?
- Etc.
### Test Outputs
-[**Merge Signoff**](#mergesignoff): Can the language feature be merged, with all *Internal Dogfooding Requirements* met and all *IDE Features* free of crashes and asserts?
-[**Feature Signoff**](#featuresignoff): Per-feature signoff with links to non-blocking issues.
-[**Feature Suggestions**](#featuresuggestions): What can we add to the IDE to make the new language feature delightful to use?
### Testing tags
:white_check_mark: = Tested & Approved (possibly with linked bugs)
:x: = Merge blocking
:construction: = Non-blocking bugs
:ok: = Issue has been fixed
:free: = No expected impact
:question: = Open question
<aname="testfootnote1"><sup>1</sup></a> Feature updated by compiler team, with appropriate unit tests.
<aname="testfootnote2"><sup>2</sup></a> Feature requires more complete testing by IDE team.
Critical IDE features in the areas of **Typing**, **Navigating**, and **Viewing** must function as expected. Any non-trivial issues in these areas blocking language feature merging.
*All feature descriptions and testing suggestions are merely examples. Each language feature should be carefully considered independently against each IDE feature to find interesting intersections*
| **Enable/Disable** | **Feature Flag**<br/>Completely enables/disables the feature in the compiler & IDE | | |
| **Typing** | **General Typing**<br/>- Type and paste new constructs<br/>- Nothing interferes with verbatim typing | |
| | **Completion**<br/>- Typing new keyword/construct names<br/>- Dotting off of new constructs<br/>- Matching part of the identifier is highlighted (including word prefix matches) [VS2015 Update 1+]<br/>- Target type preselection [VS2017+]<br/>IntelliSense filtering [VS2017+] | | |
| | **Formatting**<br/>- Spacing in and around new constructs<br/>- Spacing options<br/>- Format Document command<br/>`Tools > Options` settings should be respected | | |
| | **Automatic Brace Completion** (*C# only*) <br/>- Auto-insert close brace<br/>- Shift+Enter commit of IntelliSense and any pending brace completion sessions (Known issue: https://github.com/dotnet/roslyn/issues/18065) | | |
| | **Indentation**<br/>- Typing `Enter` in an unfinished statement indents the next line | | |
| **Navigating** | **Go To Definition**<br/>- F12 from callsites to definition | | |
| | **Go To Implementation**<br/>- Ctrl+F12 to jump from virtual members to their implementations<br/>- Jump from inheritable types to their implementations | | |
| | **Find All References**<br/>- Lists references to a symbol in "Find Symbol Results" window<br/>- Shows results in hierarchy grouped by definition [VS2015+]<br/>- Results should be groupable/filterable/classified appropriately [VS2017+] <br/>- Find All References on literals [VS2017 Update 3] | | |
| **Viewing** | **Colorization**<br/>- Keywords, literals, and identifiers colored appropriately in code | | |
| | **Error Squiggles**<br/>- Squiggles appear as expected on reasonable spans | | |
## <a name="featuresignoff">IDE Features (Feature Signoff)</a>
For the remaining set of IDE features, only crashes and asserts are considered blocking. However, *all* issues discovered must be filed and linked here.
*All feature descriptions and testing suggestions are merely examples. Each language feature should be carefully considered independently against each IDE feature to find interesting intersections*
| **Refactoring with UI** | **Inline Rename (with UI)**<br/>- Dashboard shows correct information<br/>- Highlighted spans are updated appropriately<br/>- Rename operation updates the correct set of symbols | | |
| | **Change Signature (with UI)**<br/>- Updates all direct & cascaded definitions/callsites<br/>- Shows appropriate signature & parameter previews in UI<br/>- Reorder and Remove in the same session [VS2015+] | | |
| | **Encapsulate Field**<br/>- Select a field and convert it to a property backed by the field<br/>- Try selecting multiple fields at once | | |
| **Fixes** | **Add Using**<br/>- Triggers on appropriate constructs<br/>- Including NuGet references<br/>- Including Referenced Assemblies<br/>- Includes spelling fixes | | |
| | **Generate Local**<br/>- Select an expression and introduce a local variable to represent it<br/>- This should start an Inline Rename session | | |
| | **Generate Field**<br/>- Select an expression and introduce a field to represent it<br/>- This should start an Inline Rename session | | |
| | **Generate Method/Constructor**<br/>- Call a nonexistent method or constructor to generate it from its usage<br/>- Generated method has the expected signature and accessibility<br/>- Add parameter to existing constructor from callsite [VS2017 Update 3] | | |
| | **Generate Constructor from members**<br/>- Select fields/properties to generate a constructor accepting corresponding arguments<br/>- Generated constructor has the expected signature and accessibility | | |
| | **Implement Interface**<br/>- Only missing methods added<br/>- All added methods have the expected signature and accessibility | | |
| | **Implement IDisposable**<br/>- Implement IDisposable and you should see a large block of code properly implementing that particular interface | | |
| | **Implement Abstract Class**<br/>- Inherit from an abstract class, and you should be able to auto-generate all of the missing members | | |
| | **Convert Get Methods to Properties**<br/>- Name a method `GetStuff` and convert it to a property called `Stuff` | | |
| | **Make Method Async/Sync**<br/>- Add an `await` to a synchronous method, you should be offered to add the async keyword<br/>- Remove all `await` keywords from an async method, you should be offered to remove the async keyword | | |
| | **Use Object Initializer Over Property Assignment**<br/>- Create a new instance of a type and then assign each of its properties on subsequent lines<br/>- You should be offered to convert that to an object initializer | | |
| **Code Gen** | **Snippets**<br/>- Tab completion, presence in completion list<br/>- Insertion via Snippet Picker UI (Ctrl + K, Ctrl + X) or (Ctrl + K, Ctrl + S)<br/>- (VB) Snippet Picker UI via `?<Tab>`<br/>- (VB) Special snippet completion list (`p?<esc><tab>`) | | |
| | **Event Hookup on Tab** (*C# only*)<br/>- Type "+=" after an event name and QuickInfo shows<br/>- Invoking should pick good name & launch Inline Rename | | N/A |
| | **End Construct Generation** (*VB only*)<br/>- Type `Sub Test()` and hit enter, the `End Sub` should be generated automatically | N/A | |
| | **Automatic End Construct Update** (*VB only*)<br/>- Type `Sub Test()` and `End Sub`, changing `Sub` to `Function` in either one should update the other | N/A | |
| | **Spell checking**<br/>- Type a name that's close to a variable name but off by a character or two<br/>- Lightbulb should have option to fix up the spelling<br/>- Includes type names that will require a using | | |
| | **Move type to file**<br/>- Lightbulb to move type to another file when the type name doesn't match the filename<br/>- Option to change the file name if the type doesn't match the file name | | |
| | **Convert between properties and Get methods**<br/>- Offers to change a method named `GetStuff` to a property named `Stuff` | | |
| | **Add missing cases**<br/>Use a `switch` on a strict subset of an Enum's members<br/>- It should offer to generate the rest of the cases | | |
| | **Quick Info**<br/>- Hover on identifiers<br/>- On completion list items | | |
| | **Outlining**<br/>- Make sure outlining is enabled under options<br/>- Define a method and expect to see a collapsible region around the method definition<br/>- Make sure collapse and expand work | | |
| | **Brace Matching** (*C# only*)<br/>- Highlights matching brace token, if caret is on an open or close brace.<br/>- Hovering on a close brace shows the code around the open brace | | N/A |
| | **Highlight References**<br/>- Ensure "Highlight references to symbol under cursor" is enabled in options<br/>- If caret is on an identifier, all references to that identifier in the active document should be highlighted<br/>- We also show related keywords, so placing the caret on a return should show the other returns, if should show elses, try shows catches and finallys, etc.<br/>- Should be able to navigate between highlighted references with Ctrl+Shift+Up/Down | | |
| | **Peek**<br/>Press Alt + F12 after placing the cursor on a predefined Type or predefined member and expect to see to a temporary window showing the appropriate definition | | |
| | **Navigation Bars**<br/>- Open some existing source files, make sure you can navigate around the file choosing classes or methods.<br/>- In VB, the NavBar can do code generation for events and for New/Finalize methods | | |
| | **Metadata As Source**<br/>- Press F12 on a predefined type and expect the cursor to move the predefined type definition inside a Metadata-As-Source Generated document.<br/>- Expect to see the xml doc comments collapsed above the method. | | |
| | **Navigate To**<br/>- Place cursor over a user defined Type reference and press "ctrl + ,"<br/>- This should list the User Defined Type in the drop down on the Upper Right corner of the editor and selecting this item will move the cursor to the User Reference Definition<br/>- Filters per kind of symbol [VS2017] | | |
| | **Go to Next/Previous Method**<br/>- `Edit.NextMethod` and `Edit.PreviousMethod` should work<br/>- You may need to set up keyboard bindings for these commands under `Tools > Options > Environment > Keyboard` | | |
| | **Solution Explorer Pivots**<br/>- Define a Type and some members in a sample Document.<br/>- Expand the Document listed in the Solution Explorer window and expect to see the Type and Members defined<br/>- Right-click types and try Base Types / Derived Types / Is Used By / Implements<br/> - Right-click methods and try Calls / Is Called By / Is Used By / Implements | | |
| | **Call Hierarchy**<br/>- Place the caret over a method, right click & select View Hierarchy<br/>- This should open the "Call Hierarchy window" listing the methods that call the original method and also the callsites within each calling method. | | |
| | **Code Lens**<br/>- Make sure Code Lens is enabled from the options. Look for an adornment on top of each method declaration with lists the number of references for that method, last time someone modified the method, who modified the method and other information | | |
| | **Project System**<br/>- Open/close a project<br/>- Add/remove references<br/>- Unload/reload projects<br/>- Source Control integration (adding references checks out projects, etc.) | | |
| | **Debugger IntelliSense**<br/>- Hit a breakpoint (or step) and verify that there's IntelliSense in the Immediate Window (C#, VB)<br/>- Type an expression, and hit enter. Verify it's evaluated. Type another expression. IntelliSense should still work.<br/>- (VB) there should be IntelliSense if you type "?" followed by an expression (eg, the text of the line in the window is "?foo")<br/>- Hit a breakpoint (or step) and verify that there's IntelliSense in the Watch Window<br/>- Hit a breakpoint (or step) and verify that there's IntelliSense in the Quick Watch Window<br/> - Verify intellisense in the Conditional Breakpoint view<br/>- Verify each of the above scenarios after hitting f5 and hitting another breakpoint, and after stepping | | |
| | **Breakpoint Spans**<br/>- The span highlighted when a breakpoint is set should be logical | | |
| | **Code Model / Class Designer**<br/>- Right click a file in Solution Explorer & choose View Class Diagram.<br/>- This shows the "Class Details" window where you can add/remove members, change their type/accessibility/name, parameter info, etc. | | |
| | **Object Browser / Class View**<br/>- Open object browser and classview and verify that project contents are represented live.<br/>- Should be able to invoke find all references, navigate to the definition, and do searches. | | |
| | **Lightbulb**<br/>- Should work with `Ctrl+.` and the right-click menu<br/>- Should include a diff view<br/>- Should include options to fix all in Document/Project/Solution, and to Preview Changes | | |
| | **Line Separators**<br/>- Turn the option on under `Tools > Options`<br/>- Ensure there's a line between methods. | | |
| | **Indent Guides**<br/>- Vertical dotted lines appear between braces for declaration-level things<br/>- Hovering on the line shows context | | |
(Any changes to the runtime will require much more testing in this category)
*All feature descriptions and testing suggestions are merely examples. Each language feature should be carefully considered independently against each IDE feature to find interesting intersections*
| Category | Integration | Signoff/Notes |
| --- | --- | --- |
| **Projection Buffers** | **Razor** (web)<br/>- Verify expression and block contexts<br/>- Test on projection boundaries<br/> - Emphasis on rename and formatting | |
| | **Venus**<br/>- Verify expression and block contexts<br/>- Test on projection boundaries<br/> - Emphasis on rename and formatting | |
| **Designers** | **WPF**<br/>- Event generation from designer to code<br/>- Designer consumption of new types of members<br/>- Cross language features (Go to definition, find references, rename) | |
| | **WinForms**<br/>- Create a project, add some controls to the form<br/>- Verify that simple changes to InitializeComponent round-trip to the designer.<br/>- Verify that double clicking a control generates or navigates to an event handler for its default event | |
