提交 d5d5b70b 编写于 作者: M Manish Vasani

Address feedback + simplify code

上级 2a7d423c
......@@ -372,26 +372,18 @@ internal bool IsSupportedDiagnostic(DiagnosticAnalyzer analyzer, Diagnostic diag
foreach (var tree in compilation.SyntaxTrees)
{
// Check if diagnostic is enabled by SyntaxTree.DiagnosticOptions or Bulk configuration from AnalyzerConfigOptions.
if (tree.DiagnosticOptions.TryGetValue(descriptor.Id, out var configuredValue))
if (tree.DiagnosticOptions.TryGetValue(descriptor.Id, out var configuredValue) ||
analyzerOptions.TryGetSeverityFromBulkConfiguration(tree, compilation, descriptor, out configuredValue))
{
if (isEnablingSeverity(configuredValue, severityFilter))
if (configuredValue != ReportDiagnostic.Suppress && !severityFilter.Contains(configuredValue))
{
return true;
}
}
else if (!severityFilter.IsEmpty &&
analyzerOptions.TryGetSeverityFromBulkConfiguration(tree, compilation, descriptor, out var bulkConfiguredValue) &&
isEnablingSeverity(bulkConfiguredValue, severityFilter))
{
return true;
}
}
}
return false;
static bool isEnablingSeverity(ReportDiagnostic severity, SeverityFilter severityFilter)
=> severity != ReportDiagnostic.Suppress && !severityFilter.Contains(severity);
}
}
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册