提交 d1217f4a 编写于 作者: C Cyrus Najmabadi

simplify

上级 9660be0a
......@@ -205,7 +205,7 @@ private async ValueTask<ImmutableArray<IParameterSymbol>> DetermineParametersAsy
var optionality = DetermineParameterOptionality(cancellationToken);
var names = DetermineParameterNames(cancellationToken);
var result = ArrayBuilder<IParameterSymbol>.GetInstance();
using var _ = ArrayBuilder<IParameterSymbol>.GetInstance(out var result);
for (var i = 0; i < modifiers.Length; i++)
{
result.Add(CodeGenerationSymbolFactory.CreateParameterSymbol(
......@@ -217,7 +217,7 @@ private async ValueTask<ImmutableArray<IParameterSymbol>> DetermineParametersAsy
name: names[i].BestNameForParameter));
}
return result.ToImmutableAndFree();
return result.ToImmutable();
}
private Accessibility DetermineAccessibility(bool isAbstract)
......
......@@ -38,7 +38,7 @@ protected virtual string GetExplicitConversionDisplayText(State state)
protected async ValueTask<ImmutableArray<CodeAction>> GetActionsAsync(Document document, State state, CancellationToken cancellationToken)
{
var result = ArrayBuilder<CodeAction>.GetInstance();
using var _ = ArrayBuilder<CodeAction>.GetInstance(out var result);
result.Add(new GenerateParameterizedMemberCodeAction((TService)this, document, state, isAbstract: false, generateProperty: false));
// If we're trying to generate an instance method into an abstract class (but not a
......@@ -49,9 +49,7 @@ protected async ValueTask<ImmutableArray<CodeAction>> GetActionsAsync(Document d
!state.IsStatic;
if (canGenerateAbstractly)
{
result.Add(new GenerateParameterizedMemberCodeAction((TService)this, document, state, isAbstract: true, generateProperty: false));
}
var semanticFacts = document.Project.Solution.Workspace.Services.GetLanguageServices(state.TypeToGenerateIn.Language).GetService<ISemanticFactsService>();
......@@ -66,13 +64,11 @@ protected async ValueTask<ImmutableArray<CodeAction>> GetActionsAsync(Document d
result.Add(new GenerateParameterizedMemberCodeAction((TService)this, document, state, isAbstract: false, generateProperty: true));
if (canGenerateAbstractly)
{
result.Add(new GenerateParameterizedMemberCodeAction((TService)this, document, state, isAbstract: true, generateProperty: true));
}
}
}
return result.ToImmutableAndFree();
return result.ToImmutable();
}
}
}
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册