Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
lwm1986
roslyn
提交
d112b4b1
R
roslyn
项目概览
lwm1986
/
roslyn
与 Fork 源项目一致
从无法访问的项目Fork
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
DevOps
流水线
流水线任务
计划
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
roslyn
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
DevOps
DevOps
流水线
流水线任务
计划
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
流水线任务
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
d112b4b1
编写于
11月 27, 2017
作者:
V
Victor Z
提交者:
Sam Harwell
11月 27, 2017
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Fixed 'Qualify member access' analyzer for object initializer
上级
21127b7c
变更
4
隐藏空白更改
内联
并排
Showing
4 changed file
with
72 addition
and
2 deletion
+72
-2
src/EditorFeatures/CSharpTest/QualifyMemberAccess/QualifyMemberAccessTests.cs
...SharpTest/QualifyMemberAccess/QualifyMemberAccessTests.cs
+38
-0
src/EditorFeatures/VisualBasicTest/QualifyMemberAccess/QualifyMemberAccessTests.vb
...BasicTest/QualifyMemberAccess/QualifyMemberAccessTests.vb
+30
-0
src/Features/CSharp/Portable/QualifyMemberAccess/CSharpQualifyMemberAccessDiagnosticAnalyzer.cs
...mberAccess/CSharpQualifyMemberAccessDiagnosticAnalyzer.cs
+3
-1
src/Features/VisualBasic/Portable/Diagnostics/Analyzers/VisualBasicQualifyMemberAccessDiagnosticAnalyzer.vb
...yzers/VisualBasicQualifyMemberAccessDiagnosticAnalyzer.vb
+1
-1
未找到文件。
src/EditorFeatures/CSharpTest/QualifyMemberAccess/QualifyMemberAccessTests.cs
浏览文件 @
d112b4b1
...
...
@@ -1238,6 +1238,44 @@ public async Task QualifyPropertyAccess_InAccessorWithBodyAndExpressionBody2()
public string Foo { get; set; }
public string Bar { get { return Foo; } => this.Foo; }
}"
,
CodeStyleOptions
.
QualifyPropertyAccess
);
}
[
WorkItem
(
22776
,
"https://github.com/dotnet/roslyn/issues/22776"
)]
[
Fact
,
Trait
(
Traits
.
Feature
,
Traits
.
Features
.
CodeActionsQualifyMemberAccess
)]
public
async
Task
DoNotReportToQualify_InObjectInitializer1
()
{
await
TestMissingAsyncWithOption
(
@"public class C
{
public string Foo { get; set; }
public void Bar()
{
var c = new C
{
[|Foo|] = string.Empty
};
}
}"
,
CodeStyleOptions
.
QualifyPropertyAccess
);
}
[
WorkItem
(
22776
,
"https://github.com/dotnet/roslyn/issues/22776"
)]
[
Fact
,
Trait
(
Traits
.
Feature
,
Traits
.
Features
.
CodeActionsQualifyMemberAccess
)]
public
async
Task
DoNotReportToQualify_InObjectInitializer2
()
{
await
TestMissingAsyncWithOption
(
@"public class C
{
public string Foo;
public void Bar()
{
var c = new C
{
[|Foo|] = string.Empty
};
}
}"
,
CodeStyleOptions
.
QualifyPropertyAccess
);
}
}
...
...
src/EditorFeatures/VisualBasicTest/QualifyMemberAccess/QualifyMemberAccessTests.vb
浏览文件 @
d112b4b1
...
...
@@ -586,6 +586,36 @@ Class C
Private Shared Field As String = NameOf([|Value|])
End Class
"
,
CodeStyleOptions
.
QualifyFieldAccess
)
End
Function
<
WorkItem
(
22776
,
"https://github.com/dotnet/roslyn/issues/22776"
)
>
<
Fact
,
Trait
(
Traits
.
Feature
,
Traits
.
Features
.
CodeActionsQualifyMemberAccess
)
>
Public
Async
Function
DoNotReportToQualify_InObjectInitializer1
()
As
Task
Await
TestMissingAsyncWithOption
(
"
class C
Public Foo As Integer
Sub Bar()
Dim c = New C() With { [|.Foo = 1|] }
End Sub
End Class
"
,
CodeStyleOptions
.
QualifyFieldAccess
)
End
Function
<
WorkItem
(
22776
,
"https://github.com/dotnet/roslyn/issues/22776"
)
>
<
Fact
,
Trait
(
Traits
.
Feature
,
Traits
.
Features
.
CodeActionsQualifyMemberAccess
)
>
Public
Async
Function
DoNotReportToQualify_InObjectInitializer2
()
As
Task
Await
TestMissingAsyncWithOption
(
"
class C
Public Property Foo As Integer
Sub Bar()
Dim c = New C() With { [|.Foo|] = 1 }
End Sub
End Class
"
,
CodeStyleOptions
.
QualifyFieldAccess
)
End
Function
End
Class
...
...
src/Features/CSharp/Portable/QualifyMemberAccess/CSharpQualifyMemberAccessDiagnosticAnalyzer.cs
浏览文件 @
d112b4b1
...
...
@@ -18,7 +18,9 @@ protected override bool IsAlreadyQualifiedMemberAccess(SyntaxNode node)
// If the member is already qualified with `base.`, it cannot be further qualified.
protected
override
bool
CanMemberAccessBeQualified
(
ISymbol
containingSymbol
,
SyntaxNode
node
)
=>
!(
node
.
IsKind
(
SyntaxKind
.
BaseExpression
)
||
IsInPropertyOrFieldInitialization
(
containingSymbol
,
node
));
=>
!(
node
.
IsKind
(
SyntaxKind
.
BaseExpression
)
||
node
.
Parent
.
Parent
.
IsKind
(
SyntaxKind
.
ObjectInitializerExpression
)
||
IsInPropertyOrFieldInitialization
(
containingSymbol
,
node
));
private
bool
IsInPropertyOrFieldInitialization
(
ISymbol
containingSymbol
,
SyntaxNode
node
)
{
...
...
src/Features/VisualBasic/Portable/Diagnostics/Analyzers/VisualBasicQualifyMemberAccessDiagnosticAnalyzer.vb
浏览文件 @
d112b4b1
...
...
@@ -18,7 +18,7 @@ Namespace Microsoft.CodeAnalysis.VisualBasic.QualifyMemberAccess
Protected
Overrides
Function
CanMemberAccessBeQualified
(
containingSymbol
As
ISymbol
,
node
As
SyntaxNode
)
As
Boolean
' If the member is already qualified with `MyBase.`, or `MyClass.`, it cannot be further qualified.
Return
Not
(
node
.
IsKind
(
SyntaxKind
.
MyBaseExpression
)
OrElse
node
.
IsKind
(
SyntaxKind
.
MyClassExpression
))
Return
Not
(
node
.
IsKind
(
SyntaxKind
.
MyBaseExpression
)
OrElse
node
.
IsKind
(
SyntaxKind
.
MyClassExpression
)
OrElse
node
.
IsKind
(
SyntaxKind
.
ObjectCreationExpression
)
)
End
Function
End
Class
End
Namespace
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录