Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
lwm1986
roslyn
提交
d01fcb66
R
roslyn
项目概览
lwm1986
/
roslyn
与 Fork 源项目一致
从无法访问的项目Fork
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
DevOps
流水线
流水线任务
计划
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
roslyn
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
DevOps
DevOps
流水线
流水线任务
计划
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
流水线任务
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
d01fcb66
编写于
9月 30, 2015
作者:
J
Jason Malinowski
浏览文件
操作
浏览文件
下载
差异文件
Merge pull request #5585 from jasonmalinowski/fix-endconstruct-with-broken-property
Unbreak End Construct around an broken code scenario
上级
f85b53ea
38f32023
变更
2
隐藏空白更改
内联
并排
Showing
2 changed file
with
16 addition
and
0 deletion
+16
-0
src/EditorFeatures/VisualBasic/EndConstructGeneration/EndConstructStatementVisitor_Properties.vb
...ructGeneration/EndConstructStatementVisitor_Properties.vb
+6
-0
src/EditorFeatures/VisualBasicTest/EndConstructGeneration/PropertyBlockTests.vb
...ualBasicTest/EndConstructGeneration/PropertyBlockTests.vb
+10
-0
未找到文件。
src/EditorFeatures/VisualBasic/EndConstructGeneration/EndConstructStatementVisitor_Properties.vb
浏览文件 @
d01fcb66
...
@@ -41,6 +41,12 @@ Namespace Microsoft.CodeAnalysis.Editor.VisualBasic.EndConstructGeneration
...
@@ -41,6 +41,12 @@ Namespace Microsoft.CodeAnalysis.Editor.VisualBasic.EndConstructGeneration
lines
.
AddRange
(
GenerateSetAccessor
(
node
,
_subjectBuffer
.
CurrentSnapshot
))
lines
.
AddRange
(
GenerateSetAccessor
(
node
,
_subjectBuffer
.
CurrentSnapshot
))
End
If
End
If
' If we didn't need any accessors, that already means there's some accessor after us. Spitting
' End Property (if we have to) after that point would just make more broken code, so just bail
If
lines
.
Count
=
0
Then
Return
Nothing
End
If
' If we are missing a End Property, then spit it
' If we are missing a End Property, then spit it
If
propertyBlock
Is
Nothing
OrElse
propertyBlock
.
EndPropertyStatement
.
IsMissing
Then
If
propertyBlock
Is
Nothing
OrElse
propertyBlock
.
EndPropertyStatement
.
IsMissing
Then
Dim
aligningWhitespace
=
_subjectBuffer
.
CurrentSnapshot
.
GetAligningWhitespace
(
node
.
SpanStart
)
Dim
aligningWhitespace
=
_subjectBuffer
.
CurrentSnapshot
.
GetAligningWhitespace
(
node
.
SpanStart
)
...
...
src/EditorFeatures/VisualBasicTest/EndConstructGeneration/PropertyBlockTests.vb
浏览文件 @
d01fcb66
...
@@ -146,6 +146,16 @@ Namespace Microsoft.CodeAnalysis.Editor.VisualBasic.UnitTests.EndConstructGenera
...
@@ -146,6 +146,16 @@ Namespace Microsoft.CodeAnalysis.Editor.VisualBasic.UnitTests.EndConstructGenera
afterCaret
:
=
{
3
,
-
1
})
afterCaret
:
=
{
3
,
-
1
})
End
Sub
End
Sub
<
Fact
,
Trait
(
Traits
.
Feature
,
Traits
.
Features
.
EndConstructGeneration
)
>
Public
Sub
DontApplyForReadOnlyPropertyIfEndPropertyMissingWhenInvokedAfterProperty
()
VerifyStatementEndConstructNotApplied
(
text
:
=
{
"Class c1"
,
" ReadOnly Property foo As Integer"
,
" Get"
,
"End Class"
},
caret
:
=
{
1
,
-
1
})
End
Sub
<
Fact
,
Trait
(
Traits
.
Feature
,
Traits
.
Features
.
EndConstructGeneration
)
>
<
Fact
,
Trait
(
Traits
.
Feature
,
Traits
.
Features
.
EndConstructGeneration
)
>
Public
Sub
TestApplyOnGetForRegularPropertyWithSetPresent
()
Public
Sub
TestApplyOnGetForRegularPropertyWithSetPresent
()
VerifyStatementEndConstructApplied
(
VerifyStatementEndConstructApplied
(
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录