Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
lwm1986
roslyn
提交
cf911f2f
R
roslyn
项目概览
lwm1986
/
roslyn
与 Fork 源项目一致
从无法访问的项目Fork
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
DevOps
流水线
流水线任务
计划
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
roslyn
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
DevOps
DevOps
流水线
流水线任务
计划
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
流水线任务
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
cf911f2f
编写于
10月 25, 2019
作者:
G
Gen Lu
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Support having multiple identical aliases as ext methods' target type
上级
7a5229f1
变更
2
隐藏空白更改
内联
并排
Showing
2 changed file
with
34 addition
and
10 deletion
+34
-10
src/EditorFeatures/CSharpTest/Completion/CompletionProviders/ExtensionMethodImportCompletionProviderTests.cs
...Providers/ExtensionMethodImportCompletionProviderTests.cs
+2
-2
src/Workspaces/Core/Portable/FindSymbols/SyntaxTree/SyntaxTreeIndex_Create.cs
...Portable/FindSymbols/SyntaxTree/SyntaxTreeIndex_Create.cs
+32
-8
未找到文件。
src/EditorFeatures/CSharpTest/Completion/CompletionProviders/ExtensionMethodImportCompletionProviderTests.cs
浏览文件 @
cf911f2f
...
...
@@ -1096,9 +1096,9 @@ public void M(int x)
}
[
InlineData
(
"int"
,
"Int32Method"
,
"Foo"
)]
[
InlineData
(
"string"
,
"StringMethod"
,
"Bar"
,
Skip
=
"Currently can't handle aliases with idencical name"
)]
[
InlineData
(
"string"
,
"StringMethod"
,
"Bar"
)]
[
Theory
,
Trait
(
Traits
.
Feature
,
Traits
.
Features
.
Completion
)]
public
async
Task
TestIdenticalAlias
_UseOuterOne
(
string
type
,
string
expectedMethodname
,
string
expectedNamespace
)
public
async
Task
TestIdenticalAlias
es
(
string
type
,
string
expectedMethodname
,
string
expectedNamespace
)
{
var
file1
=
@"
using X = System.String;
...
...
src/Workspaces/Core/Portable/FindSymbols/SyntaxTree/SyntaxTreeIndex_Create.cs
浏览文件 @
cf911f2f
...
...
@@ -120,12 +120,26 @@ internal sealed partial class SyntaxTreeIndex
{
foreach
(
var
(
aliasName
,
name
)
in
aliases
)
{
// TODO:
// we currently don't handle using aliases with same name declared
// in different containers in the document (only allowed in C#)
// e.g. see test CSharpReferenceHighlightingTests.TestAlias4
// Debug.Assert(!usingAliases.ContainsKey(aliasName));
usingAliases
[
aliasName
]
=
name
;
// In C#, it's valid to declare two alias with identical name,
// as long as they are in different containers.
//
// e.g.
// using X = System.String;
// namespace N
// {
// using X = System.Int32;
// }
//
// If we detect this, we will simply treat extension methods whose
// target type is this alais as complex method.
if
(
usingAliases
.
ContainsKey
(
aliasName
))
{
usingAliases
[
aliasName
]
=
null
;
}
else
{
usingAliases
[
aliasName
]
=
name
;
}
}
}
...
...
@@ -288,19 +302,29 @@ internal sealed partial class SyntaxTreeIndex
return
;
}
// complex
type
// complex
method
if
(
targetTypeName
==
null
)
{
complexInfoBuilder
.
Add
(
declaredSymbolInfoIndex
);
return
;
}
// Target type is an alias
if
(
aliases
.
TryGetValue
(
targetTypeName
,
out
var
originalName
))
{
// it is an alias of multiple with identical name,
// simply treat it as a complex method.
if
(
originalName
==
null
)
{
complexInfoBuilder
.
Add
(
declaredSymbolInfoIndex
);
return
;
}
// replace the alias with its original name.
targetTypeName
=
originalName
;
}
//
simple type
//
So we've got a simple method.
if
(!
simpleInfoBuilder
.
TryGetValue
(
targetTypeName
,
out
var
arrayBuilder
))
{
arrayBuilder
=
ArrayBuilder
<
int
>.
GetInstance
();
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录