Simplify harness

src/EditorFeatures/CSharpTest/GenerateFromMembers/GenerateEqualsAndGetHashCodeFromMembers/GenerateEqualsAndGetHashCodeFromMembersTests.cs

@@ -97,12 +97,11 @@ private static OptionsCollection PreferExplicitTypeWithInfo()
             int index = 0,
             OptionsCollection options = null,
             List<DiagnosticResult> expectedDiagnostics = null,
-            List<DiagnosticResult> testExpectedDiagnostics = null,
             List<DiagnosticResult> fixedExpectedDiagnostics = null)
         {
             return TestInRegularAndScript1Async(
                 initialMarkup, expectedMarkup, index, new TestParameters(options: options),
-                expectedDiagnostics, testExpectedDiagnostics, fixedExpectedDiagnostics);
+                expectedDiagnostics, fixedExpectedDiagnostics);
         }
 
         private static Task TestInRegularAndScript1Async(
@@ -111,12 +110,11 @@ private static OptionsCollection PreferExplicitTypeWithInfo()
             int index = 0,
             TestParameters? parameters = null,
             List<DiagnosticResult> expectedDiagnostics = null,
-            List<DiagnosticResult> testExpectedDiagnostics = null,
             List<DiagnosticResult> fixedExpectedDiagnostics = null)
         {
             return TestInRegularAndScript1Async(
                 new[] { initialMarkup }, new[] { expectedMarkup }, index, parameters,
-                expectedDiagnostics, testExpectedDiagnostics, fixedExpectedDiagnostics);
+                expectedDiagnostics, fixedExpectedDiagnostics);
         }
 
         private static Task TestWithPickMembersDialogAsync(
@@ -127,7 +125,6 @@ private static OptionsCollection PreferExplicitTypeWithInfo()
             int index = 0,
             TestParameters parameters = default,
             List<DiagnosticResult> expectedDiagnostics = null,
-            List<DiagnosticResult> testExpectedDiagnostics = null,
             List<DiagnosticResult> fixedExpectedDiagnostics = null)
         {
             return TestWithPickMembersDialogAsync(
@@ -138,7 +135,6 @@ private static OptionsCollection PreferExplicitTypeWithInfo()
                 index,
                 parameters,
                 expectedDiagnostics,
-                testExpectedDiagnostics,
                 fixedExpectedDiagnostics);
         }
 
@@ -150,7 +146,6 @@ private static OptionsCollection PreferExplicitTypeWithInfo()
             int index = 0,
             TestParameters parameters = default,
             List<DiagnosticResult> expectedDiagnostics = null,
-            List<DiagnosticResult> testExpectedDiagnostics = null,
             List<DiagnosticResult> fixedExpectedDiagnostics = null)
         {
             var pickMembersService = new TestPickMembersService(chosenSymbols.AsImmutableOrNull(), optionsCallback);
@@ -159,7 +154,6 @@ private static OptionsCollection PreferExplicitTypeWithInfo()
                 index,
                 parameters.WithFixProviderData(pickMembersService),
                 expectedDiagnostics,
-                testExpectedDiagnostics,
                 fixedExpectedDiagnostics);
         }
 
@@ -178,7 +172,6 @@ internal static void EnableOption(ImmutableArray<PickMembersOption> options, str
             int index = 0,
             TestParameters? parameters = null,
             List<DiagnosticResult> expectedDiagnostics = null,
-            List<DiagnosticResult> testExpectedDiagnostics = null,
             List<DiagnosticResult> fixedExpectedDiagnostics = null)
         {
             var test = new Test
@@ -213,9 +206,6 @@ internal static void EnableOption(ImmutableArray<PickMembersOption> options, str
                 test.FixedState.ExpectedDiagnostics.Add(diagnostic);
             }
 
-            foreach (var diagnostic in testExpectedDiagnostics ?? new List<DiagnosticResult>())
-                test.TestState.ExpectedDiagnostics.Add(diagnostic);
-
             foreach (var diagnostic in fixedExpectedDiagnostics ?? new List<DiagnosticResult>())
                 test.FixedState.ExpectedDiagnostics.Add(diagnostic);