Address PR feedback

src/Compilers/Core/Portable/DiagnosticAnalyzer/AnalyzerManager.cs

@@ -19,8 +19,6 @@ namespace Microsoft.CodeAnalysis.Diagnostics
     /// </summary>
     internal partial class AnalyzerManager
     {
-        private readonly object _gate = new object();
-
         // This cache stores the analyzer execution context per-analyzer (i.e. registered actions, supported descriptors, etc.).
         private readonly ImmutableDictionary<DiagnosticAnalyzer, AnalyzerExecutionContext> _analyzerExecutionContextMap;
 

src/EditorFeatures/TestUtilities/Diagnostics/AbstractDiagnosticProviderBasedUserDiagnosticTest.cs

@@ -60,17 +60,15 @@ internal virtual (DiagnosticAnalyzer, CodeFixProvider) CreateDiagnosticProviderA
                 document = GetDocumentAndAnnotatedSpan(workspace, out annotation, out span);
             }
 
-            using (var testDriver = new TestDiagnosticAnalyzerDriver(document.Project, provider))
-            {
-                var diagnostics = await testDriver.GetAllDiagnosticsAsync(provider, document, span);
-                AssertNoAnalyzerExceptionDiagnostics(diagnostics);
+            var testDriver = new TestDiagnosticAnalyzerDriver(document.Project, provider);
+            var diagnostics = await testDriver.GetAllDiagnosticsAsync(provider, document, span);
+            AssertNoAnalyzerExceptionDiagnostics(diagnostics);
 
-                var fixer = providerAndFixer.Item2;
-                var ids = new HashSet<string>(fixer.FixableDiagnosticIds);
-                var dxs = diagnostics.Where(d => ids.Contains(d.Id)).ToList();
-                return await GetDiagnosticAndFixesAsync(
-                    dxs, provider, fixer, testDriver, document, span, annotation, parameters.fixAllActionEquivalenceKey);
-            }
+            var fixer = providerAndFixer.Item2;
+            var ids = new HashSet<string>(fixer.FixableDiagnosticIds);
+            var dxs = diagnostics.Where(d => ids.Contains(d.Id)).ToList();
+            return await GetDiagnosticAndFixesAsync(
+                dxs, provider, fixer, testDriver, document, span, annotation, parameters.fixAllActionEquivalenceKey);
         }
 
         protected async Task TestDiagnosticSeverityAndCountAsync(

src/EditorFeatures/TestUtilities/Diagnostics/AbstractSuppressionDiagnosticTest.cs

@@ -71,18 +71,16 @@ private ImmutableArray<Diagnostic> FilterDiagnostics(IEnumerable<Diagnostic> dia
                 document = GetDocumentAndAnnotatedSpan(workspace, out annotation, out span);
             }
 
-            using (var testDriver = new TestDiagnosticAnalyzerDriver(document.Project, provider, includeSuppressedDiagnostics: IncludeSuppressedDiagnostics))
-            {
-                var fixer = providerAndFixer.Item2;
-                var diagnostics = (await testDriver.GetAllDiagnosticsAsync(provider, document, span))
-                    .Where(d => fixer.CanBeSuppressedOrUnsuppressed(d));
+            var testDriver = new TestDiagnosticAnalyzerDriver(document.Project, provider, includeSuppressedDiagnostics: IncludeSuppressedDiagnostics);
+            var fixer = providerAndFixer.Item2;
+            var diagnostics = (await testDriver.GetAllDiagnosticsAsync(provider, document, span))
+                .Where(d => fixer.CanBeSuppressedOrUnsuppressed(d));
 
-                var filteredDiagnostics = FilterDiagnostics(diagnostics);
+            var filteredDiagnostics = FilterDiagnostics(diagnostics);
 
-                var wrapperCodeFixer = new WrapperCodeFixProvider(fixer, filteredDiagnostics.Select(d => d.Id));
-                return await GetDiagnosticAndFixesAsync(
-                    filteredDiagnostics, provider, wrapperCodeFixer, testDriver, document, span, annotation, parameters.fixAllActionEquivalenceKey);
-            }
+            var wrapperCodeFixer = new WrapperCodeFixProvider(fixer, filteredDiagnostics.Select(d => d.Id));
+            return await GetDiagnosticAndFixesAsync(
+                filteredDiagnostics, provider, wrapperCodeFixer, testDriver, document, span, annotation, parameters.fixAllActionEquivalenceKey);
         }
     }
 }

src/EditorFeatures/TestUtilities/Diagnostics/DiagnosticProviderTestUtilities.cs

@@ -12,18 +12,14 @@ public static class DiagnosticProviderTestUtilities
     {
         public static async Task<IEnumerable<Diagnostic>> GetAllDiagnosticsAsync(DiagnosticAnalyzer workspaceAnalyzerOpt, Document document, TextSpan span, Action<Exception, DiagnosticAnalyzer, Diagnostic> onAnalyzerException = null, bool logAnalyzerExceptionAsDiagnostics = false, bool includeSuppressedDiagnostics = false)
         {
-            using (var testDriver = new TestDiagnosticAnalyzerDriver(document.Project, workspaceAnalyzerOpt, onAnalyzerException, logAnalyzerExceptionAsDiagnostics, includeSuppressedDiagnostics))
-            {
-                return await testDriver.GetAllDiagnosticsAsync(workspaceAnalyzerOpt, document, span);
-            }
+            var testDriver = new TestDiagnosticAnalyzerDriver(document.Project, workspaceAnalyzerOpt, onAnalyzerException, logAnalyzerExceptionAsDiagnostics, includeSuppressedDiagnostics);
+            return await testDriver.GetAllDiagnosticsAsync(workspaceAnalyzerOpt, document, span);
         }
 
         public static async Task<IEnumerable<Diagnostic>> GetAllDiagnosticsAsync(DiagnosticAnalyzer workspaceAnalyzerOpt, Project project, Action<Exception, DiagnosticAnalyzer, Diagnostic> onAnalyzerException = null, bool logAnalyzerExceptionAsDiagnostics = false, bool includeSuppressedDiagnostics = false)
         {
-            using (var testDriver = new TestDiagnosticAnalyzerDriver(project, workspaceAnalyzerOpt, onAnalyzerException, logAnalyzerExceptionAsDiagnostics, includeSuppressedDiagnostics))
-            {
-                return await testDriver.GetAllDiagnosticsAsync(workspaceAnalyzerOpt, project);
-            }
+            var testDriver = new TestDiagnosticAnalyzerDriver(project, workspaceAnalyzerOpt, onAnalyzerException, logAnalyzerExceptionAsDiagnostics, includeSuppressedDiagnostics);
+            return await testDriver.GetAllDiagnosticsAsync(workspaceAnalyzerOpt, project);
         }
 
         public static async Task<IEnumerable<Diagnostic>> GetAllDiagnosticsAsync(DiagnosticAnalyzer workspaceAnalyzerOpt, Solution solution, Action<Exception, DiagnosticAnalyzer, Diagnostic> onAnalyzerException = null, bool logAnalyzerExceptionAsDiagnostics = false, bool includeSuppressedDiagnostics = false)
@@ -40,18 +36,14 @@ public static async Task<IEnumerable<Diagnostic>> GetAllDiagnosticsAsync(Diagnos
 
         public static async Task<IEnumerable<Diagnostic>> GetDocumentDiagnosticsAsync(DiagnosticAnalyzer workspaceAnalyzerOpt, Document document, TextSpan span, Action<Exception, DiagnosticAnalyzer, Diagnostic> onAnalyzerException = null, bool logAnalyzerExceptionAsDiagnostics = false, bool includeSuppressedDiagnostics = false)
         {
-            using (var testDriver = new TestDiagnosticAnalyzerDriver(document.Project, workspaceAnalyzerOpt, onAnalyzerException, logAnalyzerExceptionAsDiagnostics, includeSuppressedDiagnostics))
-            {
-                return await testDriver.GetDocumentDiagnosticsAsync(workspaceAnalyzerOpt, document, span);
-            }
+            var testDriver = new TestDiagnosticAnalyzerDriver(document.Project, workspaceAnalyzerOpt, onAnalyzerException, logAnalyzerExceptionAsDiagnostics, includeSuppressedDiagnostics);
+            return await testDriver.GetDocumentDiagnosticsAsync(workspaceAnalyzerOpt, document, span);
         }
 
         public static async Task<IEnumerable<Diagnostic>> GetProjectDiagnosticsAsync(DiagnosticAnalyzer workspaceAnalyzerOpt, Project project, Action<Exception, DiagnosticAnalyzer, Diagnostic> onAnalyzerException = null, bool logAnalyzerExceptionAsDiagnostics = false, bool includeSuppressedDiagnostics = false)
         {
-            using (var testDriver = new TestDiagnosticAnalyzerDriver(project, workspaceAnalyzerOpt, onAnalyzerException, logAnalyzerExceptionAsDiagnostics, includeSuppressedDiagnostics))
-            {
-                return await testDriver.GetProjectDiagnosticsAsync(workspaceAnalyzerOpt, project);
-            }
+            var testDriver = new TestDiagnosticAnalyzerDriver(project, workspaceAnalyzerOpt, onAnalyzerException, logAnalyzerExceptionAsDiagnostics, includeSuppressedDiagnostics);
+            return await testDriver.GetProjectDiagnosticsAsync(workspaceAnalyzerOpt, project);
         }
     }
 }

src/EditorFeatures/TestUtilities/Diagnostics/TestDiagnosticAnalyzerDriver.cs

@@ -14,7 +14,7 @@
 
 namespace Microsoft.CodeAnalysis.UnitTests.Diagnostics
 {
-    public class TestDiagnosticAnalyzerDriver : IDisposable
+    public class TestDiagnosticAnalyzerDriver
     {
         private readonly ImmutableArray<DiagnosticAnalyzer> _workspaceAnalyzers;
         private readonly TestDiagnosticAnalyzerService _diagnosticAnalyzerService;
@@ -113,9 +113,5 @@ public Task<IEnumerable<Diagnostic>> GetProjectDiagnosticsAsync(DiagnosticAnalyz
         {
             return GetDiagnosticsAsync(workspaceAnalyzerOpt, null, default(TextSpan), project, getDocumentDiagnostics: false, getProjectDiagnostics: true);
         }
-
-        public void Dispose()
-        {
-        }
     }
 }