提交 c87aee8f 编写于 作者: H Heejae Chang

PR feedback on removing unnecessary method

上级 897a3497
......@@ -88,14 +88,30 @@ public Checksum CreateChecksum(AnalyzerReference reference, CancellationToken ca
{
cancellationToken.ThrowIfCancellationRequested();
switch (reference)
using (var stream = SerializableBytes.CreateWritableStream())
using (var writer = new ObjectWriter(stream, cancellationToken: cancellationToken))
{
case AnalyzerFileReference _:
case UnresolvedAnalyzerReference _:
return CreateAnalyzerReferenceChecksum(reference, cancellationToken);
switch (reference)
{
case AnalyzerFileReference file:
WriteAnalyzerFileReferenceMvid(file, writer, cancellationToken);
break;
default:
throw ExceptionUtilities.UnexpectedValue(reference.GetType());
case UnresolvedAnalyzerReference unresolved:
WriteUnresolvedAnalyzerReferenceTo(unresolved, writer);
break;
case AnalyzerImageReference _:
// TODO: think a way to support this or a way to deal with this kind of situation.
// https://github.com/dotnet/roslyn/issues/15783
throw new NotSupportedException(nameof(AnalyzerImageReference));
default:
throw ExceptionUtilities.UnexpectedValue(reference.GetType());
}
stream.Position = 0;
return Checksum.Create(stream);
}
}
......@@ -206,27 +222,6 @@ public AnalyzerReference ReadAnalyzerReferenceFrom(ObjectReader reader, Cancella
throw ExceptionUtilities.UnexpectedValue(type);
}
private Checksum CreateAnalyzerReferenceChecksum(AnalyzerReference reference, CancellationToken cancellationToken)
{
using (var stream = SerializableBytes.CreateWritableStream())
using (var writer = new ObjectWriter(stream, cancellationToken: cancellationToken))
{
switch (reference)
{
case AnalyzerFileReference file:
WriteAnalyzerFileReferenceMvid(file, writer, cancellationToken);
break;
case UnresolvedAnalyzerReference unresolved:
WriteUnresolvedAnalyzerReferenceTo(reference, writer);
break;
}
stream.Position = 0;
return Checksum.Create(stream);
}
}
private void WriteAnalyzerFileReferenceMvid(AnalyzerFileReference reference, ObjectWriter writer, CancellationToken cancellationToken)
{
try
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册