Merge pull request #10304 from eriawan/master

Mark ParseOptions.CommonWithKind with attribute of EditorBrowsableState.Never

src/Compilers/Core/Portable/Compilation/ParseOptions.cs

@@ -2,6 +2,7 @@
 
 using System;
 using System.Collections.Generic;
+using System.ComponentModel;
 using System.Linq;
 using Roslyn.Utilities;
 
@@ -37,6 +38,10 @@ public ParseOptions WithKind(SourceCodeKind kind)
             return CommonWithKind(kind);
         }
 
+        // It was supposed to be a protected implementation detail. 
+        // The "pattern" we have for these is the public With* method is the only public callable one, 
+        // and that forwards to the protected Common* like all the other methods in the class. 
+        [EditorBrowsable(EditorBrowsableState.Never)]
         public abstract ParseOptions CommonWithKind(SourceCodeKind kind);
 
         /// <summary>