Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
lwm1986
roslyn
提交
c606a541
R
roslyn
项目概览
lwm1986
/
roslyn
与 Fork 源项目一致
从无法访问的项目Fork
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
DevOps
流水线
流水线任务
计划
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
roslyn
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
DevOps
DevOps
流水线
流水线任务
计划
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
流水线任务
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
c606a541
编写于
10月 09, 2018
作者:
M
Manish Vasani
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Fix the core issue reported in #30397.
上级
a80c765d
变更
2
隐藏空白更改
内联
并排
Showing
2 changed file
with
5 addition
and
2 deletion
+5
-2
src/EditorFeatures/CSharpTest/RemoveUnusedMembers/RemoveUnusedMembersTests.cs
...SharpTest/RemoveUnusedMembers/RemoveUnusedMembersTests.cs
+3
-0
src/Features/Core/Portable/RemoveUnusedMembers/AbstractRemoveUnusedMembersDiagnosticAnalyzer.cs
...dMembers/AbstractRemoveUnusedMembersDiagnosticAnalyzer.cs
+2
-2
未找到文件。
src/EditorFeatures/CSharpTest/RemoveUnusedMembers/RemoveUnusedMembersTests.cs
浏览文件 @
c606a541
...
@@ -6,6 +6,7 @@
...
@@ -6,6 +6,7 @@
using
Microsoft.CodeAnalysis.Diagnostics
;
using
Microsoft.CodeAnalysis.Diagnostics
;
using
Microsoft.CodeAnalysis.Editor.CSharp.UnitTests.Diagnostics
;
using
Microsoft.CodeAnalysis.Editor.CSharp.UnitTests.Diagnostics
;
using
Microsoft.CodeAnalysis.Test.Utilities
;
using
Microsoft.CodeAnalysis.Test.Utilities
;
using
Roslyn.Test.Utilities
;
using
Xunit
;
using
Xunit
;
using
static
Roslyn
.
Test
.
Utilities
.
TestHelpers
;
using
static
Roslyn
.
Test
.
Utilities
.
TestHelpers
;
...
@@ -1076,6 +1077,7 @@ int Goo
...
@@ -1076,6 +1077,7 @@ int Goo
}
}
[
Fact
,
Trait
(
Traits
.
Feature
,
Traits
.
Features
.
CodeActionsRemoveUnusedMembers
)]
[
Fact
,
Trait
(
Traits
.
Feature
,
Traits
.
Features
.
CodeActionsRemoveUnusedMembers
)]
[
WorkItem
(
30397
,
"https://github.com/dotnet/roslyn/issues/30397"
)]
public
async
Task
FieldIsIncrementedAndValueUsed
()
public
async
Task
FieldIsIncrementedAndValueUsed
()
{
{
await
TestDiagnosticMissingAsync
(
await
TestDiagnosticMissingAsync
(
...
@@ -1087,6 +1089,7 @@ public async Task FieldIsIncrementedAndValueUsed()
...
@@ -1087,6 +1089,7 @@ public async Task FieldIsIncrementedAndValueUsed()
}
}
[
Fact
,
Trait
(
Traits
.
Feature
,
Traits
.
Features
.
CodeActionsRemoveUnusedMembers
)]
[
Fact
,
Trait
(
Traits
.
Feature
,
Traits
.
Features
.
CodeActionsRemoveUnusedMembers
)]
[
WorkItem
(
30397
,
"https://github.com/dotnet/roslyn/issues/30397"
)]
public
async
Task
FieldIsIncrementedAndValueUsed_02
()
public
async
Task
FieldIsIncrementedAndValueUsed_02
()
{
{
await
TestDiagnosticMissingAsync
(
await
TestDiagnosticMissingAsync
(
...
...
src/Features/Core/Portable/RemoveUnusedMembers/AbstractRemoveUnusedMembersDiagnosticAnalyzer.cs
浏览文件 @
c606a541
...
@@ -194,7 +194,7 @@ private void AnalyzeMemberReferenceOperation(OperationAnalysisContext operationC
...
@@ -194,7 +194,7 @@ private void AnalyzeMemberReferenceOperation(OperationAnalysisContext operationC
compoundAssignment
.
Target
==
memberReference
||
compoundAssignment
.
Target
==
memberReference
||
memberReference
.
Parent
is
IIncrementOrDecrementOperation
);
memberReference
.
Parent
is
IIncrementOrDecrementOperation
);
// Compound assignment or increment whose value is being dropped (parent
has null type
)
// Compound assignment or increment whose value is being dropped (parent
is an expression statement
)
// is treated as a Write as the value was never actually 'read' in a way that is observable.
// is treated as a Write as the value was never actually 'read' in a way that is observable.
//
//
// Consider the following example:
// Consider the following example:
...
@@ -209,7 +209,7 @@ private void AnalyzeMemberReferenceOperation(OperationAnalysisContext operationC
...
@@ -209,7 +209,7 @@ private void AnalyzeMemberReferenceOperation(OperationAnalysisContext operationC
// while the increment operation '_f2++' is child of a return statement, which uses the result of the increment.
// while the increment operation '_f2++' is child of a return statement, which uses the result of the increment.
// For the above test, '_f1' can be safely removed without affecting the semantics of the program, while '_f2' cannot be removed.
// For the above test, '_f1' can be safely removed without affecting the semantics of the program, while '_f2' cannot be removed.
if
(
memberReference
.
Parent
.
Parent
?.
Type
==
null
)
if
(
memberReference
.
Parent
.
Parent
is
IExpressionStatementOperation
)
{
{
valueUsageInfo
=
ValueUsageInfo
.
Write
;
valueUsageInfo
=
ValueUsageInfo
.
Write
;
}
}
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录