Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
lwm1986
roslyn
提交
c59d431f
R
roslyn
项目概览
lwm1986
/
roslyn
与 Fork 源项目一致
从无法访问的项目Fork
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
DevOps
流水线
流水线任务
计划
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
roslyn
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
DevOps
DevOps
流水线
流水线任务
计划
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
流水线任务
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
c59d431f
编写于
2月 20, 2017
作者:
C
CyrusNajmabadi
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Update Coalesce-for-nullables as well.
上级
a15adaa2
变更
3
隐藏空白更改
内联
并排
Showing
3 changed file
with
44 addition
and
6 deletion
+44
-6
src/EditorFeatures/CSharpTest/UseCoalesceExpression/UseCoalesceExpressionForNullableTests.cs
...alesceExpression/UseCoalesceExpressionForNullableTests.cs
+27
-0
src/EditorFeatures/VisualBasicTest/UseCoalesceExpression/UseCoalesceExpressionTests.vb
...cTest/UseCoalesceExpression/UseCoalesceExpressionTests.vb
+2
-2
src/Features/Core/Portable/UseCoalesceExpression/UseCoalesceExpressionForNullableCodeFixProvider.cs
...ession/UseCoalesceExpressionForNullableCodeFixProvider.cs
+15
-4
未找到文件。
src/EditorFeatures/CSharpTest/UseCoalesceExpression/UseCoalesceExpressionForNullableTests.cs
浏览文件 @
c59d431f
...
...
@@ -184,6 +184,33 @@ void M(int? x, int? y, int? z)
{
var w = x ?? y ?? z;
}
}"
);
}
[
WorkItem
(
17028
,
"https://github.com/dotnet/roslyn/issues/17028"
)]
[
Fact
,
Trait
(
Traits
.
Feature
,
Traits
.
Features
.
CodeActionsUseCoalesceExpression
)]
public
async
Task
TestInExpressionOfT
()
{
await
TestAsync
(
@"using System;
using System.Linq.Expressions;
class C
{
void M(int? x, int? y)
{
Expression<Func<int>> e = () => [||]!x.HasValue ? y : x.Value;
}
}"
,
@"using System;
using System.Linq.Expressions;
class C
{
void M(int? x, int? y)
{
Expression<Func<int>> e = () => {|Warning:x ?? y|};
}
}"
);
}
}
...
...
src/EditorFeatures/VisualBasicTest/UseCoalesceExpression/UseCoalesceExpressionTests.vb
浏览文件 @
c59d431f
...
...
@@ -247,7 +247,7 @@ Imports System.Linq.Expressions
Class C
Sub M(x as string, y as string)
dim e as Expression(of Func(of string)) = [||]If (x isnot Nothing, x, y)
dim e as Expression(of Func(of string)) =
func()
[||]If (x isnot Nothing, x, y)
End Sub
End Class"
,
"Imports System
...
...
@@ -255,7 +255,7 @@ Imports System.Linq.Expressions
Class C
Sub M(x as string, y as string, z as string)
dim e as Expression(of Func(of string)) = If (x, y)
dim e as Expression(of Func(of string)) =
func ()
If (x, y)
End Sub
End Class"
)
End
Function
...
...
src/Features/Core/Portable/UseCoalesceExpression/UseCoalesceExpressionForNullableCodeFixProvider.cs
浏览文件 @
c59d431f
...
...
@@ -33,11 +33,15 @@ public override Task RegisterCodeFixesAsync(CodeFixContext context)
return
SpecializedTasks
.
EmptyTask
;
}
protected
override
Task
FixAllAsync
(
protected
override
async
Task
FixAllAsync
(
Document
document
,
ImmutableArray
<
Diagnostic
>
diagnostics
,
SyntaxEditor
editor
,
CancellationToken
cancellationToken
)
{
var
semanticModel
=
await
document
.
GetSemanticModelAsync
(
cancellationToken
).
ConfigureAwait
(
false
);
var
expressionTypeOpt
=
semanticModel
.
Compilation
.
GetTypeByMetadataName
(
"System.Linq.Expressions.Expression`1"
);
var
syntaxFacts
=
document
.
GetLanguageService
<
ISyntaxFactsService
>();
var
semanticFacts
=
document
.
GetLanguageService
<
ISemanticFactsService
>();
var
generator
=
editor
.
Generator
;
var
root
=
editor
.
OriginalRoot
;
...
...
@@ -54,13 +58,20 @@ public override Task RegisterCodeFixesAsync(CodeFixContext context)
syntaxFacts
.
GetPartsOfConditionalExpression
(
c
,
out
var
currentCondition
,
out
var
currentWhenTrue
,
out
var
currentWhenFalse
);
return
whenPart
==
whenTrue
var
coalesceExpression
=
whenPart
==
whenTrue
?
g
.
CoalesceExpression
(
conditionExpression
,
syntaxFacts
.
WalkDownParentheses
(
currentWhenTrue
))
:
g
.
CoalesceExpression
(
conditionExpression
,
syntaxFacts
.
WalkDownParentheses
(
currentWhenFalse
));
if
(
semanticFacts
.
IsInExpressionTree
(
semanticModel
,
conditionalExpression
,
expressionTypeOpt
,
cancellationToken
))
{
coalesceExpression
=
coalesceExpression
.
WithAdditionalAnnotations
(
WarningAnnotation
.
Create
(
FeaturesResources
.
Changes_to_expression_trees_may_result_in_behavior_changes_at_runtime
));
}
return
coalesceExpression
;
});
}
return
SpecializedTasks
.
EmptyTask
;
}
private
class
MyCodeAction
:
CodeAction
.
DocumentChangeAction
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录