Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
lwm1986
roslyn
提交
c0c192da
R
roslyn
项目概览
lwm1986
/
roslyn
与 Fork 源项目一致
从无法访问的项目Fork
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
DevOps
流水线
流水线任务
计划
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
roslyn
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
DevOps
DevOps
流水线
流水线任务
计划
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
流水线任务
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
未验证
提交
c0c192da
编写于
6月 14, 2020
作者:
C
CyrusNajmabadi
提交者:
GitHub
6月 14, 2020
浏览文件
操作
浏览文件
下载
差异文件
Merge pull request #45150 from Kuinox/master
Fix MakeMethodAsynchronous on ValueTask without generics.
上级
8c3d23d3
fa1edb0c
变更
3
隐藏空白更改
内联
并排
Showing
3 changed file
with
48 addition
and
0 deletion
+48
-0
src/EditorFeatures/CSharpTest/Diagnostics/MakeMethodAsynchronous/MakeMethodAsynchronousTests.cs
...ics/MakeMethodAsynchronous/MakeMethodAsynchronousTests.cs
+41
-0
src/Features/Core/Portable/MakeMethodAsynchronous/AbstractMakeMethodAsynchronousCodeFixProvider.KnownTypes.cs
...stractMakeMethodAsynchronousCodeFixProvider.KnownTypes.cs
+2
-0
src/Features/Core/Portable/MakeMethodAsynchronous/AbstractMakeMethodAsynchronousCodeFixProvider.cs
...chronous/AbstractMakeMethodAsynchronousCodeFixProvider.cs
+5
-0
未找到文件。
src/EditorFeatures/CSharpTest/Diagnostics/MakeMethodAsynchronous/MakeMethodAsynchronousTests.cs
浏览文件 @
c0c192da
...
...
@@ -959,6 +959,47 @@ async ValueTask<int> Test()
await
TestInRegularAndScriptAsync
(
initial
,
expected
);
}
[
Fact
,
Trait
(
Traits
.
Feature
,
Traits
.
Features
.
CodeActionsMakeMethodAsynchronous
)]
public
async
Task
AwaitInValueTaskWithoutGenericMethod
()
{
var
initial
=
@"using System;
using System.Threading.Tasks;
namespace System.Threading.Tasks {
struct ValueTask
{
}
}
class Program
{
ValueTask Test()
{
[|await Task.Delay(1);|]
}
}"
;
var
expected
=
@"using System;
using System.Threading.Tasks;
namespace System.Threading.Tasks {
struct ValueTask
{
}
}
class Program
{
async ValueTask Test()
{
await Task.Delay(1);
}
}"
;
await
TestInRegularAndScriptAsync
(
initial
,
expected
);
}
[
Fact
,
Trait
(
Traits
.
Feature
,
Traits
.
Features
.
CodeActionsMakeMethodAsynchronous
)]
[
WorkItem
(
14133
,
"https://github.com/dotnet/roslyn/issues/14133"
)]
public
async
Task
AddAsyncInLocalFunction
()
...
...
src/Features/Core/Portable/MakeMethodAsynchronous/AbstractMakeMethodAsynchronousCodeFixProvider.KnownTypes.cs
浏览文件 @
c0c192da
...
...
@@ -12,6 +12,7 @@ internal abstract partial class AbstractMakeMethodAsynchronousCodeFixProvider
{
public
readonly
INamedTypeSymbol
_taskType
;
public
readonly
INamedTypeSymbol
_taskOfTType
;
public
readonly
INamedTypeSymbol
_valueTaskType
;
public
readonly
INamedTypeSymbol
_valueTaskOfTTypeOpt
;
public
readonly
INamedTypeSymbol
_iEnumerableOfTType
;
...
...
@@ -24,6 +25,7 @@ internal KnownTypes(Compilation compilation)
{
_taskType
=
compilation
.
TaskType
();
_taskOfTType
=
compilation
.
TaskOfTType
();
_valueTaskType
=
compilation
.
ValueTaskType
();
_valueTaskOfTTypeOpt
=
compilation
.
ValueTaskOfTType
();
_iEnumerableOfTType
=
compilation
.
IEnumerableOfTType
();
...
...
src/Features/Core/Portable/MakeMethodAsynchronous/AbstractMakeMethodAsynchronousCodeFixProvider.cs
浏览文件 @
c0c192da
...
...
@@ -204,6 +204,11 @@ protected static bool IsTaskLike(ITypeSymbol returnType, KnownTypes knownTypes)
return
true
;
}
if
(
returnType
.
Equals
(
knownTypes
.
_valueTaskType
))
{
return
true
;
}
if
(
returnType
.
OriginalDefinition
.
Equals
(
knownTypes
.
_taskOfTType
))
{
return
true
;
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录