Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
lwm1986
roslyn
提交
c02c14d3
R
roslyn
项目概览
lwm1986
/
roslyn
与 Fork 源项目一致
从无法访问的项目Fork
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
DevOps
流水线
流水线任务
计划
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
roslyn
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
DevOps
DevOps
流水线
流水线任务
计划
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
流水线任务
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
c02c14d3
编写于
7月 12, 2017
作者:
V
Victor Zaytsev
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Fixed review notes.
上级
222bc66f
变更
3
隐藏空白更改
内联
并排
Showing
3 changed file
with
9 addition
and
16 deletion
+9
-16
src/Features/CSharp/Portable/Diagnostics/Analyzers/CSharpTypeStyleDiagnosticAnalyzerBase.cs
...ostics/Analyzers/CSharpTypeStyleDiagnosticAnalyzerBase.cs
+9
-14
src/Features/CSharp/Portable/Diagnostics/Analyzers/CSharpUseExplicitTypeDiagnosticAnalyzer.cs
...tics/Analyzers/CSharpUseExplicitTypeDiagnosticAnalyzer.cs
+0
-1
src/Features/CSharp/Portable/Diagnostics/Analyzers/CSharpUseImplicitTypeDiagnosticAnalyzer.cs
...tics/Analyzers/CSharpUseImplicitTypeDiagnosticAnalyzer.cs
+0
-1
未找到文件。
src/Features/CSharp/Portable/Diagnostics/Analyzers/CSharpTypeStyleDiagnosticAnalyzerBase.cs
浏览文件 @
c02c14d3
...
...
@@ -38,7 +38,7 @@ public override bool OpenFileOnly(Workspace workspace)
protected
override
void
InitializeWorker
(
AnalysisContext
context
)
=>
context
.
RegisterSyntaxNodeAction
(
HandleVariableDeclaration
,
SyntaxKind
.
VariableDeclaration
,
SyntaxKind
.
ForEachStatement
,
SyntaxKind
.
Argument
);
HandleVariableDeclaration
,
SyntaxKind
.
VariableDeclaration
,
SyntaxKind
.
ForEachStatement
,
SyntaxKind
.
DeclarationExpression
);
protected
abstract
bool
IsStylePreferred
(
SemanticModel
semanticModel
,
OptionSet
optionSet
,
State
state
,
CancellationToken
cancellationToken
);
protected
abstract
bool
TryAnalyzeVariableDeclaration
(
TypeSyntax
typeName
,
SemanticModel
semanticModel
,
OptionSet
optionSet
,
CancellationToken
cancellationToken
,
out
TextSpan
issueSpan
);
...
...
@@ -92,22 +92,17 @@ private void HandleVariableDeclaration(SyntaxNodeAnalysisContext context)
shouldAnalyze
=
IsStylePreferred
(
semanticModel
,
optionSet
,
state
,
cancellationToken
);
}
}
else
if
(
declarationStatement
.
IsKind
(
SyntaxKind
.
Argument
))
else
if
(
declarationStatement
.
IsKind
(
SyntaxKind
.
DeclarationExpression
))
{
shouldAnalyze
=
false
;
declaredType
=
null
;
if
((
declarationStatement
as
ArgumentSyntax
)?.
Expression
is
DeclarationExpressionSyntax
declaration
)
{
declaredType
=
declaration
.
Type
;
var
declaration
=
(
DeclarationExpressionSyntax
)
declarationStatement
;
declaredType
=
declaration
.
Type
;
shouldAnalyze
=
ShouldAnalyzeDeclarationExpression
(
declaration
,
semanticModel
,
cancellationToken
);
shouldAnalyze
=
ShouldAnalyzeDeclarationExpression
(
declaration
,
semanticModel
,
cancellationToken
);
if
(
shouldAnalyze
)
{
state
=
State
.
Generate
(
declarationStatement
,
semanticModel
,
optionSet
,
isVariableDeclarationContext
:
false
,
cancellationToken
:
cancellationToken
);
shouldAnalyze
=
IsStylePreferred
(
semanticModel
,
optionSet
,
state
,
cancellationToken
);
}
if
(
shouldAnalyze
)
{
state
=
State
.
Generate
(
declarationStatement
,
semanticModel
,
optionSet
,
isVariableDeclarationContext
:
true
,
cancellationToken
:
cancellationToken
);
shouldAnalyze
=
IsStylePreferred
(
semanticModel
,
optionSet
,
state
,
cancellationToken
);
}
}
else
...
...
src/Features/CSharp/Portable/Diagnostics/Analyzers/CSharpUseExplicitTypeDiagnosticAnalyzer.cs
浏览文件 @
c02c14d3
...
...
@@ -154,7 +154,6 @@ protected override bool ShouldAnalyzeDeclarationExpression(DeclarationExpression
}
// The base analyzer may impose further limitations
return
base
.
ShouldAnalyzeDeclarationExpression
(
declaration
,
semanticModel
,
cancellationToken
);
}
}
...
...
src/Features/CSharp/Portable/Diagnostics/Analyzers/CSharpUseImplicitTypeDiagnosticAnalyzer.cs
浏览文件 @
c02c14d3
...
...
@@ -197,7 +197,6 @@ protected override bool ShouldAnalyzeDeclarationExpression(DeclarationExpression
}
// The base analyzer may impose further limitations
return
base
.
ShouldAnalyzeDeclarationExpression
(
declaration
,
semanticModel
,
cancellationToken
);
}
}
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录