Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
lwm1986
roslyn
提交
bd3db2ed
R
roslyn
项目概览
lwm1986
/
roslyn
与 Fork 源项目一致
从无法访问的项目Fork
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
DevOps
流水线
流水线任务
计划
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
roslyn
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
DevOps
DevOps
流水线
流水线任务
计划
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
流水线任务
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
未验证
提交
bd3db2ed
编写于
3月 12, 2019
作者:
J
Julien Couvreur
提交者:
GitHub
3月 12, 2019
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Warn on locking null (#34004)
上级
651eda80
变更
2
隐藏空白更改
内联
并排
Showing
2 changed file
with
48 addition
and
0 deletion
+48
-0
src/Compilers/CSharp/Portable/FlowAnalysis/NullableWalker.cs
src/Compilers/CSharp/Portable/FlowAnalysis/NullableWalker.cs
+8
-0
src/Compilers/CSharp/Test/Semantic/Semantics/NullableReferenceTypesTests.cs
...rp/Test/Semantic/Semantics/NullableReferenceTypesTests.cs
+40
-0
未找到文件。
src/Compilers/CSharp/Portable/FlowAnalysis/NullableWalker.cs
浏览文件 @
bd3db2ed
...
...
@@ -5667,6 +5667,14 @@ protected override void VisitCatchBlock(BoundCatchBlock node, ref LocalState fin
base
.
VisitCatchBlock
(
node
,
ref
finallyState
);
}
public
override
BoundNode
VisitLockStatement
(
BoundLockStatement
node
)
{
VisitRvalue
(
node
.
Argument
);
CheckPossibleNullReceiver
(
node
.
Argument
);
VisitStatement
(
node
.
Body
);
return
null
;
}
protected
override
string
Dump
(
LocalState
state
)
{
if
(!
state
.
Reachable
)
...
...
src/Compilers/CSharp/Test/Semantic/Semantics/NullableReferenceTypesTests.cs
浏览文件 @
bd3db2ed
...
...
@@ -243,6 +243,46 @@ static void M<T>(int i, Missing m, string s, T t)
);
}
[Fact, WorkItem(26810, "https://github.com/dotnet/roslyn/issues/26810")]
public void LockStatement()
{
var comp = CreateCompilation(@"
class C
{
void F(object? maybeNull, object nonNull, Missing? annotatedMissing, Missing unannotatedMissing)
{
lock (maybeNull) { }
lock (nonNull) { }
lock (annotatedMissing) { }
lock (unannotatedMissing) { }
}
#nullable disable
void F(object oblivious, Missing obliviousMissing)
#nullable enable
{
lock (oblivious) { }
lock (obliviousMissing) { }
}
}", options: WithNonNullTypesTrue());
comp.VerifyDiagnostics(
// (4,47): error CS0246: The type or namespace name 'Missing' could not be found (are you missing a using directive or an assembly reference?)
// void F(object? maybeNull, object nonNull, Missing? annotatedMissing, Missing unannotatedMissing)
Diagnostic(ErrorCode.ERR_SingleTypeNameNotFound, "Missing").WithArguments("Missing").WithLocation(4, 47),
// (4,74): error CS0246: The type or namespace name 'Missing' could not be found (are you missing a using directive or an assembly reference?)
// void F(object? maybeNull, object nonNull, Missing? annotatedMissing, Missing unannotatedMissing)
Diagnostic(ErrorCode.ERR_SingleTypeNameNotFound, "Missing").WithArguments("Missing").WithLocation(4, 74),
// (6,15): warning CS8602: Possible dereference of a null reference.
// lock (maybeNull) { }
Diagnostic(ErrorCode.WRN_NullReferenceReceiver, "maybeNull").WithLocation(6, 15),
// (8,15): error CS0185: 'Missing?' is not a reference type as required by the lock statement
// lock (annotatedMissing) { }
Diagnostic(ErrorCode.ERR_LockNeedsReference, "annotatedMissing").WithArguments("Missing?").WithLocation(8, 15),
// (12,30): error CS0246: The type or namespace name 'Missing' could not be found (are you missing a using directive or an assembly reference?)
// void F(object oblivious, Missing obliviousMissing)
Diagnostic(ErrorCode.ERR_SingleTypeNameNotFound, "Missing").WithArguments("Missing").WithLocation(12, 30)
);
}
[Fact, WorkItem(33537, "https://github.com/dotnet/roslyn/issues/33537")]
public void SuppressOnNullLiteralInAs()
{
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录