Merge pull request #19621 from VSadov/IsRefStruct2

CR feedback on ref structs

src/Compilers/CSharp/Portable/Symbols/AnonymousTypes/PublicSymbols/AnonymousType.TypePublicSymbol.cs

@@ -185,6 +185,11 @@ public override bool IsAbstract
                 get { return false; }
             }
 
+            internal sealed override bool IsByRefLikeType
+            {
+                get { return false;  }
+            }
+
             public override bool IsSealed
             {
                 get { return true; }

src/Compilers/CSharp/Portable/Symbols/AnonymousTypes/SynthesizedSymbols/AnonymousType.TemplateSymbol.cs

@@ -300,6 +300,11 @@ public override bool IsAbstract
                 get { return false; }
             }
 
+            internal sealed override bool IsByRefLikeType
+            {
+                get { return false; }
+            }
+
             public override bool IsSealed
             {
                 get { return true; }

src/Compilers/CSharp/Portable/Symbols/ArrayTypeSymbol.cs

@@ -241,6 +241,14 @@ internal sealed override bool IsManagedType
             }
         }
 
+        internal sealed override bool IsByRefLikeType
+        {
+            get
+            {
+                return false;
+            }
+        }
+
         internal sealed override ObsoleteAttributeData ObsoleteAttributeData
         {
             get { return null; }

src/Compilers/CSharp/Portable/Symbols/DynamicTypeSymbol.cs

@@ -115,6 +115,14 @@ internal sealed override bool IsManagedType
             }
         }
 
+        internal sealed override bool IsByRefLikeType
+        {
+            get
+            {
+                return false;
+            }
+        }
+
         internal sealed override ObsoleteAttributeData ObsoleteAttributeData
         {
             get { return null; }

src/Compilers/CSharp/Portable/Symbols/ErrorTypeSymbol.cs

@@ -103,6 +103,14 @@ public override bool IsValueType
             get { return false; }
         }
 
+        internal sealed override bool IsByRefLikeType
+        {
+            get
+            {
+                return false;
+            }
+        }
+
         /// <summary>
         /// Collection of names of members declared within this type.
         /// </summary>

src/Compilers/CSharp/Portable/Symbols/PointerTypeSymbol.cs

@@ -128,6 +128,14 @@ internal sealed override bool IsManagedType
             }
         }
 
+        internal sealed override bool IsByRefLikeType
+        {
+            get
+            {
+                return false;
+            }
+        }
+
         internal sealed override ObsoleteAttributeData ObsoleteAttributeData
         {
             get { return null; }

src/Compilers/CSharp/Portable/Symbols/Synthesized/SynthesizedContainer.cs

@@ -162,6 +162,8 @@ internal override IEnumerable<FieldSymbol> GetFieldsToEmit()
 
         public override bool IsStatic => false;
 
+        internal sealed override bool IsByRefLikeType => false;
+
         internal override ImmutableArray<NamedTypeSymbol> InterfacesNoUseSiteDiagnostics(ConsList<Symbol> basesBeingResolved) => ImmutableArray<NamedTypeSymbol>.Empty;
 
         internal override ImmutableArray<NamedTypeSymbol> GetInterfacesToEmit() => CalculateInterfacesToEmit();

src/Compilers/CSharp/Portable/Symbols/TypeParameterSymbol.cs

@@ -477,6 +477,14 @@ internal sealed override bool IsManagedType
             }
         }
 
+        internal sealed override bool IsByRefLikeType
+        {
+            get
+            {
+                return false;
+            }
+        }
+
         internal sealed override ObsoleteAttributeData ObsoleteAttributeData
         {
             get { return null; }

src/Compilers/CSharp/Portable/Symbols/TypeSymbol.cs

@@ -642,7 +642,7 @@ public virtual NamedTypeSymbol TupleUnderlyingType
         /// <summary>
         /// Returns true if the type may contain embedded references
         /// </summary>
-        internal virtual bool IsByRefLikeType => false;
+        internal abstract bool IsByRefLikeType { get; }
 
         #region ITypeSymbol Members
 

src/Compilers/CSharp/Test/Symbol/Symbols/MockNamedTypeSymbol.cs

@@ -194,6 +194,14 @@ public override bool IsStatic
             }
         }
 
+        internal sealed override bool IsByRefLikeType
+        {
+            get
+            {
+                return false;
+            }
+        }
+
         public override bool IsAbstract
         {
             get

src/Compilers/Core/Portable/WellKnownMembers.cs

@@ -3289,7 +3289,6 @@ internal static bool IsSynthesizedAttributeOptional(WellKnownMember attributeMem
                 case WellKnownMember.System_STAThreadAttribute__ctor:
                 case WellKnownMember.System_Runtime_CompilerServices_AsyncStateMachineAttribute__ctor:
                 case WellKnownMember.System_Runtime_CompilerServices_IteratorStateMachineAttribute__ctor:
-                case WellKnownMember.System_Runtime_CompilerServices_IsByRefLikeAttribute__ctor:
                     return true;
 
                 default:

src/ExpressionEvaluator/CSharp/Source/ExpressionCompiler/Symbols/EENamedTypeSymbol.cs

@@ -318,6 +318,11 @@ public override bool IsAbstract
             get { return false; }
         }
 
+        internal sealed override bool IsByRefLikeType
+        {
+            get { return false; }
+        }
+
         public override bool IsSealed
         {
             get { return true; }