CR feedback

src/Compilers/CSharp/Portable/Symbols/Source/SourceNamedTypeSymbol.cs

@@ -1136,7 +1136,7 @@ internal override void AddSynthesizedAttributes(PEModuleBuilder moduleBuilder, r
                 {
                     AddSynthesizedAttribute(ref attributes, compilation.TrySynthesizeAttribute(WellKnownMember.System_ObsoleteAttribute__ctor,
                         ImmutableArray.Create(
-                                       new TypedConstant(compilation.GetSpecialType(SpecialType.System_String), TypedConstantKind.Primitive, PEModule.byRefLikeMarker),
+                                       new TypedConstant(compilation.GetSpecialType(SpecialType.System_String), TypedConstantKind.Primitive, PEModule.ByRefLikeMarker),
                                        new TypedConstant(compilation.GetSpecialType(SpecialType.System_Boolean), TypedConstantKind.Primitive, false)), 
                         isOptionalUse: true));
                 }

src/Compilers/CSharp/Test/Emit/Attributes/AttributeTests_IsByRefLike.cs

@@ -659,6 +659,8 @@ class Test
 
                 var accessibility = Accessibility.Public;
                 var attributes = type.GetAttributes();
+                Assert.Equal(2, attributes.Count());
+
                 var assemblyName = module.ContainingAssembly.Name;
 
                 var attributeType = attributes[0].AttributeClass;
@@ -700,14 +702,14 @@ public class ObsoleteAttribute{}
 
                 var accessibility = Accessibility.Public;
                 var attributes = type.GetAttributes();
+                Assert.Equal(1, attributes.Count());
+
                 var assemblyName = module.ContainingAssembly.Name;
 
                 var attributeType = attributes[0].AttributeClass;
                 Assert.Equal("System.Runtime.CompilerServices.IsByRefLikeAttribute", attributeType.ToDisplayString());
                 Assert.Equal(assemblyName, attributeType.ContainingAssembly.Name);
                 Assert.Equal(accessibility, attributeType.DeclaredAccessibility);
-
-                Assert.Equal(1, attributes.Count());
             });
         }
 
@@ -753,6 +755,8 @@ class Test
 
                 var accessibility = Accessibility.Public;
                 var attributes = type.GetAttributes();
+                Assert.Equal(2, attributes.Count());
+
                 var assemblyName = module.ContainingAssembly.Name;
 
                 var attributeType = attributes[0].AttributeClass;
@@ -809,6 +813,10 @@ class Test
 
                 var accessibility = Accessibility.Public;
                 var attributes = type.GetAttributes();
+
+                Assert.Equal(3, attributes.Length);
+                Assert.Equal("Windows.Foundation.Metadata.DeprecatedAttribute", attributes[2].AttributeClass.ToDisplayString());
+
                 var assemblyName = module.ContainingAssembly.Name;
 
                 var attributeType = attributes[0].AttributeClass;

src/Compilers/Core/Portable/MetadataReader/PEModule.cs

@@ -1035,7 +1035,7 @@ internal bool HasIsByRefLikeAttribute(EntityHandle token)
             return FindTargetAttribute(token, AttributeDescription.IsByRefLikeAttribute).HasValue;
         }
 
-        internal const string byRefLikeMarker = "Types with embedded references are not supported in this version of your compiler.";
+        internal const string ByRefLikeMarker = "Types with embedded references are not supported in this version of your compiler.";
 
         internal ObsoleteAttributeData TryGetDeprecatedOrExperimentalOrObsoleteAttribute(
             EntityHandle token, 
@@ -1055,7 +1055,7 @@ internal bool HasIsByRefLikeAttribute(EntityHandle token)
                 ObsoleteAttributeData obsoleteData = TryExtractObsoleteDataFromAttribute(info);
                 if (obsoleteData != null &&
                     ignoreByRefLikeMarker &&
-                    obsoleteData.Message == byRefLikeMarker)
+                    obsoleteData.Message == ByRefLikeMarker)
                 {
                     return null;
                 }