Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
lwm1986
roslyn
提交
b7d860ed
R
roslyn
项目概览
lwm1986
/
roslyn
与 Fork 源项目一致
从无法访问的项目Fork
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
DevOps
流水线
流水线任务
计划
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
roslyn
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
DevOps
DevOps
流水线
流水线任务
计划
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
流水线任务
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
b7d860ed
编写于
10月 31, 2018
作者:
H
HeeJae Chang
提交者:
Sam Harwell
10月 31, 2018
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Add DiagnosticAnalysisResult.CreateEmpty and use where appropriate
上级
6bdc7b1e
变更
3
隐藏空白更改
内联
并排
Showing
3 changed file
with
20 addition
and
18 deletion
+20
-18
src/Features/Core/Portable/Diagnostics/EngineV2/DiagnosticIncrementalAnalyzer.ProjectState.cs
...cs/EngineV2/DiagnosticIncrementalAnalyzer.ProjectState.cs
+6
-6
src/Features/Core/Portable/Diagnostics/EngineV2/DiagnosticIncrementalAnalyzer.cs
...ble/Diagnostics/EngineV2/DiagnosticIncrementalAnalyzer.cs
+1
-1
src/Workspaces/Core/Portable/Diagnostics/DiagnosticAnalysisResult.cs
...ces/Core/Portable/Diagnostics/DiagnosticAnalysisResult.cs
+13
-11
未找到文件。
src/Features/Core/Portable/Diagnostics/EngineV2/DiagnosticIncrementalAnalyzer.ProjectState.cs
浏览文件 @
b7d860ed
...
...
@@ -77,7 +77,7 @@ public async Task<DiagnosticAnalysisResult> GetAnalysisDataAsync(Project project
// if given project doesnt have any diagnostics, return empty.
if
(
lastResult
.
IsEmpty
)
{
return
new
DiagnosticAnalysisResult
(
lastResult
.
ProjectId
,
lastResult
.
Version
);
return
DiagnosticAnalysisResult
.
CreateEmpty
(
lastResult
.
ProjectId
,
lastResult
.
Version
);
}
// loading data can be cancelled any time.
...
...
@@ -136,7 +136,7 @@ public async Task<DiagnosticAnalysisResult> GetAnalysisDataAsync(Document docume
// if given document doesnt have any diagnostics, return empty.
if
(
IsEmpty
(
lastResult
,
document
.
Id
))
{
return
new
DiagnosticAnalysisResult
(
lastResult
.
ProjectId
,
lastResult
.
Version
);
return
DiagnosticAnalysisResult
.
CreateEmpty
(
lastResult
.
ProjectId
,
lastResult
.
Version
);
}
// loading data can be cancelled any time.
...
...
@@ -177,7 +177,7 @@ public async Task<DiagnosticAnalysisResult> GetProjectAnalysisDataAsync(Project
// if given document doesnt have any diagnostics, return empty.
if
(
lastResult
.
IsEmpty
)
{
return
new
DiagnosticAnalysisResult
(
lastResult
.
ProjectId
,
lastResult
.
Version
);
return
DiagnosticAnalysisResult
.
CreateEmpty
(
lastResult
.
ProjectId
,
lastResult
.
Version
);
}
// loading data can be cancelled any time.
...
...
@@ -314,7 +314,7 @@ private async Task<DiagnosticAnalysisResult> LoadInitialAnalysisDataAsync(Projec
if
(!
await
TryDeserializeAsync
(
serializer
,
project
,
project
.
Id
,
_owner
.
NonLocalStateName
,
s_addOthers
,
builder
,
cancellationToken
).
ConfigureAwait
(
false
))
{
return
new
DiagnosticAnalysisResult
(
project
.
Id
,
VersionStamp
.
Default
,
ImmutableHashSet
<
DocumentId
>.
Empty
,
isEmpty
:
true
,
fromBuild
:
false
);
return
DiagnosticAnalysisResult
.
CreateEmpty
(
project
.
Id
,
VersionStamp
.
Default
);
}
return
builder
.
ToResult
();
...
...
@@ -331,7 +331,7 @@ private async Task<DiagnosticAnalysisResult> LoadInitialAnalysisDataAsync(Docume
if
(!
await
TryDeserializeDocumentAsync
(
serializer
,
document
,
builder
,
cancellationToken
).
ConfigureAwait
(
false
))
{
return
new
DiagnosticAnalysisResult
(
project
.
Id
,
VersionStamp
.
Default
,
ImmutableHashSet
<
DocumentId
>.
Empty
,
isEmpty
:
true
,
fromBuild
:
false
);
return
DiagnosticAnalysisResult
.
CreateEmpty
(
project
.
Id
,
VersionStamp
.
Default
);
}
return
builder
.
ToResult
();
...
...
@@ -346,7 +346,7 @@ private async Task<DiagnosticAnalysisResult> LoadInitialProjectAnalysisDataAsync
if
(!
await
TryDeserializeAsync
(
serializer
,
project
,
project
.
Id
,
_owner
.
NonLocalStateName
,
s_addOthers
,
builder
,
cancellationToken
).
ConfigureAwait
(
false
))
{
return
new
DiagnosticAnalysisResult
(
project
.
Id
,
VersionStamp
.
Default
,
ImmutableHashSet
<
DocumentId
>.
Empty
,
isEmpty
:
true
,
fromBuild
:
false
);
return
DiagnosticAnalysisResult
.
CreateEmpty
(
project
.
Id
,
VersionStamp
.
Default
);
}
return
builder
.
ToResult
();
...
...
src/Features/Core/Portable/Diagnostics/EngineV2/DiagnosticIncrementalAnalyzer.cs
浏览文件 @
b7d860ed
...
...
@@ -239,7 +239,7 @@ private static DiagnosticAnalysisResult GetResultOrEmpty(ImmutableDictionary<Dia
return
result
;
}
return
new
DiagnosticAnalysisResult
(
projectId
,
version
);
return
DiagnosticAnalysisResult
.
CreateEmpty
(
projectId
,
version
);
}
private
static
ImmutableArray
<
DiagnosticData
>
GetResult
(
DiagnosticAnalysisResult
result
,
AnalysisKind
kind
,
DocumentId
id
)
...
...
src/Workspaces/Core/Portable/Diagnostics/DiagnosticAnalysisResult.cs
浏览文件 @
b7d860ed
...
...
@@ -30,17 +30,6 @@ internal struct DiagnosticAnalysisResult
private
readonly
ImmutableDictionary
<
DocumentId
,
ImmutableArray
<
DiagnosticData
>>
_nonLocals
;
private
readonly
ImmutableArray
<
DiagnosticData
>
_others
;
public
DiagnosticAnalysisResult
(
ProjectId
projectId
,
VersionStamp
version
)
:
this
(
projectId
,
version
,
documentIds
:
ImmutableHashSet
<
DocumentId
>.
Empty
,
syntaxLocals
:
ImmutableDictionary
<
DocumentId
,
ImmutableArray
<
DiagnosticData
>>.
Empty
,
semanticLocals
:
ImmutableDictionary
<
DocumentId
,
ImmutableArray
<
DiagnosticData
>>.
Empty
,
nonLocals
:
ImmutableDictionary
<
DocumentId
,
ImmutableArray
<
DiagnosticData
>>.
Empty
,
others
:
ImmutableArray
<
DiagnosticData
>.
Empty
,
fromBuild
:
false
)
{
}
public
DiagnosticAnalysisResult
(
ProjectId
projectId
,
VersionStamp
version
,
ImmutableHashSet
<
DocumentId
>
documentIds
,
bool
isEmpty
,
bool
fromBuild
)
{
...
...
@@ -89,6 +78,19 @@ internal struct DiagnosticAnalysisResult
{
}
public
static
DiagnosticAnalysisResult
CreateEmpty
(
ProjectId
projectId
,
VersionStamp
version
)
{
return
new
DiagnosticAnalysisResult
(
projectId
,
version
,
documentIds
:
ImmutableHashSet
<
DocumentId
>.
Empty
,
syntaxLocals
:
ImmutableDictionary
<
DocumentId
,
ImmutableArray
<
DiagnosticData
>>.
Empty
,
semanticLocals
:
ImmutableDictionary
<
DocumentId
,
ImmutableArray
<
DiagnosticData
>>.
Empty
,
nonLocals
:
ImmutableDictionary
<
DocumentId
,
ImmutableArray
<
DiagnosticData
>>.
Empty
,
others
:
ImmutableArray
<
DiagnosticData
>.
Empty
,
fromBuild
:
false
);
}
// aggregated form means it has aggregated information but no actual data.
public
bool
IsAggregatedForm
=>
_syntaxLocals
==
null
;
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录