Merge pull request #46801 from jasonmalinowski/fix-editorconfig-changes-not-being-reflected

Ensure the Compilation's options are changed on .editorconfig changes

src/Workspaces/Core/Portable/Workspace/Solution/SolutionState.cs

@@ -1428,7 +1428,8 @@ private SolutionState UpdateAnalyzerConfigDocumentState(AnalyzerConfigDocumentSt
             // This method shouldn't have been called if the document has not changed.
             Debug.Assert(oldProject != newProject);
 
-            return ForkProject(newProject, new CompilationAndGeneratorDriverTranslationAction.ReplaceAllSyntaxTreesAction(newProject));
+            return ForkProject(newProject,
+                newProject.CompilationOptions != null ? new CompilationAndGeneratorDriverTranslationAction.ProjectCompilationOptionsAction(newProject.CompilationOptions) : null);
         }
 
         /// <summary>

src/Workspaces/CoreTest/SolutionTests/SolutionTests.cs

@@ -2917,6 +2917,7 @@ public async Task TestChangingAnEditorConfigFile([CombinatorialValues(LanguageNa
 
             var project = solution.GetProject(projectId);
             var provider = project.CompilationOptions.SyntaxTreeOptionsProvider;
+            Assert.Equal(provider, (await project.GetCompilationAsync()).Options.SyntaxTreeOptionsProvider);
             Assert.True(provider.TryGetDiagnosticValue(syntaxTreeBeforeEditorConfigChange, "CA1234", out var severity));
             Assert.Equal(ReportDiagnostic.Error, severity);
 
@@ -2929,6 +2930,7 @@ public async Task TestChangingAnEditorConfigFile([CombinatorialValues(LanguageNa
 
             project = solution.GetProject(projectId);
             provider = project.CompilationOptions.SyntaxTreeOptionsProvider;
+            Assert.Equal(provider, (await project.GetCompilationAsync()).Options.SyntaxTreeOptionsProvider);
             Assert.True(provider.TryGetDiagnosticValue(syntaxTreeBeforeEditorConfigChange, "CA6789", out severity));
             Assert.Equal(ReportDiagnostic.Error, severity);