Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
lwm1986
roslyn
提交
b5ba57ca
R
roslyn
项目概览
lwm1986
/
roslyn
与 Fork 源项目一致
从无法访问的项目Fork
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
DevOps
流水线
流水线任务
计划
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
roslyn
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
DevOps
DevOps
流水线
流水线任务
计划
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
流水线任务
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
b5ba57ca
编写于
10月 13, 2016
作者:
O
Omar Tawfik
提交者:
GitHub
10月 13, 2016
浏览文件
操作
浏览文件
下载
差异文件
Merge pull request #14463 from OmarTawfik/fix-8556-nre-on-method-group-cast
Fix printing ambiguous method group types on invalid casts
上级
eb0d0d20
a7b328fb
变更
2
隐藏空白更改
内联
并排
Showing
2 changed file
with
42 addition
and
1 deletion
+42
-1
src/Compilers/CSharp/Portable/Binder/Binder_Expressions.cs
src/Compilers/CSharp/Portable/Binder/Binder_Expressions.cs
+4
-1
src/Compilers/CSharp/Test/Semantic/Semantics/MethodBodyModelTests.cs
...rs/CSharp/Test/Semantic/Semantics/MethodBodyModelTests.cs
+38
-0
未找到文件。
src/Compilers/CSharp/Portable/Binder/Binder_Expressions.cs
浏览文件 @
b5ba57ca
...
@@ -1784,7 +1784,10 @@ private BoundExpression BindCastCore(ExpressionSyntax node, BoundExpression oper
...
@@ -1784,7 +1784,10 @@ private BoundExpression BindCastCore(ExpressionSyntax node, BoundExpression oper
ImmutableArray
<
MethodSymbol
>
originalUserDefinedConversions
=
conversion
.
OriginalUserDefinedConversions
;
ImmutableArray
<
MethodSymbol
>
originalUserDefinedConversions
=
conversion
.
OriginalUserDefinedConversions
;
if
(
originalUserDefinedConversions
.
Length
>
1
)
if
(
originalUserDefinedConversions
.
Length
>
1
)
{
{
diagnostics
.
Add
(
ErrorCode
.
ERR_AmbigUDConv
,
syntax
.
Location
,
originalUserDefinedConversions
[
0
],
originalUserDefinedConversions
[
1
],
operand
.
Type
,
targetType
);
// Method groups always have null types
var
operandType
=
(
operand
.
Kind
==
BoundKind
.
MethodGroup
)
?
(
object
)
MessageID
.
IDS_SK_METHOD
.
Localize
()
:
operand
.
Type
;
diagnostics
.
Add
(
ErrorCode
.
ERR_AmbigUDConv
,
syntax
.
Location
,
originalUserDefinedConversions
[
0
],
originalUserDefinedConversions
[
1
],
operandType
,
targetType
);
}
}
else
else
{
{
...
...
src/Compilers/CSharp/Test/Semantic/Semantics/MethodBodyModelTests.cs
浏览文件 @
b5ba57ca
...
@@ -956,5 +956,43 @@ public Inner(int xyzzy)
...
@@ -956,5 +956,43 @@ public Inner(int xyzzy)
Diagnostic
(
ErrorCode
.
ERR_ObjectRequired
,
"f1"
).
WithArguments
(
"Outer.f1"
).
WithLocation
(
10
,
21
)
Diagnostic
(
ErrorCode
.
ERR_ObjectRequired
,
"f1"
).
WithArguments
(
"Outer.f1"
).
WithLocation
(
10
,
21
)
);
);
}
}
[
Fact
,
WorkItem
(
8556
,
"https://github.com/dotnet/roslyn/issues/8556"
)]
public
void
CastAmbiguousMethodGroupTypeProducesCorrectErrorMessage
()
{
var
text
=
@"
using System;
public delegate void Foo ();
class D
{
public static implicit operator D (Action d)
{
return new D ();
}
public static explicit operator D (Foo d)
{
return new D ();
}
}
class Program
{
static void Main()
{
D d = (D) Main;
}
}
"
;
var
tree
=
Parse
(
text
);
var
comp
=
CreateCompilationWithMscorlib
(
tree
);
comp
.
GetMethodBodyDiagnostics
().
Verify
(
// (23,15): error CS0457: Ambiguous user defined conversions 'D.explicit operator D(Foo)' and 'D.implicit operator D(Action)' when converting from 'method' to 'D'
// D d = (D) Main;
Diagnostic
(
ErrorCode
.
ERR_AmbigUDConv
,
"(D) Main"
).
WithArguments
(
"D.explicit operator D(Foo)"
,
"D.implicit operator D(System.Action)"
,
"method"
,
"D"
).
WithLocation
(
23
,
15
)
);
}
}
}
}
}
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录