Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
lwm1986
roslyn
提交
b168a821
R
roslyn
项目概览
lwm1986
/
roslyn
与 Fork 源项目一致
从无法访问的项目Fork
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
DevOps
流水线
流水线任务
计划
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
roslyn
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
DevOps
DevOps
流水线
流水线任务
计划
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
流水线任务
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
b168a821
编写于
12月 16, 2014
作者:
A
AlekseyTs
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
C#: Disallow field-like event initializers in structs. Fixes #343.
***NO_CI*** (changeset 1387165)
上级
1578cdf9
变更
2
隐藏空白更改
内联
并排
Showing
2 changed file
with
51 addition
and
20 deletion
+51
-20
Src/Compilers/CSharp/Portable/Symbols/Source/SourceMemberContainerSymbol.cs
...rp/Portable/Symbols/Source/SourceMemberContainerSymbol.cs
+5
-20
Src/Compilers/CSharp/Test/Semantic/Semantics/StructsTests.cs
Src/Compilers/CSharp/Test/Semantic/Semantics/StructsTests.cs
+46
-0
未找到文件。
Src/Compilers/CSharp/Portable/Symbols/Source/SourceMemberContainerSymbol.cs
浏览文件 @
b168a821
...
...
@@ -2648,28 +2648,13 @@ private static void CheckInterfaceMember(Symbol member, DiagnosticBag diagnostic
private
void
CheckForStructBadInitializers
(
MembersAndInitializersBuilder
builder
,
DiagnosticBag
diagnostics
)
{
Debug
.
Assert
(
TypeKind
==
TypeKind
.
Struct
);
if
(
builder
.
InstanceInitializers
.
Count
>
0
)
{
var
members
=
builder
.
NonTypeNonIndexerMembers
;
foreach
(
var
s
in
members
)
foreach
(
var
initializers
in
builder
.
InstanceInitializers
)
{
foreach
(
FieldOrPropertyInitializer
initializer
in
initializers
)
{
var
p
=
s
as
SourcePropertySymbol
;
if
(
p
!=
null
&&
!
p
.
IsStatic
&&
p
.
IsAutoProperty
&&
p
.
BackingField
.
HasInitializer
)
{
// '{0}': cannot have instance field initializers in structs
diagnostics
.
Add
(
ErrorCode
.
ERR_FieldInitializerInStruct
,
p
.
Locations
[
0
],
this
);
}
else
{
var
f
=
s
as
SourceMemberFieldSymbol
;
if
(
f
!=
null
&&
!
f
.
IsStatic
&&
f
.
HasInitializer
)
{
// '{0}': cannot have instance field initializers in structs
diagnostics
.
Add
(
ErrorCode
.
ERR_FieldInitializerInStruct
,
f
.
Locations
[
0
],
this
);
}
}
// '{0}': cannot have instance field initializers in structs
diagnostics
.
Add
(
ErrorCode
.
ERR_FieldInitializerInStruct
,
(
initializer
.
Field
.
AssociatedSymbol
??
initializer
.
Field
).
Locations
[
0
],
this
);
}
}
}
...
...
Src/Compilers/CSharp/Test/Semantic/Semantics/StructsTests.cs
浏览文件 @
b168a821
...
...
@@ -38,6 +38,52 @@ public struct A
);
}
[
WorkItem
(
1075325
,
"DevDiv"
),
WorkItem
(
343
,
"CodePlex"
)]
[
Fact
()]
public
void
TestInitEventStruct
()
{
var
text
=
@"
struct S {
event System.Action E = null;
void M()
{
E();
}
}
"
;
CreateCompilationWithMscorlib
(
text
).
VerifyDiagnostics
(
// (3,25): error CS0573: 'S': cannot have instance property or field initializers in structs
// event System.Action E = null;
Diagnostic
(
ErrorCode
.
ERR_FieldInitializerInStruct
,
"E"
).
WithArguments
(
"S"
).
WithLocation
(
3
,
25
)
);
}
[
WorkItem
(
1075325
,
"DevDiv"
),
WorkItem
(
343
,
"CodePlex"
)]
[
Fact
()]
public
void
TestStaticInitInStruct
()
{
var
text
=
@"
struct S {
static event System.Action E = M;
static int F = 10;
static int P {get; set;} = 20;
static void M()
{
}
static void Main()
{
System.Console.WriteLine(""{0} {1} {2}"", S.F, S.P, S.E == null);
}
}
"
;
var
comp
=
CreateCompilationWithMscorlib
(
text
,
options
:
TestOptions
.
DebugExe
);
CompileAndVerify
(
comp
,
expectedOutput
:
"10 20 False"
).
VerifyDiagnostics
();
}
// Test constructor forwarding works for structs
[
WorkItem
(
540896
,
"DevDiv"
)]
[
Fact
]
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录