Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
lwm1986
roslyn
提交
b036252a
R
roslyn
项目概览
lwm1986
/
roslyn
与 Fork 源项目一致
从无法访问的项目Fork
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
DevOps
流水线
流水线任务
计划
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
roslyn
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
DevOps
DevOps
流水线
流水线任务
计划
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
流水线任务
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
b036252a
编写于
9月 23, 2020
作者:
S
Sam Harwell
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Report non-fatal errors for failed tasks
See #47891
上级
8d877410
变更
2
隐藏空白更改
内联
并排
Showing
2 changed file
with
9 addition
and
9 deletion
+9
-9
src/Workspaces/SharedUtilitiesAndExtensions/Compiler/Core/Utilities/TaskExtensions.cs
...esAndExtensions/Compiler/Core/Utilities/TaskExtensions.cs
+7
-7
src/Workspaces/SharedUtilitiesAndExtensions/Compiler/Core/Utilities/TaskFactoryExtensions.cs
...tensions/Compiler/Core/Utilities/TaskFactoryExtensions.cs
+2
-2
未找到文件。
src/Workspaces/SharedUtilitiesAndExtensions/Compiler/Core/Utilities/TaskExtensions.cs
浏览文件 @
b036252a
...
...
@@ -369,7 +369,7 @@ TResult outerFunction(Task t)
// This is the only place in the code where we're allowed to call ContinueWith.
var
nextTask
=
task
.
ContinueWith
(
continuationFunction
,
cancellationToken
,
continuationOptions
|
TaskContinuationOptions
.
LazyCancellation
,
scheduler
).
Unwrap
();
nextTask
.
ContinueWith
(
ReportFatalError
,
continuationFunction
,
nextTask
.
ContinueWith
(
Report
Non
FatalError
,
continuationFunction
,
CancellationToken
.
None
,
TaskContinuationOptions
.
OnlyOnFaulted
|
TaskContinuationOptions
.
ExecuteSynchronously
,
TaskScheduler
.
Default
);
...
...
@@ -412,7 +412,7 @@ TResult outerFunction(Task t)
// the behavior we want.
// This is the only place in the code where we're allowed to call ContinueWith.
var
nextTask
=
task
.
ContinueWith
(
continuationFunction
,
cancellationToken
,
continuationOptions
|
TaskContinuationOptions
.
LazyCancellation
,
scheduler
).
Unwrap
();
ReportFatalError
(
nextTask
,
continuationFunction
);
Report
Non
FatalError
(
nextTask
,
continuationFunction
);
return
nextTask
;
}
...
...
@@ -451,7 +451,7 @@ TResult outerFunction(Task t)
// the behavior we want.
// This is the only place in the code where we're allowed to call ContinueWith.
var
nextTask
=
task
.
ContinueWith
(
continuationFunction
,
cancellationToken
,
continuationOptions
|
TaskContinuationOptions
.
LazyCancellation
,
scheduler
).
Unwrap
();
ReportFatalError
(
nextTask
,
continuationFunction
);
Report
Non
FatalError
(
nextTask
,
continuationFunction
);
return
nextTask
;
}
...
...
@@ -536,16 +536,16 @@ TResult outerFunction(Task t)
cancellationToken
,
taskContinuationOptions
,
scheduler
).
Unwrap
();
}
internal
static
void
ReportFatalError
(
Task
task
,
object
continuationFunction
)
internal
static
void
Report
Non
FatalError
(
Task
task
,
object
continuationFunction
)
{
task
.
ContinueWith
(
ReportFatalErrorWorker
,
continuationFunction
,
task
.
ContinueWith
(
Report
Non
FatalErrorWorker
,
continuationFunction
,
CancellationToken
.
None
,
TaskContinuationOptions
.
OnlyOnFaulted
|
TaskContinuationOptions
.
ExecuteSynchronously
,
TaskScheduler
.
Default
);
}
[
MethodImpl
(
MethodImplOptions
.
NoOptimization
|
MethodImplOptions
.
NoInlining
)]
private
static
void
ReportFatalErrorWorker
(
Task
task
,
object
continuationFunction
)
private
static
void
Report
Non
FatalErrorWorker
(
Task
task
,
object
continuationFunction
)
{
var
exception
=
task
.
Exception
;
var
methodInfo
=
((
Delegate
)
continuationFunction
).
GetMethodInfo
();
...
...
@@ -558,7 +558,7 @@ private static void ReportFatalErrorWorker(Task task, object continuationFunctio
// ...
// > ~67s // switch to thread 67
// > !dso // dump stack objects
FatalError
.
Report
(
exception
);
FatalError
.
Report
WithoutCrash
(
exception
);
}
public
static
Task
ReportNonFatalErrorAsync
(
this
Task
task
)
...
...
src/Workspaces/SharedUtilitiesAndExtensions/Compiler/Core/Utilities/TaskFactoryExtensions.cs
浏览文件 @
b036252a
...
...
@@ -55,7 +55,7 @@ public static Task SafeStartNewFromAsync(this TaskFactory factory, Func<Task> ac
{
// The one and only place we can call StartNew<>().
var
task
=
factory
.
StartNew
(
actionAsync
,
cancellationToken
,
TaskCreationOptions
.
None
,
scheduler
).
Unwrap
();
TaskExtensions
.
ReportFatalError
(
task
,
actionAsync
);
TaskExtensions
.
Report
Non
FatalError
(
task
,
actionAsync
);
return
task
;
}
...
...
@@ -63,7 +63,7 @@ public static Task<TResult> SafeStartNewFromAsync<TResult>(this TaskFactory fact
{
// The one and only place we can call StartNew<>().
var
task
=
factory
.
StartNew
(
funcAsync
,
cancellationToken
,
TaskCreationOptions
.
None
,
scheduler
).
Unwrap
();
TaskExtensions
.
ReportFatalError
(
task
,
funcAsync
);
TaskExtensions
.
Report
Non
FatalError
(
task
,
funcAsync
);
return
task
;
}
}
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录