Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
lwm1986
roslyn
提交
aa83bfbb
R
roslyn
项目概览
lwm1986
/
roslyn
与 Fork 源项目一致
从无法访问的项目Fork
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
DevOps
流水线
流水线任务
计划
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
roslyn
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
DevOps
DevOps
流水线
流水线任务
计划
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
流水线任务
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
aa83bfbb
编写于
1月 27, 2020
作者:
S
Sam Harwell
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Move test helper to TestAccessor
上级
e19286c5
变更
2
隐藏空白更改
内联
并排
Showing
2 changed file
with
31 addition
and
18 deletion
+31
-18
src/Workspaces/Core/Portable/Workspace/Solution/ProjectDependencyGraph.cs
...ore/Portable/Workspace/Solution/ProjectDependencyGraph.cs
+28
-15
src/Workspaces/CoreTest/SolutionTests/ProjectDependencyGraphTests.cs
...ces/CoreTest/SolutionTests/ProjectDependencyGraphTests.cs
+3
-3
未找到文件。
src/Workspaces/Core/Portable/Workspace/Solution/ProjectDependencyGraph.cs
浏览文件 @
aa83bfbb
...
@@ -241,21 +241,6 @@ private void ComputeTransitiveReferences(ProjectId project, HashSet<ProjectId> r
...
@@ -241,21 +241,6 @@ private void ComputeTransitiveReferences(ProjectId project, HashSet<ProjectId> r
}
}
}
}
/// <summary>
/// Gets the list of projects that directly or transitively depend on this project, if it has already been
/// cached.
/// </summary>
internal
ImmutableHashSet
<
ProjectId
>?
TryGetProjectsThatTransitivelyDependOnThisProject
(
ProjectId
projectId
)
{
if
(
projectId
is
null
)
{
throw
new
ArgumentNullException
(
nameof
(
projectId
));
}
_reverseTransitiveReferencesMap
.
TryGetValue
(
projectId
,
out
var
projects
);
return
projects
;
}
/// <summary>
/// <summary>
/// Gets the list of projects that directly or transitively depend on this project.
/// Gets the list of projects that directly or transitively depend on this project.
/// </summary>
/// </summary>
...
@@ -427,5 +412,33 @@ private void ComputedDependencySet(ProjectId project, HashSet<ProjectId> result)
...
@@ -427,5 +412,33 @@ private void ComputedDependencySet(ProjectId project, HashSet<ProjectId> result)
}
}
}
}
}
}
internal
TestAccessor
GetTestAccessor
()
=>
new
TestAccessor
(
this
);
internal
readonly
struct
TestAccessor
{
private
readonly
ProjectDependencyGraph
_instance
;
public
TestAccessor
(
ProjectDependencyGraph
instance
)
{
_instance
=
instance
;
}
/// <summary>
/// Gets the list of projects that directly or transitively depend on this project, if it has already been
/// cached.
/// </summary>
public
ImmutableHashSet
<
ProjectId
>?
TryGetProjectsThatTransitivelyDependOnThisProject
(
ProjectId
projectId
)
{
if
(
projectId
is
null
)
{
throw
new
ArgumentNullException
(
nameof
(
projectId
));
}
_instance
.
_reverseTransitiveReferencesMap
.
TryGetValue
(
projectId
,
out
var
projects
);
return
projects
;
}
}
}
}
}
}
src/Workspaces/CoreTest/SolutionTests/ProjectDependencyGraphTests.cs
浏览文件 @
aa83bfbb
...
@@ -513,7 +513,7 @@ public void TestReverseTransitiveReferencesAfterProjectReferenceRemoval_Preserve
...
@@ -513,7 +513,7 @@ public void TestReverseTransitiveReferencesAfterProjectReferenceRemoval_Preserve
// Before any other operations, verify that TryGetProjectsThatTransitivelyDependOnThisProject returns a
// Before any other operations, verify that TryGetProjectsThatTransitivelyDependOnThisProject returns a
// non-null set. Specifically, it returns the _same_ set that was computed prior to the project reference
// non-null set. Specifically, it returns the _same_ set that was computed prior to the project reference
// removal.
// removal.
Assert
.
Same
(
expected
,
solution
.
State
.
GetProjectDependencyGraph
().
TryGetProjectsThatTransitivelyDependOnThisProject
(
d
.
Id
));
Assert
.
Same
(
expected
,
solution
.
State
.
GetProjectDependencyGraph
().
GetTestAccessor
().
TryGetProjectsThatTransitivelyDependOnThisProject
(
d
.
Id
));
}
}
[
Fact
,
Trait
(
Traits
.
Feature
,
Traits
.
Features
.
Workspace
)]
[
Fact
,
Trait
(
Traits
.
Feature
,
Traits
.
Features
.
Workspace
)]
...
@@ -541,7 +541,7 @@ public void TestReverseTransitiveReferencesAfterProjectReferenceRemoval_Preserve
...
@@ -541,7 +541,7 @@ public void TestReverseTransitiveReferencesAfterProjectReferenceRemoval_Preserve
// Before any other operations, verify that TryGetProjectsThatTransitivelyDependOnThisProject returns a
// Before any other operations, verify that TryGetProjectsThatTransitivelyDependOnThisProject returns a
// non-null set. Specifically, it returns the _same_ set that was computed prior to the project reference
// non-null set. Specifically, it returns the _same_ set that was computed prior to the project reference
// removal.
// removal.
Assert
.
Same
(
expected
,
solution
.
State
.
GetProjectDependencyGraph
().
TryGetProjectsThatTransitivelyDependOnThisProject
(
e
.
Id
));
Assert
.
Same
(
expected
,
solution
.
State
.
GetProjectDependencyGraph
().
GetTestAccessor
().
TryGetProjectsThatTransitivelyDependOnThisProject
(
e
.
Id
));
}
}
[
Fact
,
Trait
(
Traits
.
Feature
,
Traits
.
Features
.
Workspace
)]
[
Fact
,
Trait
(
Traits
.
Feature
,
Traits
.
Features
.
Workspace
)]
...
@@ -569,7 +569,7 @@ public void TestReverseTransitiveReferencesAfterProjectReferenceRemoval_DiscardI
...
@@ -569,7 +569,7 @@ public void TestReverseTransitiveReferencesAfterProjectReferenceRemoval_DiscardI
// Before any other operations, verify that TryGetProjectsThatTransitivelyDependOnThisProject returns a
// Before any other operations, verify that TryGetProjectsThatTransitivelyDependOnThisProject returns a
// null set.
// null set.
Assert
.
Null
(
solution
.
State
.
GetProjectDependencyGraph
().
TryGetProjectsThatTransitivelyDependOnThisProject
(
c
.
Id
));
Assert
.
Null
(
solution
.
State
.
GetProjectDependencyGraph
().
GetTestAccessor
().
TryGetProjectsThatTransitivelyDependOnThisProject
(
c
.
Id
));
VerifyReverseTransitiveReferences
(
solution
,
"C"
,
new
string
[]
{
"B"
});
VerifyReverseTransitiveReferences
(
solution
,
"C"
,
new
string
[]
{
"B"
});
}
}
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录