Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
lwm1986
roslyn
提交
aa16ff81
R
roslyn
项目概览
lwm1986
/
roslyn
与 Fork 源项目一致
从无法访问的项目Fork
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
DevOps
流水线
流水线任务
计划
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
roslyn
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
DevOps
DevOps
流水线
流水线任务
计划
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
流水线任务
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
aa16ff81
编写于
3月 01, 2020
作者:
C
Cyrus Najmabadi
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Adjust cases where we offer ?.Invoke
上级
a6f8496f
变更
2
隐藏空白更改
内联
并排
Showing
2 changed file
with
148 addition
and
1 deletion
+148
-1
src/EditorFeatures/CSharpTest/Diagnostics/InvokeDelegateWithConditionalAccess/InvokeDelegateWithConditionalAccessTests.cs
...itionalAccess/InvokeDelegateWithConditionalAccessTests.cs
+130
-0
src/Features/CSharp/Portable/InvokeDelegateWithConditionalAccess/InvokeDelegateWithConditionalAccessAnalyzer.cs
...onalAccess/InvokeDelegateWithConditionalAccessAnalyzer.cs
+18
-1
未找到文件。
src/EditorFeatures/CSharpTest/Diagnostics/InvokeDelegateWithConditionalAccess/InvokeDelegateWithConditionalAccessTests.cs
浏览文件 @
aa16ff81
...
...
@@ -757,6 +757,136 @@ int Goo()
return v();
}
}
}"
);
}
[
Fact
,
Trait
(
Traits
.
Feature
,
Traits
.
Features
.
CodeActionsInvokeDelegateWithConditionalAccess
)]
[
WorkItem
(
13226
,
"https://github.com/dotnet/roslyn/issues/13226"
)]
public
async
Task
TestWithLambdaInitializer
()
{
await
TestInRegularAndScript1Async
(
@"
using System;
class C
{
void Goo()
{
Action v = () => {};
[||]if (v != null)
{
v();
}
}
}"
,
@"
using System;
class C
{
void Goo()
{
Action v = () => {};
v?.Invoke();
}
}"
);
}
[
Fact
,
Trait
(
Traits
.
Feature
,
Traits
.
Features
.
CodeActionsInvokeDelegateWithConditionalAccess
)]
[
WorkItem
(
13226
,
"https://github.com/dotnet/roslyn/issues/13226"
)]
public
async
Task
TestWithLambdaInitializer2
()
{
await
TestInRegularAndScript1Async
(
@"
using System;
class C
{
void Goo()
{
Action v = (() => {});
[||]if (v != null)
{
v();
}
}
}"
,
@"
using System;
class C
{
void Goo()
{
Action v = (() => {});
v?.Invoke();
}
}"
);
}
[
Fact
,
Trait
(
Traits
.
Feature
,
Traits
.
Features
.
CodeActionsInvokeDelegateWithConditionalAccess
)]
[
WorkItem
(
13226
,
"https://github.com/dotnet/roslyn/issues/13226"
)]
public
async
Task
TestForWithAnonymousMethod
()
{
await
TestInRegularAndScript1Async
(
@"
using System;
class C
{
void Goo()
{
Action v = delegate {};
[||]if (v != null)
{
v();
}
}
}"
,
@"
using System;
class C
{
void Goo()
{
Action v = delegate {};
v?.Invoke();
}
}"
);
}
[
Fact
,
Trait
(
Traits
.
Feature
,
Traits
.
Features
.
CodeActionsInvokeDelegateWithConditionalAccess
)]
[
WorkItem
(
13226
,
"https://github.com/dotnet/roslyn/issues/13226"
)]
public
async
Task
TestWithMethodReference
()
{
await
TestInRegularAndScript1Async
(
@"
using System;
class C
{
void Goo()
{
Action v = Console.WriteLine;
[||]if (v != null)
{
v();
}
}
}"
,
@"
using System;
class C
{
void Goo()
{
Action v = Console.WriteLine;
v?.Invoke();
}
}"
);
}
}
...
...
src/Features/CSharp/Portable/InvokeDelegateWithConditionalAccess/InvokeDelegateWithConditionalAccessAnalyzer.cs
浏览文件 @
aa16ff81
...
...
@@ -2,6 +2,7 @@
// The .NET Foundation licenses this file to you under the MIT license.
// See the LICENSE file in the project root for more information.
using
System
;
using
System.Collections.Generic
;
using
System.Collections.Immutable
;
using
Microsoft.CodeAnalysis.CodeStyle
;
...
...
@@ -9,6 +10,7 @@
using
Microsoft.CodeAnalysis.CSharp.Extensions
;
using
Microsoft.CodeAnalysis.CSharp.Syntax
;
using
Microsoft.CodeAnalysis.Diagnostics
;
using
Microsoft.CodeAnalysis.ExternalAccess.Pythia.Api
;
using
Microsoft.CodeAnalysis.Text
;
namespace
Microsoft.CodeAnalysis.CSharp.InvokeDelegateWithConditionalAccess
...
...
@@ -252,7 +254,7 @@ private void SyntaxNodeAction(SyntaxNodeAnalysisContext syntaxContext)
}
var
declarator
=
variableDeclaration
.
Variables
[
0
];
if
(
declarator
.
Initializer
==
null
)
if
(
declarator
.
Initializer
?.
Value
==
null
)
{
return
false
;
}
...
...
@@ -265,6 +267,21 @@ private void SyntaxNodeAction(SyntaxNodeAnalysisContext syntaxContext)
// Syntactically this looks good. Now make sure that the local is a delegate type.
var
semanticModel
=
syntaxContext
.
SemanticModel
;
// The initializer can't be inlined if it's an actual lambda/method reference.
// These cannot be invoked with `?.` (only delegate *values* can be).
var
initializer
=
declarator
.
Initializer
.
Value
.
WalkDownParentheses
();
if
(
initializer
.
IsAnyLambdaOrAnonymousMethod
())
{
return
false
;
}
var
initializerSymbol
=
semanticModel
.
GetSymbolInfo
(
initializer
,
cancellationToken
).
GetAnySymbol
();
if
(
initializerSymbol
is
IMethodSymbol
)
{
return
false
;
}
var
localSymbol
=
(
ILocalSymbol
)
semanticModel
.
GetDeclaredSymbol
(
declarator
,
cancellationToken
);
// Ok, we made a local just to check it for null and invoke it. Looks like something
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录