Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
lwm1986
roslyn
提交
a9f28bbf
R
roslyn
项目概览
lwm1986
/
roslyn
与 Fork 源项目一致
从无法访问的项目Fork
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
DevOps
流水线
流水线任务
计划
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
roslyn
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
DevOps
DevOps
流水线
流水线任务
计划
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
流水线任务
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
a9f28bbf
编写于
5月 30, 2020
作者:
M
Manish Vasani
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Add code action equivalence key validation in test framework
Fixes #44553
上级
19c0d73e
变更
3
隐藏空白更改
内联
并排
Showing
3 changed file
with
47 addition
and
0 deletion
+47
-0
src/EditorFeatures/DiagnosticsTestUtilities/CodeActions/AbstractCodeActionOrUserDiagnosticTest.cs
...ies/CodeActions/AbstractCodeActionOrUserDiagnosticTest.cs
+42
-0
src/EditorFeatures/DiagnosticsTestUtilities/CodeActions/AbstractCodeActionTest.cs
...osticsTestUtilities/CodeActions/AbstractCodeActionTest.cs
+3
-0
src/EditorFeatures/DiagnosticsTestUtilities/Diagnostics/AbstractUserDiagnosticTest.cs
...csTestUtilities/Diagnostics/AbstractUserDiagnosticTest.cs
+2
-0
未找到文件。
src/EditorFeatures/DiagnosticsTestUtilities/CodeActions/AbstractCodeActionOrUserDiagnosticTest.cs
浏览文件 @
a9f28bbf
...
...
@@ -19,6 +19,8 @@
using
Roslyn.Utilities
;
using
Roslyn.Test.Utilities
;
using
Xunit
;
using
Microsoft.CodeAnalysis.CodeFixes
;
using
Microsoft.CodeAnalysis.CodeRefactorings
;
#if CODE_STYLE
using
System.Diagnostics
;
...
...
@@ -681,6 +683,46 @@ static void VerifyExpectedDocumentText(string expected, string actual)
protected
virtual
ImmutableArray
<
CodeAction
>
MassageActions
(
ImmutableArray
<
CodeAction
>
actions
)
=>
actions
;
internal
static
void
VerifyCodeActionsRegisteredByProvider
(
List
<
CodeFix
>
fixes
)
{
var
diagnosticsAndEquivalenceKeyToTitleMap
=
new
Dictionary
<(
Diagnostic
diagnostic
,
string
equivalenceKey
),
string
>();
foreach
(
var
fix
in
fixes
)
{
var
codeAction
=
fix
.
Action
;
foreach
(
var
diagnostic
in
fix
.
Diagnostics
)
{
var
key
=
(
diagnostic
,
codeAction
.
EquivalenceKey
);
var
existingTitle
=
diagnosticsAndEquivalenceKeyToTitleMap
.
GetOrAdd
(
key
,
_
=>
codeAction
.
Title
);
if
(
existingTitle
!=
codeAction
.
Title
)
{
Assert
.
False
(
true
,
@
$"Expected different 'CodeAction.EquivalenceKey' for code actions registered for same diagnostic:
-
Title
1
:
'
{
codeAction
.
Title
}
'
-
Title
2
:
'
{
existingTitle
}
'
-
Shared
equivalence
key
:
'
{
codeAction
.
EquivalenceKey
??
"<null>"
}
'
");
}
}
}
}
internal
static
void
VerifyCodeActionsRegisteredByProvider
(
CodeRefactoring
refactorings
)
{
var
applicableSpanAndEquivalenceKeyToTitleMap
=
new
Dictionary
<(
TextSpan
applicableToSpan
,
string
equivalenceKey
),
string
>();
foreach
(
var
(
codeAction
,
applicableToSpan
)
in
refactorings
.
CodeActions
)
{
var
key
=
(
applicableToSpan
??
default
,
codeAction
.
EquivalenceKey
);
var
existingTitle
=
applicableSpanAndEquivalenceKeyToTitleMap
.
GetOrAdd
(
key
,
_
=>
codeAction
.
Title
);
if
(
existingTitle
!=
codeAction
.
Title
)
{
Assert
.
False
(
true
,
@
$"Expected different 'CodeAction.EquivalenceKey' for code actions registered for same applicable span:
-
Title
1
:
'
{
codeAction
.
Title
}
'
-
Title
2
:
'
{
existingTitle
}
'
-
Shared
equivalence
key
:
'
{
codeAction
.
EquivalenceKey
??
"<null>"
}
'
");
}
}
}
protected
static
ImmutableArray
<
CodeAction
>
FlattenActions
(
ImmutableArray
<
CodeAction
>
codeActions
)
{
return
codeActions
.
SelectMany
(
a
=>
a
.
NestedCodeActions
.
Length
>
0
...
...
src/EditorFeatures/DiagnosticsTestUtilities/CodeActions/AbstractCodeActionTest.cs
浏览文件 @
a9f28bbf
...
...
@@ -70,6 +70,9 @@ protected override Task<ImmutableArray<Diagnostic>> GetDiagnosticsWorkerAsync(Te
var
result
=
actions
.
Count
>
0
?
new
CodeRefactoring
(
provider
,
actions
.
ToImmutable
())
:
null
;
actions
.
Free
();
VerifyCodeActionsRegisteredByProvider
(
result
);
return
result
;
}
...
...
src/EditorFeatures/DiagnosticsTestUtilities/Diagnostics/AbstractUserDiagnosticTest.cs
浏览文件 @
a9f28bbf
...
...
@@ -202,6 +202,8 @@ protected Document GetDocumentAndAnnotatedSpan(TestWorkspace workspace, out stri
await
fixer
.
RegisterCodeFixesAsync
(
context
);
}
VerifyCodeActionsRegisteredByProvider
(
fixes
);
var
actions
=
fixes
.
SelectAsArray
(
f
=>
f
.
Action
);
actions
=
MassageActions
(
actions
);
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录