Fix typing crash during open file analysis.
My previous PR #37303 to improve IDE open file analysis performance led to a functional regression where attempting to compute open file diagnostics for a partial type leads to recursive attempt to force complete all partial trees, which in turn attempt force completion of original tree. In presence of cancellation request, this leads to a stack overflow and VS crash. The fix here ensures that we don't attempt partial tree analysis when invoked in context of partial analysis itself. Fixes VSO [#957250](https://devdiv.visualstudio.com/DevDiv/_workitems/edit/957250) and [#957243](https://devdiv.visualstudio.com/DevDiv/_workitems/edit/957243) Fixes #37567 I have manually verified the crash before the fix and verified it does not repro after the fix. I am working on adding an integration test for the scenario with a follow-up commit/PR.
Showing
想要评论请 注册 或 登录