Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
lwm1986
roslyn
提交
a6b6b662
R
roslyn
项目概览
lwm1986
/
roslyn
与 Fork 源项目一致
从无法访问的项目Fork
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
DevOps
流水线
流水线任务
计划
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
roslyn
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
DevOps
DevOps
流水线
流水线任务
计划
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
流水线任务
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
a6b6b662
编写于
4月 21, 2016
作者:
H
Heejae Chang
浏览文件
操作
浏览文件
下载
差异文件
Merge pull request #10760 from heejaechang/idleak
fixed live diagnostic argId leak
上级
559baa33
6af9a201
变更
2
隐藏空白更改
内联
并排
Showing
2 changed file
with
69 addition
and
13 deletion
+69
-13
src/Features/Core/Portable/Diagnostics/DiagnosticService.cs
src/Features/Core/Portable/Diagnostics/DiagnosticService.cs
+6
-2
src/VisualStudio/Core/Def/Implementation/TableDataSource/OpenDocumentTracker.cs
...Def/Implementation/TableDataSource/OpenDocumentTracker.cs
+63
-11
未找到文件。
src/Features/Core/Portable/Diagnostics/DiagnosticService.cs
浏览文件 @
a6b6b662
...
...
@@ -123,8 +123,12 @@ private bool UpdateDataMap(IDiagnosticUpdateSource source, DiagnosticsUpdatedArg
return
true
;
}
var
data
=
source
.
SupportGetDiagnostics
?
new
Data
(
args
)
:
new
Data
(
args
,
args
.
Diagnostics
);
diagnosticDataMap
.
Add
(
args
.
Id
,
data
);
if
(
args
.
Diagnostics
.
Length
>
0
)
{
// save data only if there is a diagnostic
var
data
=
source
.
SupportGetDiagnostics
?
new
Data
(
args
)
:
new
Data
(
args
,
args
.
Diagnostics
);
diagnosticDataMap
.
Add
(
args
.
Id
,
data
);
}
return
true
;
}
...
...
src/VisualStudio/Core/Def/Implementation/TableDataSource/OpenDocumentTracker.cs
浏览文件 @
a6b6b662
...
...
@@ -2,6 +2,7 @@
using
System
;
using
System.Collections.Generic
;
using
System.Linq
;
using
Microsoft.CodeAnalysis
;
namespace
Microsoft.VisualStudio.LanguageServices.Implementation.TableDataSource
...
...
@@ -19,6 +20,7 @@ public OpenDocumentTracker(Workspace workspace)
_workspace
=
workspace
;
_workspace
.
DocumentClosed
+=
OnDocumentClosed
;
_workspace
.
WorkspaceChanged
+=
OnWorkspaceChanged
;
}
public
void
TrackOpenDocument
(
DocumentId
documentId
,
object
id
,
AbstractTableEntriesSnapshot
<
T
>
snapshot
)
...
...
@@ -43,28 +45,78 @@ public void TrackOpenDocument(DocumentId documentId, object id, AbstractTableEnt
}
}
private
void
OnDocumentClosed
(
object
sender
,
DocumentEventArgs
e
)
private
void
StopTracking
(
DocumentId
documentId
)
{
lock
(
_gate
)
{
Dictionary
<
object
,
WeakReference
<
AbstractTableEntriesSnapshot
<
T
>>>
secondMap
;
if
(!
_map
.
TryGetValue
(
e
.
Document
.
Id
,
out
secondMap
))
{
return
;
}
StopTracking_NoLock
(
documentId
);
}
}
_map
.
Remove
(
e
.
Document
.
Id
);
foreach
(
var
weakSnapshot
in
secondMap
.
Values
)
private
void
StopTracking
(
Solution
solution
,
ProjectId
projectId
=
null
)
{
lock
(
_gate
)
{
foreach
(
var
documentId
in
_map
.
Keys
.
Where
(
d
=>
projectId
==
null
?
true
:
d
.
ProjectId
==
projectId
).
ToList
())
{
AbstractTableEntriesSnapshot
<
T
>
snapshot
;
if
(!
weakSnapshot
.
TryGetTarget
(
out
snapshot
))
if
(
solution
.
GetDocument
(
documentId
)
!=
null
)
{
// document still exist.
continue
;
}
snapshot
.
StopTracking
();
StopTracking_NoLock
(
documentId
);
}
}
}
private
void
StopTracking_NoLock
(
DocumentId
documentId
)
{
Dictionary
<
object
,
WeakReference
<
AbstractTableEntriesSnapshot
<
T
>>>
secondMap
;
if
(!
_map
.
TryGetValue
(
documentId
,
out
secondMap
))
{
return
;
}
_map
.
Remove
(
documentId
);
foreach
(
var
weakSnapshot
in
secondMap
.
Values
)
{
AbstractTableEntriesSnapshot
<
T
>
snapshot
;
if
(!
weakSnapshot
.
TryGetTarget
(
out
snapshot
))
{
continue
;
}
snapshot
.
StopTracking
();
}
}
private
void
OnWorkspaceChanged
(
object
sender
,
WorkspaceChangeEventArgs
e
)
{
switch
(
e
.
Kind
)
{
case
WorkspaceChangeKind
.
SolutionRemoved
:
case
WorkspaceChangeKind
.
SolutionCleared
:
StopTracking
(
e
.
NewSolution
);
break
;
case
WorkspaceChangeKind
.
ProjectRemoved
:
StopTracking
(
e
.
NewSolution
,
e
.
ProjectId
);
break
;
case
WorkspaceChangeKind
.
DocumentRemoved
:
StopTracking
(
e
.
DocumentId
);
break
;
default
:
// do nothing
break
;
}
}
private
void
OnDocumentClosed
(
object
sender
,
DocumentEventArgs
e
)
{
StopTracking
(
e
.
Document
.
Id
);
}
}
}
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录