Merge pull request #4338 from agocke/FixStackOverflowInLocalizableErrorArgument

Fix stack overflow in LocalizableErrorArgument

src/Compilers/VisualBasic/Portable/Errors/LocalizableErrorArgument.vb

@@ -21,7 +21,7 @@ Namespace Microsoft.CodeAnalysis.VisualBasic
         '''Creates a string representing the unformatted LocalizableErrorArgument instance.
         ''' </summary>
         Public Overrides Function ToString() As String
-            Return ToString(Nothing)
+            Return ToString_IFormattable(Nothing, Nothing)
         End Function
 
         ''' <summary>

src/Compilers/VisualBasic/Test/Semantic/Compilation/CompilationAPITests.vb

@@ -21,6 +21,13 @@ Namespace Microsoft.CodeAnalysis.VisualBasic.UnitTests
     Public Class CompilationAPITests
         Inherits BasicTestBase
 
+        <Fact>
+        Public Sub LocalizableErrorArgumentToStringDoesntStackOverflow()
+            ' Error ID is arbitrary
+            Dim arg = New LocalizableErrorArgument(ERRID.IDS_ProjectSettingsLocationName)
+            Assert.NotNull(arg.ToString())
+        End Sub
+
         <WorkItem(538778, "DevDiv")>
         <WorkItem(537623, "DevDiv")>
         <Fact>