未验证 提交 a146b803 编写于 作者: A AlekseyTs 提交者: GitHub

Follow-up on adding NullableAnnotation/WithNullableAnnotation APIs to ITypeSymbol. (#39644)

Related to #39641.
Related to #39643.
上级 7d97db43
......@@ -1240,7 +1240,8 @@ class C
}", safe: true, useSymbolAnnotations);
}
[Theory, InlineData(true), InlineData(false)]
[Theory(Skip = "https://github.com/dotnet/roslyn/issues/39641"), InlineData(true), InlineData(false)]
[WorkItem(39641, "https://github.com/dotnet/roslyn/issues/39641")]
public async Task TestSafeWithMatchingSimpleNameInAllLocations(bool useSymbolAnnotations)
{
await TestAsync(
......@@ -1343,7 +1344,7 @@ B.C1 M(B.C1 c1, C2 c2)
{
B.C1 result = (B.C1)c1 ?? new B.C1() ?? B.C1.P ?? new B.C1[0] { }[0] ?? new List<B.C1>()[0] ?? (B.C1?)null;
(global::B.C1 a, int b) = (default, default);
(B.C1 a, int b) = (default, default);
return result;
}
}", safe: true, useSymbolAnnotations);
......
......@@ -43,8 +43,8 @@ public bool AreEquivalent(ISymbol x, ISymbol y, Dictionary<INamedTypeSymbol, INa
throw new InvalidOperationException("Stack too deep.");
}
#endif
// This is a temporary workaround sufficient to get existing tests passing. This component should be
// be modified to properly deal with differences caused by nullability.
// https://github.com/dotnet/roslyn/issues/39643 This is a temporary workaround sufficient to get existing tests passing.
// This component should be modified to properly deal with differences caused by nullability.
if (x is ITypeSymbol xType && y is ITypeSymbol yType && xType.IsDefinition != yType.IsDefinition)
{
if (x.IsDefinition)
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册