提交 9fbd5fea 编写于 作者: G Gen Lu

Address review comments

上级 9d9322c5
......@@ -237,7 +237,7 @@ private static string GetReceiverTypeName(ITypeSymbol typeSymbol)
return completionItemsbuilder.ToImmutable();
// Add string represent complex types (i.e. "" and "[]") to the receiver type, so we would include in the filter
// Add strings represent complex types (i.e. "" and "[]") to the receiver type, so we would include in the filter
// info about extension methods with complex receiver type.
static ImmutableArray<string> AttachComplexTypes(ImmutableArray<string> receiverTypeNames)
{
......@@ -268,8 +268,8 @@ static ImmutableArray<string> AttachComplexTypes(ImmutableArray<string> receiver
// Need to find the matching one in current compilation
// before any further checks is done.
var methodSymbolInCurrentCompilation = isSymbolFromCurrentCompilation
? methodSymbol
: SymbolFinder.FindSimilarSymbols(methodSymbol, semanticModel.Compilation).FirstOrDefault();
? methodSymbol
: SymbolFinder.FindSimilarSymbols(methodSymbol, semanticModel.Compilation).FirstOrDefault();
if (methodSymbolInCurrentCompilation == null
|| !semanticModel.IsAccessible(position, methodSymbolInCurrentCompilation))
......@@ -310,7 +310,7 @@ private static string GetFullyQualifiedNamespaceName(INamespaceSymbol symbol, Di
private static ImmutableArray<IMethodSymbol> GetPotentialMatchingSymbolsFromAssembly(
IAssemblySymbol assembly,
MultiDictionary<string, (string, string)> extensionMethodFilter,
MultiDictionary<string, (string methodName, string receiverTypeName)> extensionMethodFilter,
ISet<string> namespaceFilter,
bool internalsVisible,
StatisticCounter counter,
......@@ -445,7 +445,7 @@ static bool MatchExtensionMethod(IMethodSymbol method, string filterReceiverType
}
// Create filter for extension methods from source.
private static MultiDictionary<string, (string, string)> CreateAggregatedFilter(ImmutableArray<string> receiverTypeNames, CacheEntry syntaxIndex)
private static MultiDictionary<string, (string methodName, string receiverTypeName)> CreateAggregatedFilter(ImmutableArray<string> receiverTypeNames, CacheEntry syntaxIndex)
{
var results = new MultiDictionary<string, (string, string)>();
......@@ -467,7 +467,7 @@ static bool MatchExtensionMethod(IMethodSymbol method, string filterReceiverType
}
// Create filter for extension methods from metadata
private static MultiDictionary<string, (string, string)> CreateAggregatedFilter(ImmutableArray<string> receiverTypeNames, SymbolTreeInfo symbolInfo)
private static MultiDictionary<string, (string methodName, string receiverTypeName)> CreateAggregatedFilter(ImmutableArray<string> receiverTypeNames, SymbolTreeInfo symbolInfo)
{
var results = new MultiDictionary<string, (string, string)>();
......
......@@ -89,7 +89,6 @@ private string GetDebuggerDisplay()
/// <summary>
/// Indicate if the type of parameter is any kind of array (used for both simple and complex types)
/// </summary>
public readonly bool IsArray;
/// <summary>
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册