提交 9cf48870 编写于 作者: S Stefan Nikolei

Changes cause of review

上级 12fb3ca9
...@@ -151,6 +151,25 @@ void Method() ...@@ -151,6 +151,25 @@ void Method()
} }
}", }",
@"class Class @"class Class
{
void Method()
{
}
}");
}
[Fact, Trait(Traits.Feature, Traits.Features.CodeActionsRemoveUnusedVariable)]
public async Task RemoveUnusedVariableFixAll2()
{
await TestAsync(
@"class Class
{
void Method()
{
string a, {|FixAllInDocument:b|};
}
}",
@"class Class
{ {
void Method() void Method()
{ {
......
...@@ -34,8 +34,6 @@ public async override Task RegisterCodeFixesAsync(CodeFixContext context) ...@@ -34,8 +34,6 @@ public async override Task RegisterCodeFixesAsync(CodeFixContext context)
context.RegisterCodeFix( context.RegisterCodeFix(
new MyCodeAction(c => FixAsync(context.Document, context.Diagnostics.First(), c)), new MyCodeAction(c => FixAsync(context.Document, context.Diagnostics.First(), c)),
context.Diagnostics); context.Diagnostics);
return;
} }
protected override Task FixAllAsync(Document document, ImmutableArray<Diagnostic> diagnostics, SyntaxEditor editor, CancellationToken cancellationToken) protected override Task FixAllAsync(Document document, ImmutableArray<Diagnostic> diagnostics, SyntaxEditor editor, CancellationToken cancellationToken)
...@@ -63,7 +61,7 @@ protected override Task FixAllAsync(Document document, ImmutableArray<Diagnostic ...@@ -63,7 +61,7 @@ protected override Task FixAllAsync(Document document, ImmutableArray<Diagnostic
private class MyCodeAction : CodeAction.DocumentChangeAction private class MyCodeAction : CodeAction.DocumentChangeAction
{ {
public MyCodeAction(Func<CancellationToken, Task<Document>> createChangedDocument) : public MyCodeAction(Func<CancellationToken, Task<Document>> createChangedDocument) :
base(FeaturesResources.Remove_Unused_Variable, createChangedDocument, FeaturesResources.Remove_Unused_Variable) base(FeaturesResources.Remove_unused_variable, createChangedDocument, FeaturesResources.Remove_unused_variable)
{ {
} }
} }
......
...@@ -2277,9 +2277,9 @@ internal class FeaturesResources { ...@@ -2277,9 +2277,9 @@ internal class FeaturesResources {
/// <summary> /// <summary>
/// Looks up a localized string similar to Remove unused variable. /// Looks up a localized string similar to Remove unused variable.
/// </summary> /// </summary>
internal static string Remove_Unused_Variable { internal static string Remove_unused_variable {
get { get {
return ResourceManager.GetString("Remove_Unused_Variable", resourceCulture); return ResourceManager.GetString("Remove_unused_variable", resourceCulture);
} }
} }
......
...@@ -1154,7 +1154,7 @@ This version used in: {2}</value> ...@@ -1154,7 +1154,7 @@ This version used in: {2}</value>
<data name="Add_argument_name_0" xml:space="preserve"> <data name="Add_argument_name_0" xml:space="preserve">
<value>Add argument name '{0}'</value> <value>Add argument name '{0}'</value>
</data> </data>
<data name="Remove_Unused_Variable" xml:space="preserve"> <data name="Remove_unused_variable" xml:space="preserve">
<value>Remove unused variable</value> <value>Remove unused variable</value>
</data> </data>
</root> </root>
\ No newline at end of file
...@@ -13,8 +13,8 @@ Namespace Microsoft.CodeAnalysis.VisualBasic.CodeFixes.RemoveUnusedVariable ...@@ -13,8 +13,8 @@ Namespace Microsoft.CodeAnalysis.VisualBasic.CodeFixes.RemoveUnusedVariable
Inherits AbstractRemoveUnusedVariableCodeFixProvider(Of Inherits AbstractRemoveUnusedVariableCodeFixProvider(Of
LocalDeclarationStatementSyntax, ModifiedIdentifierSyntax, VariableDeclaratorSyntax) LocalDeclarationStatementSyntax, ModifiedIdentifierSyntax, VariableDeclaratorSyntax)
Friend Const BC42024 As String = "BC42024" Private Const BC42024 As String = "BC42024"
Friend Shared ReadOnly Ids As ImmutableArray(Of String) = ImmutableArray.Create(BC42024) Private ReadOnly Ids As ImmutableArray(Of String) = ImmutableArray.Create(BC42024)
Public Overrides ReadOnly Property FixableDiagnosticIds As ImmutableArray(Of String) Public Overrides ReadOnly Property FixableDiagnosticIds As ImmutableArray(Of String)
Get Get
...@@ -22,5 +22,4 @@ Namespace Microsoft.CodeAnalysis.VisualBasic.CodeFixes.RemoveUnusedVariable ...@@ -22,5 +22,4 @@ Namespace Microsoft.CodeAnalysis.VisualBasic.CodeFixes.RemoveUnusedVariable
End Get End Get
End Property End Property
End Class End Class
End Namespace End Namespace
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册